]> git.ipfire.org Git - thirdparty/systemd.git/log
thirdparty/systemd.git
3 years agotest: don't wrap binaries built with ASan 23741/head
Frantisek Sumsal [Wed, 15 Jun 2022 17:43:11 +0000 (19:43 +0200)] 
test: don't wrap binaries built with ASan

since they should handle loading other instrumented libraries without
issues.

3 years agotest: drop all LD_PRELOAD-related ASan workarounds
Frantisek Sumsal [Wed, 15 Jun 2022 10:32:51 +0000 (12:32 +0200)] 
test: drop all LD_PRELOAD-related ASan workarounds

since they shouldn't be necessary anymore, as we tweak the "problematic"
binaries on per-binary basis.

3 years agotest: wrap binaries using systemd DSOs when running w/ ASan
Frantisek Sumsal [Tue, 14 Jun 2022 20:54:39 +0000 (22:54 +0200)] 
test: wrap binaries using systemd DSOs when running w/ ASan

Let's detect & wrap binaries which are linked against systemd DSOs and
we're running under ASan, since otherwise running such binaries ends
with:

```
==633==ASan runtime does not come first in initial library list; you should either link runtime to your application or manually preload it with LD_PRELOAD.
```

3 years agoRevert "test: fix TEST-70 under sanitizers"
Frantisek Sumsal [Tue, 14 Jun 2022 20:56:58 +0000 (22:56 +0200)] 
Revert "test: fix TEST-70 under sanitizers"

This reverts commit 47d81bc61315bae917276f978f39f200cf31e106.

3 years agoman: Add some punctuation; remove double spaces.
adrian5 [Tue, 14 Jun 2022 17:42:59 +0000 (19:42 +0200)] 
man: Add some punctuation; remove double spaces.

3 years agopstore: Run after modules are loaded
Alexander Graf [Thu, 9 Jun 2022 14:20:43 +0000 (16:20 +0200)] 
pstore: Run after modules are loaded

The systemd-pstore service takes pstore files on boot and transfers them
to disk. It only does it once on boot and only if it finds any. The typical
location of the pstore on modern systems is the UEFI variable store.

Most distributions ship with CONFIG_EFI_VARS_PSTORE=m. That means, the
UEFI variable store is only available on boot after the respective module
is loaded.

In most situations, the pstore service gets loaded before the UEFI pstore,
so we don't get to transfer logs. Instead, they accumulate, filling up the
pstore over time, potentially breaking the UEFI variable store.

Let's add a service dependency on any kernel module that can provide a
pstore to ensure we only scan for pstate after we can actually see pstate.

I have seen live occurences of systems breaking because we did not erase
the pstates and ran out of UEFI nvram space.

Fixes https://github.com/systemd/systemd/issues/18540

3 years agohwdb: analyzers: remove generic "STM Device in DFU Mode"
Jan Luebbe [Mon, 13 Jun 2022 14:40:18 +0000 (16:40 +0200)] 
hwdb: analyzers: remove generic "STM Device in DFU Mode"

The USB ID v0483pDF11 is used by the ROM code in many STMicroelectronics
devices (for firmware download) and not just signal analyzers.

3 years agosysctl: increase log severity on failed write
Christian Göttsche [Mon, 13 Jun 2022 14:01:04 +0000 (16:01 +0200)] 
sysctl: increase log severity on failed write

Increase the log severity in case of writing to a non existent sysctl
parameter as this can either be caused by a misspelling or a kernel mis-
configuration, e.g. in case YAMA does not get loaded due to a incomplete
lsm= override:

    systemd-sysctl[354]: Couldn't write '1' to 'kernel/yama/ptrace_scope', ignoring: No such file or directory

3 years agopo: Translated using Weblate (Estonian)
H A [Tue, 14 Jun 2022 00:18:52 +0000 (02:18 +0200)] 
po: Translated using Weblate (Estonian)

Currently translated at 70.8% (134 of 189 strings)

Co-authored-by: H A <contact+fedora@hen.ee>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/et/
Translation: systemd/main

3 years agonetwork: l2tp: initialize a to NULL
Shreenidhi Shedi [Sun, 12 Jun 2022 18:06:37 +0000 (23:36 +0530)] 
network: l2tp: initialize a to NULL

Fixes: CID#1475788
3 years agoMerge pull request #23707 from yuwata/dns_service_split
Zbigniew Jędrzejewski-Szmek [Sun, 12 Jun 2022 09:37:20 +0000 (11:37 +0200)] 
Merge pull request #23707 from yuwata/dns_service_split

dns-domain: fix buffer-overflow

3 years agoMerge pull request #23714 from mrc0mmand/networkd-testsuite-tweaks
Yu Watanabe [Sun, 12 Jun 2022 04:16:30 +0000 (13:16 +0900)] 
Merge pull request #23714 from mrc0mmand/networkd-testsuite-tweaks

A couple of assorted tweaks for the systemd-networkd test suite

3 years agomeson: add build targets for libudev, libsystemd and pkg-config
Luca Boccassi [Sat, 11 Jun 2022 17:34:08 +0000 (18:34 +0100)] 
meson: add build targets for libudev, libsystemd and pkg-config

Mirror install tags with the same names and content

3 years agopo: Translated using Weblate (Estonian)
H A [Sat, 11 Jun 2022 23:19:53 +0000 (01:19 +0200)] 
po: Translated using Weblate (Estonian)

Currently translated at 69.8% (132 of 189 strings)

Co-authored-by: H A <contact+fedora@hen.ee>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/et/
Translation: systemd/main

3 years agotest-network: drop unnecessary `global` 23714/head
Frantisek Sumsal [Sat, 11 Jun 2022 16:06:38 +0000 (18:06 +0200)] 
test-network: drop unnecessary `global`

`global` is needed only when assigning a new value to the global
variable; it's not necessary when modifying a mutable object (in our
case we just append items to the global list).

3 years agotest-network: explicitly set encoding when open()ing text files
Frantisek Sumsal [Sat, 11 Jun 2022 16:03:28 +0000 (18:03 +0200)] 
test-network: explicitly set encoding when open()ing text files

3 years agotest-network: make use of f-strings in couple more places
Frantisek Sumsal [Sat, 11 Jun 2022 15:54:59 +0000 (17:54 +0200)] 
test-network: make use of f-strings in couple more places

3 years agotest-network: override networkctl bin w/ valgrind/sanitizers
Frantisek Sumsal [Sat, 11 Jun 2022 15:47:52 +0000 (17:47 +0200)] 
test-network: override networkctl bin w/ valgrind/sanitizers

3 years agoMerge pull request #23708 from yuwata/update-kernel-headers
Luca Boccassi [Sat, 11 Jun 2022 09:18:37 +0000 (10:18 +0100)] 
Merge pull request #23708 from yuwata/update-kernel-headers

Update kernel headers

3 years agoshared/linux: update kernel headers to 5.19-rc1 23708/head
Yu Watanabe [Fri, 10 Jun 2022 21:42:24 +0000 (06:42 +0900)] 
shared/linux: update kernel headers to 5.19-rc1

3 years agobasic/linux: update kernel headers to 5.19-rc1
Yu Watanabe [Fri, 10 Jun 2022 21:40:00 +0000 (06:40 +0900)] 
basic/linux: update kernel headers to 5.19-rc1

3 years agodns-domain: reduce indentation in dns_service_split() 23707/head
Yu Watanabe [Fri, 10 Jun 2022 20:48:35 +0000 (05:48 +0900)] 
dns-domain: reduce indentation in dns_service_split()

3 years agodns-domain: rename function arguments
Yu Watanabe [Fri, 10 Jun 2022 20:28:26 +0000 (05:28 +0900)] 
dns-domain: rename function arguments

3 years agodns-domain: make each label nul-terminated
Yu Watanabe [Fri, 10 Jun 2022 20:51:03 +0000 (05:51 +0900)] 
dns-domain: make each label nul-terminated

dns_label_unescape() does not nul-terminate the buffer if it does not
have enough space. Hence, if a lable is enough long, then strjoin()
triggers buffer-overflow.

Fixes #23705.

3 years agoMerge pull request #23691 from medhefgo/efi-clang
Yu Watanabe [Fri, 10 Jun 2022 20:01:24 +0000 (05:01 +0900)] 
Merge pull request #23691 from medhefgo/efi-clang

efi: Add parse_number8/16

3 years agosystemctl: add `edit` verb to arguments' help text
Elias Probst [Fri, 10 Jun 2022 19:15:11 +0000 (21:15 +0200)] 
systemctl: add `edit` verb to arguments' help text

The arguments `--global`, `--runtime` and `--root` also affect the
`edit` verb.

3 years agoMerge pull request #23701 from medhefgo/boot-mem
Yu Watanabe [Fri, 10 Jun 2022 19:29:27 +0000 (04:29 +0900)] 
Merge pull request #23701 from medhefgo/boot-mem

boot: Use memcpy/memset provided by firmware

3 years agoboot: use efi_memcpy inplace of memcpy
Shreenidhi Shedi [Fri, 10 Jun 2022 10:09:50 +0000 (15:39 +0530)] 
boot: use efi_memcpy inplace of memcpy

`efi_memcpy` does some validations before referencing pointers, it is
the safer option for this case.

Fixes: CID#1489876
3 years agoshared/condition: accept size suffixes for ConditionMemory
Zbigniew Jędrzejewski-Szmek [Fri, 10 Jun 2022 12:55:00 +0000 (14:55 +0200)] 
shared/condition: accept size suffixes for ConditionMemory

Fixes #23697.

3 years agoMerge pull request #23687 from yuwata/dns-domain-trivial-cleanups
Luca Boccassi [Fri, 10 Jun 2022 18:50:22 +0000 (19:50 +0100)] 
Merge pull request #23687 from yuwata/dns-domain-trivial-cleanups

dns-domain: trivial cleanups

3 years agoMerge pull request #23584 from yuwata/test-login
Frantisek Sumsal [Fri, 10 Jun 2022 14:50:35 +0000 (14:50 +0000)] 
Merge pull request #23584 from yuwata/test-login

test: import logind test from debian/ubuntu test suite

3 years agoMerge pull request #23690 from yuwata/test-sd-device
Frantisek Sumsal [Fri, 10 Jun 2022 14:50:01 +0000 (14:50 +0000)] 
Merge pull request #23690 from yuwata/test-sd-device

test: several tweaks for test-sd-device

3 years agoboot: Use memcpy/memset provided by firmware 23701/head
Jan Janssen [Fri, 10 Jun 2022 13:29:39 +0000 (15:29 +0200)] 
boot: Use memcpy/memset provided by firmware

These are significantly faster and safe us from rolling our own
optimized versions.

3 years agoboot: Mark memcmp/memcpy/memset aliases as used
Jan Janssen [Fri, 10 Jun 2022 13:20:01 +0000 (15:20 +0200)] 
boot: Mark memcmp/memcpy/memset aliases as used

The compiler may emit calls to these but also optimize the function away
somehow, breaking at link stage. Marking them as used prevents this.

3 years agodocs/CONTRIBUTING: ask people to send a ping on stalled reviews
Zbigniew Jędrzejewski-Szmek [Fri, 10 Jun 2022 12:08:40 +0000 (14:08 +0200)] 
docs/CONTRIBUTING: ask people to send a ping on stalled reviews

A few related changes: be explicit that 'main' is the branch we're referring
to. There was a case recently of somebody rebasing on 'master' by mistake.
It's better to be explicit, since 'main' is still not the default for git
(AFAIK).

Also, github seems to send mails about force-pushes, so drop that as a
justification. Commenting about changes that were done is useful even if
github were to send a notification.

And finally, $subject. We do that ourselves, but outside contributors might not
know that that's expected.

3 years agoefi-string: Remove one more |= for bool
Jan Janssen [Fri, 10 Jun 2022 07:32:34 +0000 (09:32 +0200)] 
efi-string: Remove one more |= for bool

This one was missed in #23589.

3 years agoMerge pull request #23683 from keszybz/status-format
Zbigniew Jędrzejewski-Szmek [Fri, 10 Jun 2022 12:11:53 +0000 (14:11 +0200)] 
Merge pull request #23683 from keszybz/status-format

Default to default-status-unit-format=name in developer mode

3 years agomeson: add experimental bpf-gcc compiler support
James Hilliard [Wed, 8 Jun 2022 10:13:42 +0000 (10:13 +0000)] 
meson: add experimental bpf-gcc compiler support

Not fully working but should make it easier to clean up remaining
issues.

3 years agoMerge pull request #23689 from yuwata/test-timedate
Zbigniew Jędrzejewski-Szmek [Fri, 10 Jun 2022 11:56:48 +0000 (13:56 +0200)] 
Merge pull request #23689 from yuwata/test-timedate

test: import timedated test from debian/ubuntu test suite

3 years agodocs: desaturate dark-mode background color
Benjamin Franzke [Fri, 3 Jun 2022 20:44:42 +0000 (22:44 +0200)] 
docs: desaturate dark-mode background color

The documentations dark-mode background color as
added in #23417 was perceived to be too purple-y [1]
and is therefore replaced by a desaturated black
that is derived from the systemd brand-black using
12% less HSL saturation.

[1] https://github.com/systemd/systemd/pull/23417#issuecomment-1146323820

3 years agomeson: use status-unit-format-default=name in developer mode 23683/head
Zbigniew Jędrzejewski-Szmek [Thu, 9 Jun 2022 18:33:29 +0000 (20:33 +0200)] 
meson: use status-unit-format-default=name in developer mode

I think developers are particularly unlikely to find the descriptions
useful, and would benefit from being able to copy&paste unit names.
Let's make this choice automatically.

3 years agomeson: add status unit format to summary
Zbigniew Jędrzejewski-Szmek [Thu, 9 Jun 2022 18:32:22 +0000 (20:32 +0200)] 
meson: add status unit format to summary

3 years agoboot: Use parse_number16 for boot counter parsing 23691/head
Jan Janssen [Thu, 2 Jun 2022 09:23:12 +0000 (11:23 +0200)] 
boot: Use parse_number16 for boot counter parsing

3 years agoboot: Drop use of Atoi
Jan Janssen [Wed, 1 Jun 2022 11:42:23 +0000 (13:42 +0200)] 
boot: Drop use of Atoi

3 years agoboot: Add parse_number8/16
Jan Janssen [Wed, 1 Jun 2022 11:35:29 +0000 (13:35 +0200)] 
boot: Add parse_number8/16

3 years agoMerge pull request #23688 from yuwata/boot-efi-string-efi_fnmatch-fix-over-flow
Yu Watanabe [Fri, 10 Jun 2022 09:47:15 +0000 (18:47 +0900)] 
Merge pull request #23688 from yuwata/boot-efi-string-efi_fnmatch-fix-over-flow

boot/efi-string: check the end of haystack before testing remaining pattern

3 years agotest: exclude network interfaces 23690/head
Yu Watanabe [Fri, 10 Jun 2022 06:38:51 +0000 (15:38 +0900)] 
test: exclude network interfaces

After https://github.com/systemd/systemd-centos-ci/pull/492 is merged,
the networkd test may be running when test-sd-device is invoked.
Let's exclude net subsystem.

3 years agotest: import timedated test from debian/ubuntu test suite 23689/head
Yu Watanabe [Fri, 10 Jun 2022 04:55:54 +0000 (13:55 +0900)] 
test: import timedated test from debian/ubuntu test suite

3 years agotest: import logind test from debian/ubuntu test suite 23584/head
Yu Watanabe [Tue, 31 May 2022 23:56:08 +0000 (08:56 +0900)] 
test: import logind test from debian/ubuntu test suite

3 years agotest: always exclude devices named loop*
Yu Watanabe [Fri, 10 Jun 2022 06:36:17 +0000 (15:36 +0900)] 
test: always exclude devices named loop*

Not only block subsystem, but also misc has device named "loop*", and
the test always said that the following device is newly found:
---
/* test_sd_device_enumerator_filter_subsystem */
New device found: subsystem:misc syspath:/sys/devices/virtual/misc/loop-control
1 new devices are found in re-scan
---

3 years agotest: drop redundant IMAGE_NAME=
Yu Watanabe [Fri, 10 Jun 2022 03:31:10 +0000 (12:31 +0900)] 
test: drop redundant IMAGE_NAME=

If it is not specified, then "default" will be used.

3 years agoboot/efi-string: check the end of haystack before testing remaining pattern 23688/head
Yu Watanabe [Fri, 10 Jun 2022 02:43:00 +0000 (11:43 +0900)] 
boot/efi-string: check the end of haystack before testing remaining pattern

Fixes buffer-overflow reported at https://github.com/systemd/systemd/pull/23589#issuecomment-1151820341.

3 years agodevnode-acl: use set_put_strdup_full() and set_ensure_consume()
Yu Watanabe [Fri, 3 Jun 2022 09:01:35 +0000 (18:01 +0900)] 
devnode-acl: use set_put_strdup_full() and set_ensure_consume()

3 years agodns-domain: simplify code a bit 23687/head
Yu Watanabe [Fri, 10 Jun 2022 00:49:07 +0000 (09:49 +0900)] 
dns-domain: simplify code a bit

3 years agodns-domain: use dns_name_concat()
Yu Watanabe [Fri, 10 Jun 2022 00:42:24 +0000 (09:42 +0900)] 
dns-domain: use dns_name_concat()

`dns_name_normalize()` is an alias of `dns_name_concat()`.
For consistency with `dns_name_is_valid_ldh()`, let's use
`dns_name_concat()`.

3 years agoMerge pull request #23589 from medhefgo/efi-clang
Yu Watanabe [Thu, 9 Jun 2022 23:54:48 +0000 (08:54 +0900)] 
Merge pull request #23589 from medhefgo/efi-clang

boot: Drop use of several gnu-efi functions

3 years agofix: sd_id128_get_invocation now works for user services
i-do-cpp [Sat, 4 Jun 2022 20:18:05 +0000 (22:18 +0200)] 
fix: sd_id128_get_invocation now works for user services

3 years agotree-wide: fix typo
Yu Watanabe [Thu, 9 Jun 2022 23:26:08 +0000 (08:26 +0900)] 
tree-wide: fix typo

3 years agopo: Translated using Weblate (Estonian)
H A [Thu, 9 Jun 2022 21:18:44 +0000 (23:18 +0200)] 
po: Translated using Weblate (Estonian)

Currently translated at 18.5% (35 of 189 strings)

Co-authored-by: H A <contact+fedora@hen.ee>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/et/
Translation: systemd/main

3 years agotest: account for ADDR_NO_RANDOMIZE if it's set
Frantisek Sumsal [Thu, 9 Jun 2022 09:34:09 +0000 (11:34 +0200)] 
test: account for ADDR_NO_RANDOMIZE if it's set

On ppc64le sanitizers disable ASLR (i.e. by setting ADDR_NO_RANDOMIZE),
which opinionated_personality() doesn't return. Let's tweak the current
personality ourselves in such cases.

See: https://github.com/llvm/llvm-project/commit/78f7a6eaa601bfdd6ae70ffd3da2254c21ff77f9

Resolves: #23666

3 years agoMerge pull request #23348 from medhefgo/log-shutdown-blockers
Yu Watanabe [Thu, 9 Jun 2022 20:33:37 +0000 (05:33 +0900)] 
Merge pull request #23348 from medhefgo/log-shutdown-blockers

shutdown: Log processes that block umount

3 years agoMerge pull request #23658 from keszybz/gcc-warnings-2
Luca Boccassi [Thu, 9 Jun 2022 16:48:09 +0000 (17:48 +0100)] 
Merge pull request #23658 from keszybz/gcc-warnings-2

Fixes for NULL-pointer arguments based on gcc warnings

3 years agobpf: use __always_inline macro in restrict-ifaces.bpf.c
James Hilliard [Thu, 9 Jun 2022 06:36:29 +0000 (00:36 -0600)] 
bpf: use __always_inline macro in restrict-ifaces.bpf.c

This appears to be more reliable at inlining with some compilers.

3 years agomeson: Build with frame pointers in developer mode
Daan De Meyer [Wed, 8 Jun 2022 20:32:49 +0000 (22:32 +0200)] 
meson: Build with frame pointers in developer mode

Profiling tools tend to work better when binaries and libraries
are compiled with frame pointers as without them there's no easy
and fast way to get the current stacktrace.

3 years agoshutdown: Lazy unmount /oldroot/{dev,proc,sys} 23348/head
Jan Janssen [Wed, 18 May 2022 06:12:31 +0000 (08:12 +0200)] 
shutdown: Lazy unmount /oldroot/{dev,proc,sys}

These should not prevent us from cleaning up the remainders of /oldroot
if something in the kernel is blocking these from being unmounted.

3 years agoshutdown: Log processes that block umount
Jan Janssen [Wed, 11 May 2022 09:10:11 +0000 (11:10 +0200)] 
shutdown: Log processes that block umount

3 years agoshutdown: Rename umount_log_level and make it a bool
Jan Janssen [Thu, 9 Jun 2022 14:50:54 +0000 (16:50 +0200)] 
shutdown: Rename umount_log_level and make it a bool

This was already effectively a bool because only ever two states were
valid. To make the meaning of it more clear, also rename it to last_try.

3 years agoMerge pull request #23680 from keszybz/boot-loader-counting
Luca Boccassi [Thu, 9 Jun 2022 12:16:14 +0000 (13:16 +0100)] 
Merge pull request #23680 from keszybz/boot-loader-counting

Move boot counting into BLS proper

3 years agosystemctl: simplify code a bit 23658/head
Zbigniew Jędrzejewski-Szmek [Tue, 7 Jun 2022 14:26:18 +0000 (16:26 +0200)] 
systemctl: simplify code a bit

gcc insists that bus may be used unitialized here, but I don't see any
possibility of that.

3 years agoshared/bus-util: rename variables to follow newer style
Zbigniew Jędrzejewski-Szmek [Tue, 7 Jun 2022 14:23:36 +0000 (16:23 +0200)] 
shared/bus-util: rename variables to follow newer style

3 years agoshared/bus-util: simplification
Zbigniew Jędrzejewski-Szmek [Tue, 7 Jun 2022 14:21:25 +0000 (16:21 +0200)] 
shared/bus-util: simplification

3 years agotest-udev-util: do not pass NULL to printf, style fixes
Zbigniew Jędrzejewski-Szmek [Tue, 7 Jun 2022 14:10:58 +0000 (16:10 +0200)] 
test-udev-util: do not pass NULL to printf, style fixes

3 years agotest-process-util: do not pass NULL to printf, simplify tests
Zbigniew Jędrzejewski-Szmek [Tue, 7 Jun 2022 14:03:12 +0000 (16:03 +0200)] 
test-process-util: do not pass NULL to printf, simplify tests

We don't need to fork to test that the function returns -EINVAL
on null input. So let's simplify things a bit.

3 years agotest-dns-domain: a few more "NULL in printf %s"s
Zbigniew Jędrzejewski-Szmek [Tue, 7 Jun 2022 13:33:22 +0000 (15:33 +0200)] 
test-dns-domain: a few more "NULL in printf %s"s

3 years agotest-fstab-util: one more "NULL in printf %s"
Zbigniew Jędrzejewski-Szmek [Tue, 7 Jun 2022 13:25:43 +0000 (15:25 +0200)] 
test-fstab-util: one more "NULL in printf %s"

3 years agovarious: indentation
Zbigniew Jędrzejewski-Szmek [Tue, 7 Jun 2022 13:15:17 +0000 (15:15 +0200)] 
various: indentation

3 years agodocs/AUTOMATIC_BOOT_ASSESSMENT: describe how to integrate a DE viability check 23680/head
Zbigniew Jędrzejewski-Szmek [Thu, 9 Jun 2022 10:21:23 +0000 (12:21 +0200)] 
docs/AUTOMATIC_BOOT_ASSESSMENT: describe how to integrate a DE viability check

I reordered the component list to match chronological order: we first install
an entry, then boot it, then the checks happen, etc. Before it was
ordered by "importance", but that is harder to follow.

3 years agodocs/BLS: move "boot counting" into the main spec
Zbigniew Jędrzejewski-Szmek [Thu, 9 Jun 2022 10:15:46 +0000 (12:15 +0200)] 
docs/BLS: move "boot counting" into the main spec

The boot-counting file-renaming entry-sorting part that the boot
loader implements is moved to the main document. The second document
describes a specific implementation that is provided through systemd
units.

The sorting algorithm is extended to say that bad entries should
be sorted later.

I also added a note that bad entries should be available for booting.

For some reason, the second document said that it applies only to EFI systems.
AFAIK there are no implementations for non-EFI, but the specification should
work just fine, if somebody were to implement it. So that part is dropped.

Fixes #23345.

Sadly, bootctl doesn't implement sorting of boot entries with counting :((((
But I'm leaving that for another PR.

3 years agoMerge pull request #23654 from keszybz/gcc-warnings
Zbigniew Jędrzejewski-Szmek [Thu, 9 Jun 2022 10:55:47 +0000 (12:55 +0200)] 
Merge pull request #23654 from keszybz/gcc-warnings

Fixes for NULL-pointer arguments based on gcc warnings

3 years agoMerge pull request #23678 from aafeijoo-suse/shell-completion-cryptenroll
Zbigniew Jędrzejewski-Szmek [Thu, 9 Jun 2022 10:54:06 +0000 (12:54 +0200)] 
Merge pull request #23678 from aafeijoo-suse/shell-completion-cryptenroll

bash-completion: add systemd-cryptenroll support

3 years agoboot: Drop use of DuplicateDevicePath 23589/head
Jan Janssen [Sun, 29 May 2022 09:08:40 +0000 (11:08 +0200)] 
boot: Drop use of DuplicateDevicePath

3 years agoboot: Don't copy device path
Jan Janssen [Sun, 29 May 2022 09:03:43 +0000 (11:03 +0200)] 
boot: Don't copy device path

BS->LocateDevicePath only advances the passed device path pointer.
It does not actually modify it, so there is no need to make a copy.

3 years agoboot: Drop use of LibLocateHandle
Jan Janssen [Sun, 29 May 2022 08:38:19 +0000 (10:38 +0200)] 
boot: Drop use of LibLocateHandle

3 years agoboot: Drop use of UnpackDevicePath
Jan Janssen [Sun, 29 May 2022 08:33:42 +0000 (10:33 +0200)] 
boot: Drop use of UnpackDevicePath

Device paths are a packed data structure and the UEFI spec is clear that
members may be misaligned.

In this case all accesses are aligned except for the signature. We can
simply memcpy it instead of making a whole (aligned) copy of the device
path.

3 years agoboot: Drop use of FileDevicePath
Jan Janssen [Sun, 29 May 2022 08:26:18 +0000 (10:26 +0200)] 
boot: Drop use of FileDevicePath

3 years agoboot: Use xmalloc
Jan Janssen [Sat, 28 May 2022 17:36:21 +0000 (19:36 +0200)] 
boot: Use xmalloc

This drops the unused xnew0 and xallocate_zero_pool as there is only two
users of it. _cleanup_freepool_ will be phased out once the types in the
declarations are changed/renamed.

3 years agoboot: Add xmalloc
Jan Janssen [Sat, 28 May 2022 17:29:41 +0000 (19:29 +0200)] 
boot: Add xmalloc

3 years agoboot: Drop use of DevicePathFromHandle
Jan Janssen [Thu, 26 May 2022 11:07:30 +0000 (13:07 +0200)] 
boot: Drop use of DevicePathFromHandle

3 years agoboot: Drop use of LibLocateProtocol
Jan Janssen [Thu, 26 May 2022 08:59:53 +0000 (10:59 +0200)] 
boot: Drop use of LibLocateProtocol

3 years agoboot: Drop use of LibOpenRoot
Jan Janssen [Thu, 26 May 2022 08:46:58 +0000 (10:46 +0200)] 
boot: Drop use of LibOpenRoot

3 years agoboot: Drop use of LibGetSystemConfigurationTable
Jan Janssen [Thu, 26 May 2022 08:27:32 +0000 (10:27 +0200)] 
boot: Drop use of LibGetSystemConfigurationTable

3 years agoboot: Drop use of MetaiMatch
Jan Janssen [Thu, 9 Jun 2022 08:07:06 +0000 (10:07 +0200)] 
boot: Drop use of MetaiMatch

A future commit will add support for unicode collation protocol that
allows case folding and comparing strings with locale awareness. But it
only operates on whole strings, so fnmatch cannot use those without a
heavy cost. Instead we just case fold the patterns instead (the IDs we
try to match are already lower case).

3 years agoboot: Add efi_fnmatch
Jan Janssen [Thu, 9 Jun 2022 08:05:52 +0000 (10:05 +0200)] 
boot: Add efi_fnmatch

Unlike MetaiMatch from the UEFI spec/EDK2 this implementation is
intended to be compatible with POSIX fnmatch.

3 years agobash-completion: add systemd-cryptenroll support 23678/head
Antonio Alvarez Feijoo [Thu, 9 Jun 2022 09:47:10 +0000 (11:47 +0200)] 
bash-completion: add systemd-cryptenroll support

3 years agobash-completion: fix typos in comments
Antonio Alvarez Feijoo [Thu, 9 Jun 2022 09:46:50 +0000 (11:46 +0200)] 
bash-completion: fix typos in comments

3 years agoResolve conflicts between #23616 and the recent NFT additions
Zbigniew Jędrzejewski-Szmek [Thu, 9 Jun 2022 08:06:11 +0000 (10:06 +0200)] 
Resolve conflicts between #23616 and the recent NFT additions

3 years agoMerge pull request #23616 from keszybz/in-addr-to-string-formatting
Yu Watanabe [Thu, 9 Jun 2022 06:21:57 +0000 (15:21 +0900)] 
Merge pull request #23616 from keszybz/in-addr-to-string-formatting

Add macros that allocate a fixed buffer for in_addr_to_string(), in_addr_prefix+to_string()

3 years agotest-load-fragment: don't print NULLs 23654/head
Zbigniew Jędrzejewski-Szmek [Tue, 7 Jun 2022 10:22:29 +0000 (12:22 +0200)] 
test-load-fragment: don't print NULLs

3 years agotest-bus-address: silence gcc warning about NULL arg to strcmp()
Zbigniew Jędrzejewski-Szmek [Tue, 7 Jun 2022 10:13:42 +0000 (12:13 +0200)] 
test-bus-address: silence gcc warning about NULL arg to strcmp()

The code was overly complicated… We know what value we expect, we can test it
directly.

3 years agotest-mountpoint-util: fix NULL arg to %s
Zbigniew Jędrzejewski-Szmek [Tue, 7 Jun 2022 09:20:09 +0000 (11:20 +0200)] 
test-mountpoint-util: fix NULL arg to %s