]> git.ipfire.org Git - thirdparty/systemd.git/log
thirdparty/systemd.git
5 months agobasic/terminal-util: drop now-unused default_term_for_tty 37538/head
Zbigniew Jędrzejewski-Szmek [Tue, 27 May 2025 16:12:00 +0000 (18:12 +0200)] 
basic/terminal-util: drop now-unused default_term_for_tty

5 months agocore: use terminal DCS sequence to set $TERM
Zbigniew Jędrzejewski-Szmek [Tue, 20 May 2025 17:02:31 +0000 (19:02 +0200)] 
core: use terminal DCS sequence to set $TERM

query_term_for_tty() is used in two places: in fixup_environment(),
which affects PID1 itself, and in build_environment(), which affects
spawned services. There is obviously some cost to the extra call,
but I think it's worthwhile to do it. When $TERM is set incorrectly,
basic output works OK, but then there are various annoying corner
cases. In particular, we get the support for color (or lack of it)
wrong, and when output is garbled, users are annoyed. Things like
text editors are almost certain to behave incorrectly. Testing in
test-terminal-util indicates that the time required to make a successful
query is on the order of a dozen microseconds, and an unsuccessful
query costs as much as our timeout, i.e. currently 1/3 ms. I think
this is an acceptable tradeoff.

No caching is used, because fixup_environment() is only called once,
and the other place in build_environment(), only affects services
which are connected to a tty, which is only a handful of services,
and often only started in special circumstances.

Fixes https://github.com/systemd/systemd/issues/36994.

5 months agobasic/terminal-util: add a heuristic check whether terminfo file exists
Zbigniew Jędrzejewski-Szmek [Mon, 19 May 2025 13:50:42 +0000 (15:50 +0200)] 
basic/terminal-util: add a heuristic check whether terminfo file exists

5 months agotest-terminal-util: print how long the asynchronous queries take
Zbigniew Jędrzejewski-Szmek [Sat, 17 May 2025 14:07:50 +0000 (16:07 +0200)] 
test-terminal-util: print how long the asynchronous queries take

5 months agobasic/terminal-util: query terminal name by DCS
Zbigniew Jędrzejewski-Szmek [Fri, 16 May 2025 13:30:02 +0000 (15:30 +0200)] 
basic/terminal-util: query terminal name by DCS

As requested in https://github.com/systemd/systemd/issues/36994,
use DCS + q name ST. This works, but has limited terminal support:
xterm, foot, kitty.

5 months agoupdate TODO
Lennart Poettering [Mon, 26 May 2025 11:46:10 +0000 (13:46 +0200)] 
update TODO

5 months agounits: enable watchdog notifications for vmspawn
Lennart Poettering [Fri, 23 May 2025 13:45:00 +0000 (15:45 +0200)] 
units: enable watchdog notifications for vmspawn

nspawn supports it and enables it. Let's do this for vmspawn too. It
already supports it in code. Let's make it also work in the unit file.

5 months agotree-wide: Clean up more includes
Daan De Meyer [Fri, 23 May 2025 10:15:45 +0000 (12:15 +0200)] 
tree-wide: Clean up more includes

5 months agobasic + fundamental: Clean up includes (#37595)
Daan De Meyer [Mon, 26 May 2025 07:15:30 +0000 (09:15 +0200)] 
basic + fundamental: Clean up includes (#37595)

5 months agobasic + fundamental: Clean up includes 37595/head
Daan De Meyer [Thu, 22 May 2025 14:08:26 +0000 (16:08 +0200)] 
basic + fundamental: Clean up includes

Split out of #37344.

5 months agologin-util: Mark session_id_valid() as pure
Daan De Meyer [Sun, 25 May 2025 08:05:47 +0000 (10:05 +0200)] 
login-util: Mark session_id_valid() as pure

5 months agobasic: Move userns_supported() to namespace-util.h
Daan De Meyer [Sun, 25 May 2025 08:00:54 +0000 (10:00 +0200)] 
basic: Move userns_supported() to namespace-util.h

5 months agostrv: Drop unnecessary macros
Daan De Meyer [Sun, 25 May 2025 07:58:09 +0000 (09:58 +0200)] 
strv: Drop unnecessary macros

5 months agobasic: Move LogRatelimit struct to log-ratelimit.h as well
Daan De Meyer [Sun, 25 May 2025 06:28:13 +0000 (08:28 +0200)] 
basic: Move LogRatelimit struct to log-ratelimit.h as well

5 months agodocs: add man pages for sd_device_enumerator_[new,ref,unref,unrefp] (#37586)
Shubhendra Kushwaha [Sat, 24 May 2025 20:01:27 +0000 (01:31 +0530)] 
docs: add man pages for sd_device_enumerator_[new,ref,unref,unrefp] (#37586)

For #20929.

5 months agoVarious cleanups (#37597)
Daan De Meyer [Sat, 24 May 2025 19:48:04 +0000 (21:48 +0200)] 
Various cleanups (#37597)

5 months agoTwo follow ups for #37591 (#37594)
Yu Watanabe [Sat, 24 May 2025 19:22:42 +0000 (04:22 +0900)] 
Two follow ups for #37591 (#37594)

5 months agoclangd: Enable UnusedIncludes feature again 37597/head
Daan De Meyer [Fri, 23 May 2025 11:54:46 +0000 (13:54 +0200)] 
clangd: Enable UnusedIncludes feature again

Now that the entire free doesn't trigger any clang unused include
violations anymore, let's re-enable the clangd option as it's much
more useful now that the tree is clean.

5 months agoclang-tidy: Skip public headers
Daan De Meyer [Fri, 23 May 2025 11:03:57 +0000 (13:03 +0200)] 
clang-tidy: Skip public headers

We're very limited in our ability to change these due to backwards
compat, so let's skip them from analysis since we won't be able to
fix the errors anyway.

5 months agoci: Setup clang-tidy meson env with extra options
Daan De Meyer [Wed, 21 May 2025 10:55:35 +0000 (12:55 +0200)] 
ci: Setup clang-tidy meson env with extra options

We want the relevant code to be compiled so that it can be analyzed
by clang-tidy.

5 months agocore: Add missing bpf-dlopen.h includes to bpf skeleton headers
Daan De Meyer [Fri, 23 May 2025 11:36:55 +0000 (13:36 +0200)] 
core: Add missing bpf-dlopen.h includes to bpf skeleton headers

5 months agofundamental: Move declaration of free() to macro-fundamental.h
Daan De Meyer [Fri, 23 May 2025 11:32:52 +0000 (13:32 +0200)] 
fundamental: Move declaration of free() to macro-fundamental.h

Let's put it together with the macro that needs it (mfree()). Also,
get rid of the unnecessary <stdlib.h> include in iovec-util-fundamental.h.

5 months agogenerate-sym-test: Only include required headers
Daan De Meyer [Fri, 23 May 2025 09:27:31 +0000 (11:27 +0200)] 
generate-sym-test: Only include required headers

If we don't use any symbols from a header, let's not include it.

5 months agonetlink-internal: Make message_get_serial() static inline again 37594/head
Daan De Meyer [Sat, 24 May 2025 18:44:32 +0000 (20:44 +0200)] 
netlink-internal: Make message_get_serial() static inline again

There was no need to move this function to the implementation file,
so let's make it static inline again.

Follow up for #37591.

5 months agoforward: Move ChaseFlags forward declaration to forward.h
Daan De Meyer [Sat, 24 May 2025 18:44:12 +0000 (20:44 +0200)] 
forward: Move ChaseFlags forward declaration to forward.h

5 months agolibsystemd: Clean up includes
Daan De Meyer [Thu, 22 May 2025 09:27:45 +0000 (11:27 +0200)] 
libsystemd: Clean up includes

For libsystemd's headers, the changes made depend on whether the
header is installed or not. For installed headers, the only change
made is that commonly included headers were moved to _sd-common.h.
For these headers, there should be no noticeable change in behavior
when including them. For non-installed headers, includes were replaced
with forward declarations where possible as usual.

Split out of #37344.

5 months agobasic: Move ratelimit logging functions to log-ratelimit.h
Daan De Meyer [Sat, 24 May 2025 17:55:42 +0000 (19:55 +0200)] 
basic: Move ratelimit logging functions to log-ratelimit.h

5 months agoshared: Followups for #37575
Daan De Meyer [Sat, 24 May 2025 17:49:08 +0000 (19:49 +0200)] 
shared: Followups for #37575

5 months agolibudev: Clean up includes
Daan De Meyer [Thu, 22 May 2025 09:19:15 +0000 (11:19 +0200)] 
libudev: Clean up includes

Split out of #37344.

5 months agoBugprone argument comment 7 (#37556)
Yu Watanabe [Sat, 24 May 2025 16:53:13 +0000 (01:53 +0900)] 
Bugprone argument comment 7 (#37556)

Follow up from https://github.com/systemd/systemd/pull/37507

5 months agotreewide: correct argument name to user_icon / askpw_icon 37556/head
Jelle van der Waa [Thu, 22 May 2025 08:43:55 +0000 (10:43 +0200)] 
treewide: correct argument name to user_icon / askpw_icon

5 months agokillall: correct argument comment
Jelle van der Waa [Wed, 21 May 2025 18:49:19 +0000 (20:49 +0200)] 
killall: correct argument comment

5 months agovalidatefs: correct argument comments
Jelle van der Waa [Wed, 21 May 2025 18:44:59 +0000 (20:44 +0200)] 
validatefs: correct argument comments

These functions come from util-linux and can't be renamed.

5 months agosd-bus: rename 'add_callback' -> 'install_callback'
Jelle van der Waa [Wed, 21 May 2025 18:34:03 +0000 (20:34 +0200)] 
sd-bus: rename 'add_callback' -> 'install_callback'

Throughout the whole codebase it is called install_callback.

5 months agotpm2-util: rename 'policy' -> 'pcrlock_policy'
Jelle van der Waa [Wed, 21 May 2025 18:22:10 +0000 (20:22 +0200)] 
tpm2-util: rename 'policy' -> 'pcrlock_policy'

Follow the used argument comment naming.

5 months agocreds-util: correct argument comment
Jelle van der Waa [Wed, 21 May 2025 18:19:12 +0000 (20:19 +0200)] 
creds-util: correct argument comment

5 months agopcrlock: correct argument comment
Jelle van der Waa [Wed, 21 May 2025 18:16:05 +0000 (20:16 +0200)] 
pcrlock: correct argument comment

5 months agocgroup-util: rename 'kill_log' -> 'log_kill'
Jelle van der Waa [Sat, 24 May 2025 15:06:04 +0000 (17:06 +0200)] 
cgroup-util: rename 'kill_log' -> 'log_kill'

Rename according to the implementation.

5 months agocgroup-util: rename 's' -> 'killed_pids'
Jelle van der Waa [Wed, 21 May 2025 18:04:55 +0000 (20:04 +0200)] 
cgroup-util: rename 's' -> 'killed_pids'

5 months agomachine-id-setup: correct argument comments
Jelle van der Waa [Wed, 21 May 2025 18:02:32 +0000 (20:02 +0200)] 
machine-id-setup: correct argument comments

5 months agodissect-image: rename 'dest' -> 'where'
Jelle van der Waa [Wed, 21 May 2025 17:52:11 +0000 (19:52 +0200)] 
dissect-image: rename 'dest' -> 'where'

Consistently name dissect_image_mount*.

5 months agosd-bus: prefix return arguments with 'ret_' for sd_bus_message_peek_type
Jelle van der Waa [Wed, 21 May 2025 17:28:58 +0000 (19:28 +0200)] 
sd-bus: prefix return arguments with 'ret_' for sd_bus_message_peek_type

5 months agofuzz: correct argument comment
Jelle van der Waa [Wed, 21 May 2025 17:23:20 +0000 (19:23 +0200)] 
fuzz: correct argument comment

5 months agoshared: Clean up includes
Daan De Meyer [Thu, 22 May 2025 09:17:20 +0000 (11:17 +0200)] 
shared: Clean up includes

Split out of #37344.

5 months agolinux: update kernel headers from v6.15-rc7
Yu Watanabe [Fri, 23 May 2025 18:03:57 +0000 (03:03 +0900)] 
linux: update kernel headers from v6.15-rc7

5 months agohwdb: merge entries for Ettus Research B200
Yu Watanabe [Fri, 23 May 2025 15:13:02 +0000 (00:13 +0900)] 
hwdb: merge entries for Ettus Research B200

Follow-up for 9dad00ef94e6207642f04496c56a4123a396530c.

5 months agohostname: two trivial cleanups (#37583)
Yu Watanabe [Fri, 23 May 2025 16:56:25 +0000 (01:56 +0900)] 
hostname: two trivial cleanups (#37583)

5 months agocore: renames in io.systemd.Manager (#37582)
Mike Yuan [Fri, 23 May 2025 15:46:26 +0000 (17:46 +0200)] 
core: renames in io.systemd.Manager (#37582)

1. rename sources to follow `core/varlink-*` patter per @YHNdnzj's
comment in
https://github.com/systemd/systemd/pull/35098#issuecomment-2876509919
2. camelCase Context/Runtime in varlink spec. Varlink fields are
camelCase unless well defined config names.

5 months agologinctl,machinectl: use LESS_BY() where appropriate
Lennart Poettering [Fri, 23 May 2025 07:24:24 +0000 (09:24 +0200)] 
loginctl,machinectl: use LESS_BY() where appropriate

And while we are at it, add a lower bound of the display output to 10
for all three cases, because it's pointless outputting someting with
less space.

5 months agopath-util: add flavour of path_startswith() that leaves a leading slash in place...
Yu Watanabe [Fri, 23 May 2025 15:20:40 +0000 (00:20 +0900)] 
path-util: add flavour of path_startswith() that leaves a leading slash in place (#37572)

5 months agohwdb: add RTL-SDR devices
AsciiWolf [Fri, 23 May 2025 12:28:16 +0000 (14:28 +0200)] 
hwdb: add RTL-SDR devices

5 months agohostname: use FOREACH_ARGUMENT() at one more place 37583/head
Yu Watanabe [Fri, 23 May 2025 14:24:27 +0000 (23:24 +0900)] 
hostname: use FOREACH_ARGUMENT() at one more place

Follow-up for 29a352e8c14c51983ba661cb5f4ce51e2bc8664b.

5 months agohostname: use proper type
Yu Watanabe [Fri, 23 May 2025 14:19:40 +0000 (23:19 +0900)] 
hostname: use proper type

5 months agohostname: add hardware family, sku and version (#36956)
Yu Watanabe [Fri, 23 May 2025 14:17:01 +0000 (23:17 +0900)] 
hostname: add hardware family, sku and version (#36956)

Add support for the hardware family, SKU (Stock-Keeping Unit) and
version. The values are read from the file /etc/machine-info or DMI as
fallback.

The entries are useful to provide an unified interface to collect detail
hardware information. The /etc/machine-info entries enable embedded
devices without UEFI support to provide the information via a common
interface.

Fixes: #31134
5 months agocore: lowercase Context/Runtime 37582/head
Ivan Kruglov [Fri, 23 May 2025 13:32:47 +0000 (06:32 -0700)] 
core: lowercase Context/Runtime

Varlink fields are camelCase unless well defined config names.

5 months agocore: manager-varlink.{c,h} -> varlink-manager.{c,h}
Ivan Kruglov [Wed, 14 May 2025 09:45:15 +0000 (02:45 -0700)] 
core: manager-varlink.{c,h} -> varlink-manager.{c,h}

5 months agohwdb: add Ettus Research SDR devices
AsciiWolf [Thu, 22 May 2025 11:04:07 +0000 (13:04 +0200)] 
hwdb: add Ettus Research SDR devices

5 months agoboot: do not stop parsing profiles if .cmdline is missing
Luca Boccassi [Thu, 22 May 2025 21:38:11 +0000 (22:38 +0100)] 
boot: do not stop parsing profiles if .cmdline is missing

When profiles were added with a new interation this was left as
a return statement instead of a continue

Follow-up for 382e4da4a5b25ad0c225b4a8092ed24a44c84e18

5 months agopath-util: invert PATH_STARTSWITH_ACCEPT_DOT_DOT flag 37572/head
Lennart Poettering [Fri, 23 May 2025 04:45:40 +0000 (06:45 +0200)] 
path-util: invert PATH_STARTSWITH_ACCEPT_DOT_DOT flag

As requested: https://github.com/systemd/systemd/pull/37572#pullrequestreview-2861928094

5 months agocgroup: port some code over to path_startswith_full()
Lennart Poettering [Thu, 22 May 2025 16:35:25 +0000 (18:35 +0200)] 
cgroup: port some code over to path_startswith_full()

5 months agopath-util: add flavour of path_startswith() that leaves a leading slash in place
Lennart Poettering [Mon, 19 May 2025 10:58:52 +0000 (12:58 +0200)] 
path-util: add flavour of path_startswith() that leaves a leading slash in place

5 months agotests: fix TEST-74-AUX-UTILS.varlinkctl.sh (#37562)
Ivan Kruglov [Thu, 22 May 2025 14:05:10 +0000 (07:05 -0700)] 
tests: fix TEST-74-AUX-UTILS.varlinkctl.sh (#37562)

per Daan's explanation:
other subtests running as testuser apparently use systemd-run --user
--machine testuser@.host which turns user tracking in logind into "by
pin" mode. when the last pinning session exits it terminates the user.

5 months agoMore header cleanups (#37571)
Daan De Meyer [Thu, 22 May 2025 19:49:14 +0000 (21:49 +0200)] 
More header cleanups (#37571)

Split out of #37344

5 months agotree-wide: Clean up includes 37571/head
Daan De Meyer [Thu, 22 May 2025 11:40:43 +0000 (13:40 +0200)] 
tree-wide: Clean up includes

Preparation for cleaning up includes in src/shared.

5 months agomeson: Make sure <sys/socket.h> is included in af-from-name.gperf
Daan De Meyer [Thu, 22 May 2025 14:07:33 +0000 (16:07 +0200)] 
meson: Make sure <sys/socket.h> is included in af-from-name.gperf

5 months agobasic: Add missing process-util.h include to origin-id.h
Daan De Meyer [Thu, 22 May 2025 13:27:50 +0000 (15:27 +0200)] 
basic: Add missing process-util.h include to origin-id.h

5 months agologind: fix serialization of display user field
Lennart Poettering [Thu, 22 May 2025 16:04:34 +0000 (18:04 +0200)] 
logind: fix serialization of display user field

Follow-up for: 232f4e12fe526bfbcd5c7bd857bbb6a0db818cbc

5 months agoforward: Add more forward declarations
Daan De Meyer [Thu, 22 May 2025 10:08:31 +0000 (12:08 +0200)] 
forward: Add more forward declarations

CGroupMask was erronously added to core-forward.h even though it
comes from src/basic so we move it to the right location.

5 months agoRestore compatibility for coredump --backtrace (#37559)
Zbigniew Jędrzejewski-Szmek [Thu, 22 May 2025 11:40:29 +0000 (13:40 +0200)] 
Restore compatibility for coredump --backtrace (#37559)

5 months agoClang tidy headers (#37566)
Daan De Meyer [Thu, 22 May 2025 10:01:57 +0000 (12:01 +0200)] 
Clang tidy headers (#37566)

5 months agomeson: Run clang-tidy on libsystemd headers as well 37566/head
Daan De Meyer [Thu, 22 May 2025 09:06:54 +0000 (11:06 +0200)] 
meson: Run clang-tidy on libsystemd headers as well

5 months agomeson: Use .inc for generated code meant to be included in other files
Daan De Meyer [Thu, 22 May 2025 08:32:32 +0000 (10:32 +0200)] 
meson: Use .inc for generated code meant to be included in other files

These files use the .h extension but are not standalone so let's not
make it appear like they are proper headers and instead use the .inc
extension.

5 months agoboot: Clean up includes
Daan De Meyer [Thu, 22 May 2025 08:00:39 +0000 (10:00 +0200)] 
boot: Clean up includes

Instead of introducing efi-forward.h, we use efi.h for the same purpose
in the boot/ folder.

5 months agoRevert "logind: always enclose list fields (that may contain spaces) in quotes"
Luca Boccassi [Wed, 21 May 2025 23:56:18 +0000 (00:56 +0100)] 
Revert "logind: always enclose list fields (that may contain spaces) in quotes"

This breaks GNOME on Wayland, login no longer works:

gnome-shell[2250]: Running GNOME Shell (using mutter 48.2) as a Wayland display server
gnome-shell[2250]: Failed to setup: Failed to find any matching session
systemd[2054]: org.gnome.Shell@wayland.service: Failed with result 'protocol'.
systemd[2054]: Failed to start org.gnome.Shell@wayland.service - GNOME Shell on Wayland.

This reverts commit b0555149de780f81ec6f741d36bdb41b4d1d8a94.

5 months agoVarious cleanups (#37564)
Daan De Meyer [Thu, 22 May 2025 08:40:35 +0000 (10:40 +0200)] 
Various cleanups (#37564)

5 months agocore: Clean up includes 37564/head
Daan De Meyer [Thu, 22 May 2025 07:40:31 +0000 (09:40 +0200)] 
core: Clean up includes

Follow up for 836e4e7ea8fa24a0a08a3579f154ed4f4987c5df

5 months agotest: Remove unused includes
Daan De Meyer [Thu, 22 May 2025 07:22:07 +0000 (09:22 +0200)] 
test: Remove unused includes

5 months agomachine: Fix comment
Daan De Meyer [Thu, 22 May 2025 07:21:59 +0000 (09:21 +0200)] 
machine: Fix comment

5 months agocore: Clean up includes
Daan De Meyer [Wed, 21 May 2025 14:37:12 +0000 (16:37 +0200)] 
core: Clean up includes

Split out of #37344.

5 months agonetworkd: print a meaningful error on failure
Matteo Croce [Thu, 22 May 2025 03:41:49 +0000 (05:41 +0200)] 
networkd: print a meaningful error on failure

test_keep_configuration_on_restart() works, but the error printed is
misleading because self.assertNotEmpty() doesn't exist.

Add a working assert statement so, when the unmanaged interface is
altered, the test fails with a meaningful error, like:

        ### ip monitor dev unmanaged0 BEGIN
        222:33::/64 proto kernel metric 256 pref medium
        FAIL
        [...]
        Traceback (most recent call last):
          File "/work/src/test/test-network/systemd-networkd-tests.py", line 5085, in test_keep_configuration_on_restart
            self.assertEqual(line, '')
        AssertionError: '222:33::/64 proto kernel metric 256 pref medium' != ''
        - 222:33::/64 proto kernel metric 256 pref medium

While at it, strip the trailing newline so we can print easily the
string (and in future build more a robust regexp which uses the $ token)

5 months agohostname: add hardware version 36956/head
Stefan Herbrechtsmeier [Wed, 30 Apr 2025 07:55:21 +0000 (09:55 +0200)] 
hostname: add hardware version

Add support for the hardware version. The version describes a distinct
version of compatibility hardware. The value is read from the file
/etc/machine-info or DMI as fallback.

The integration provides an unified interface to collect detail hardware
information. The /etc/machine-info entry enables embedded devices
without UEFI support to read the information from a custom store.

5 months agohostname: add hardware Stock-Keeping Unit
Stefan Herbrechtsmeier [Wed, 30 Apr 2025 07:31:42 +0000 (09:31 +0200)] 
hostname: add hardware Stock-Keeping Unit

Add support for the hardware Stock-Keeping Unit (SKU). The SKU describes
a distinct type of hardware for sale, purchase or inventory management.
The value is read from the file /etc/machine-info or DMI as fallback.

The integration provides an unified interface to collect detail hardware
information. The /etc/machine-info entry enables embedded devices
without UEFI support to read the information from a custom store.

5 months agoSeveral minor follow-ups for #33995 (#37558)
Mike Yuan [Wed, 21 May 2025 22:22:00 +0000 (00:22 +0200)] 
Several minor follow-ups for #33995 (#37558)

5 months agocoredump: wrap long lines, fix grammar in comments 37559/head
Zbigniew Jędrzejewski-Szmek [Wed, 21 May 2025 20:33:50 +0000 (22:33 +0200)] 
coredump: wrap long lines, fix grammar in comments

5 months agocoredump: restore compatibility with older patterns
Zbigniew Jędrzejewski-Szmek [Tue, 29 Apr 2025 12:47:59 +0000 (14:47 +0200)] 
coredump: restore compatibility with older patterns

This was broken in f45b8015513d38ee5f7cc361db9c5b88c9aae704. Unfortunately
the review does not talk about backward compatibility at all. There are
two places where it matters:
- During upgrades, the replacement of kernel.core_pattern is asynchronous.
  For example, during rpm upgrades, it would be updated a post-transaction
  file trigger. In other scenarios, the update might only happen after
  reboot. We have a potentially long window where the old pattern is in
  place. We need to capture coredumps during upgrades too.
- With --backtrace. The interface of --backtrace, in hindsight, is not
  great. But there are users of --backtrace which were written to use
  a specific set of arguments, and we can't just break compatiblity.
  One example is systemd-coredump-python, but there are also reports of
  users using --backtrace to generate coredump logs.

Thus, we require the original set of args, and will use the additional args if
found.

A test is added to verify that --backtrace works with and without the optional
args.

5 months agounit-def: reindent comments 37558/head
Yu Watanabe [Wed, 21 May 2025 20:12:13 +0000 (05:12 +0900)] 
unit-def: reindent comments

Prompted by dfdeb0b1cbb05a213f0965eedfe0e7ef06cd39d3.

5 months agotest-vpick: use more strict check
Yu Watanabe [Wed, 21 May 2025 20:10:57 +0000 (05:10 +0900)] 
test-vpick: use more strict check

Follow-up for 4fc99407601a235f9d1107f79363bb3f2d6ab5c0.

5 months agologind: Add missing include
Daan De Meyer [Wed, 21 May 2025 19:14:25 +0000 (21:14 +0200)] 
logind: Add missing include

Follow up for 1aa202dd243c815efa5c2017fef996e66546a0ba

5 months agologind: state serialization fixes (#37555)
Yu Watanabe [Wed, 21 May 2025 18:54:40 +0000 (03:54 +0900)] 
logind: state serialization fixes (#37555)

Turns out our escaping was really broken when saving/restoring
session/seat/user state. Let's fix that.

5 months agoanalyze: Clean up includes
Daan De Meyer [Wed, 21 May 2025 15:06:27 +0000 (17:06 +0200)] 
analyze: Clean up includes

Split out of #37344.

5 months agonetworkd: ensure that unmanaged interfaces aren't touched
Matteo Croce [Mon, 19 May 2025 21:35:23 +0000 (23:35 +0200)] 
networkd: ensure that unmanaged interfaces aren't touched

Extend the test_keep_configuration_on_restart in order to check
that the unmanaged interface isn't altered in any way.

5 months agoenv-file: rework write_env_file() to make use of O_TMPFILE
Lennart Poettering [Fri, 16 May 2025 11:08:56 +0000 (13:08 +0200)] 
env-file: rework write_env_file() to make use of O_TMPFILE

5 months agologind: rename EnableWallMessages= configuration knob to WallMessages= (#37553)
Lennart Poettering [Wed, 21 May 2025 17:47:57 +0000 (19:47 +0200)] 
logind: rename EnableWallMessages= configuration knob to WallMessages= (#37553)

We generally frown on config options that are called
EnableXYZ=/DisableXYZ=, hence drop this here too. Note that the original
sin was that the pre-existing D-Bus property already used the prefix.
But given that D-Bus properties are substantially more low-level (i.e.
developer focused) than the config knobs, let's bite the bullet and
name the configuration option cleanly, even if the dbus property carries
the damn prefix.

The knob was added post v257, hence this is not a compat break.

Follow-up for: 130698dc20df9438c3f5b79ddf2c1a1b16c3f8fc

5 months agomachined: call pidref_verify() in some cases this was missing
Lennart Poettering [Wed, 21 May 2025 07:20:44 +0000 (09:20 +0200)] 
machined: call pidref_verify() in some cases this was missing

We need to protect us from recycled PIDs here like everywhere else: once
we read data from /proc/$PID/ we need to validate that $PID still points
to the original pidfd.

5 months agocore: Make various ActivationDetails functions take a const argument
Daan De Meyer [Wed, 21 May 2025 13:44:05 +0000 (15:44 +0200)] 
core: Make various ActivationDetails functions take a const argument

5 months agonetwork: Clean up includes
Daan De Meyer [Wed, 21 May 2025 12:16:46 +0000 (14:16 +0200)] 
network: Clean up includes

Split out of #37344.

5 months agobootctl: Clean up includes
Daan De Meyer [Wed, 21 May 2025 14:35:00 +0000 (16:35 +0200)] 
bootctl: Clean up includes

Split out of #37344.

5 months agocryptenroll: Clean up includes
Daan De Meyer [Wed, 21 May 2025 14:34:29 +0000 (16:34 +0200)] 
cryptenroll: Clean up includes

Split out of #37344.

5 months agocryptsetup: Clean up includes
Daan De Meyer [Wed, 21 May 2025 14:34:14 +0000 (16:34 +0200)] 
cryptsetup: Clean up includes

Split out of #37344.

5 months agoREADME: update badges
Yu Watanabe [Wed, 21 May 2025 16:37:05 +0000 (01:37 +0900)] 
README: update badges