]> git.ipfire.org Git - thirdparty/collectd.git/log
thirdparty/collectd.git
17 months agowrite_prometheus plugin: Fix a deadlock due to a leaked mutex. 4285/head
Florian Forster [Mon, 19 Feb 2024 22:30:49 +0000 (23:30 +0100)] 
write_prometheus plugin: Fix a deadlock due to a leaked mutex.

17 months agoMerge pull request #4278 from octo/6/swap
Florian Forster [Mon, 12 Feb 2024 22:03:05 +0000 (23:03 +0100)] 
Merge pull request #4278 from octo/6/swap

[collectd 6] swap plugin: Add the `system.paging.faults` metric.

17 months agoMerge pull request #4275 from octo/6/memory
Florian Forster [Mon, 12 Feb 2024 22:01:23 +0000 (23:01 +0100)] 
Merge pull request #4275 from octo/6/memory

[collectd 6] memory plugin: Report the `system.linux.memory.available` metric.

18 months agoswap plugin: Add the `system.paging.faults` metric. 4278/head
Florian Forster [Wed, 7 Feb 2024 21:21:30 +0000 (22:21 +0100)] 
swap plugin: Add the `system.paging.faults` metric.

18 months agomemory plugin: Report the `system.linux.memory.available` metric. 4275/head
Florian Forster [Wed, 7 Feb 2024 16:19:18 +0000 (17:19 +0100)] 
memory plugin: Report the `system.linux.memory.available` metric.

18 months agoUpdate ChangeLog for version 6.0.0.rc2. collectd-6.0.0.rc2
Florian Forster [Wed, 7 Feb 2024 08:54:47 +0000 (09:54 +0100)] 
Update ChangeLog for version 6.0.0.rc2.

18 months agoAdd GitHub Action to automatically build and upload release assets.
Florian Forster [Wed, 7 Feb 2024 08:21:19 +0000 (09:21 +0100)] 
Add GitHub Action to automatically build and upload release assets.

18 months agoMerge pull request #4274 from octo/6/cirrus_macos
Florian Forster [Wed, 7 Feb 2024 07:47:08 +0000 (08:47 +0100)] 
Merge pull request #4274 from octo/6/cirrus_macos

.cirrus.yml: Add task for Mac OS X, cleanup and improvements.

18 months agoversion-gen.sh: Add the `--tags` flag to `git describe`.
Florian Forster [Tue, 6 Feb 2024 21:25:20 +0000 (22:25 +0100)] 
version-gen.sh: Add the `--tags` flag to `git describe`.

18 months ago.cirrus.yml: Use proper capitalization for MacOS and FreeBSD. 4274/head
Florian Forster [Tue, 6 Feb 2024 21:05:06 +0000 (22:05 +0100)] 
.cirrus.yml: Use proper capitalization for MacOS and FreeBSD.

18 months ago.cirrus.yml: Remove "or cat log" in favor of uploading logs as artifacts.
Florian Forster [Tue, 6 Feb 2024 20:58:57 +0000 (21:58 +0100)] 
.cirrus.yml: Remove "or cat log" in favor of uploading logs as artifacts.

18 months ago.cirrus.yml: Remove "clang" task.
Florian Forster [Tue, 6 Feb 2024 20:49:17 +0000 (21:49 +0100)] 
.cirrus.yml: Remove "clang" task.

It duplicates a GitHub Action based build.

18 months agocirrus.yml: Remove the "default toolchain" tasks.
Florian Forster [Tue, 6 Feb 2024 20:36:23 +0000 (21:36 +0100)] 
cirrus.yml: Remove the "default toolchain" tasks.

The default toolchains are already covered well by GitHub Actions.

18 months ago.cirrus.yml: Run `distcheck` with default configure flags.
Florian Forster [Tue, 6 Feb 2024 15:57:37 +0000 (16:57 +0100)] 
.cirrus.yml: Run `distcheck` with default configure flags.

18 months ago.cirrus.yml: Build with `-gdwarf-4` when using clang.
Florian Forster [Tue, 6 Feb 2024 15:55:40 +0000 (16:55 +0100)] 
.cirrus.yml: Build with `-gdwarf-4` when using clang.

18 months ago.cirrus.yml: FreeBSD: install "git".
Florian Forster [Tue, 6 Feb 2024 15:16:47 +0000 (16:16 +0100)] 
.cirrus.yml: FreeBSD: install "git".

18 months ago.cirrus.yml: Mac OS X: Pass `DEFAULT_CONFIG_OPTS` to configure.
Florian Forster [Tue, 6 Feb 2024 15:11:19 +0000 (16:11 +0100)] 
.cirrus.yml: Mac OS X: Pass `DEFAULT_CONFIG_OPTS` to configure.

18 months ago.cirrus.yml: Disable `CIRRUS_CLONE_SUBMODULES` and run `git submodule` "manually".
Florian Forster [Tue, 6 Feb 2024 15:01:50 +0000 (16:01 +0100)] 
.cirrus.yml: Disable `CIRRUS_CLONE_SUBMODULES` and run `git submodule` "manually".

18 months ago.cirrus.yml: Use `${CIRRUS_CPU}` on Mac OS.
Florian Forster [Tue, 6 Feb 2024 14:54:44 +0000 (15:54 +0100)] 
.cirrus.yml: Use `${CIRRUS_CPU}` on Mac OS.

`nproc` is not available.

18 months ago.cirrus.yml: Add macos_task for Mac OS X.
Florian Forster [Tue, 6 Feb 2024 14:39:57 +0000 (15:39 +0100)] 
.cirrus.yml: Add macos_task for Mac OS X.

18 months agoMerge pull request #4272 from octo/6/time_metrics
Florian Forster [Tue, 6 Feb 2024 08:03:56 +0000 (09:03 +0100)] 
Merge pull request #4272 from octo/6/time_metrics

[collectd 6] Scale time metrics to seconds per second using floating point counters.

18 months agoMerge pull request #4259 from octo/6/cirrusci
Florian Forster [Sat, 3 Feb 2024 21:48:58 +0000 (22:48 +0100)] 
Merge pull request #4259 from octo/6/cirrusci

[collectd 6] ci: .cirrus.yml: Upload `.log` files as artifacts.

18 months agodisk plugin: Report time metrics in seconds. 4272/head
Florian Forster [Sat, 3 Feb 2024 20:45:15 +0000 (21:45 +0100)] 
disk plugin: Report time metrics in seconds.

18 months agocpu plugin: Report `system.cpu.time` in seconds, using floating point counters.
Florian Forster [Sat, 3 Feb 2024 20:08:58 +0000 (21:08 +0100)] 
cpu plugin: Report `system.cpu.time` in seconds, using floating point counters.

18 months agocommon: Add support for floating point counters …
Florian Forster [Sat, 3 Feb 2024 19:52:39 +0000 (20:52 +0100)] 
common: Add support for floating point counters …

… to `rate_to_value()` and `value_to_rate()`.

18 months agoMerge pull request #4266 from octo/6/fpcounter
Florian Forster [Fri, 2 Feb 2024 16:02:50 +0000 (17:02 +0100)] 
Merge pull request #4266 from octo/6/fpcounter

[collectd 6] Introduce a floating point counter type.

18 months agoAuto-Merge pull request #4270 from octo/6/format_stackdriver
collectd bot [Fri, 2 Feb 2024 15:12:41 +0000 (16:12 +0100)] 
Auto-Merge pull request #4270 from octo/6/format_stackdriver

Automatically merged due to "Automerge" label

18 months agoformat_stackdriver: Add proper error handling to `sd_output_reset()`. 4270/head
Florian Forster [Fri, 2 Feb 2024 09:52:21 +0000 (10:52 +0100)] 
format_stackdriver: Add proper error handling to `sd_output_reset()`.

18 months agoformat_stackdriver: Remove `int` cast from `yajl_gen_double()`. 4266/head
Florian Forster [Fri, 2 Feb 2024 07:42:17 +0000 (08:42 +0100)] 
format_stackdriver: Remove `int` cast from `yajl_gen_double()`.

18 months agoAuto-Merge pull request #4268 from octo/6/format_stackdriver
collectd bot [Thu, 1 Feb 2024 16:35:35 +0000 (17:35 +0100)] 
Auto-Merge pull request #4268 from octo/6/format_stackdriver

Automatically merged due to "Automerge" label

18 months agoformat_stackdriver: When JSON generation fails, reset the generator because it is... 4268/head
Florian Forster [Thu, 1 Feb 2024 15:53:44 +0000 (16:53 +0100)] 
format_stackdriver: When JSON generation fails, reset the generator because it is in an unknown state.

18 months agosrc/utils/value_list/value_list.h: Drop outdated comment.
Florian Forster [Thu, 1 Feb 2024 15:33:14 +0000 (16:33 +0100)] 
src/utils/value_list/value_list.h: Drop outdated comment.

18 months agoformat_open_telemetry: Move the "never reached" comment to `add_metric()`.
Florian Forster [Thu, 1 Feb 2024 15:26:14 +0000 (16:26 +0100)] 
format_open_telemetry: Move the "never reached" comment to `add_metric()`.

18 months agosrc/daemon/utils_cache.c: Avoid `default` in the `family->type` switch statement.
Florian Forster [Thu, 1 Feb 2024 15:19:27 +0000 (16:19 +0100)] 
src/daemon/utils_cache.c: Avoid `default` in the `family->type` switch statement.

This way the compiler can check that we handle all values in the
`metric_type_t` enum.

18 months agosrc/daemon/metric.h: Add an `IS_CUMULATIVE` macro.
Florian Forster [Wed, 31 Jan 2024 14:03:24 +0000 (15:03 +0100)] 
src/daemon/metric.h: Add an `IS_CUMULATIVE` macro.

18 months agoformat_kairosdb: Log an error when `uc_get_rate()` fails.
Florian Forster [Wed, 31 Jan 2024 13:51:19 +0000 (14:51 +0100)] 
format_kairosdb: Log an error when `uc_get_rate()` fails.

18 months agoformat_json: Don't access `(value_t).gauge` when the type is `FPCOUNTER`.
Florian Forster [Wed, 31 Jan 2024 13:49:20 +0000 (14:49 +0100)] 
format_json: Don't access `(value_t).gauge` when the type is `FPCOUNTER`.

18 months agosrc/daemon/metric.h: Order metric types by value.
Florian Forster [Wed, 31 Jan 2024 12:58:51 +0000 (13:58 +0100)] 
src/daemon/metric.h: Order metric types by value.

18 months agovalue_list: Move `DS_TYPE_TO_STRING` out of `src/daemon/plugin.h`.
Florian Forster [Wed, 31 Jan 2024 12:57:20 +0000 (13:57 +0100)] 
value_list: Move `DS_TYPE_TO_STRING` out of `src/daemon/plugin.h`.

18 months agoformat_{graphite,influxdb,kairosdb,stackdriver}: Fix compiler warning.
Florian Forster [Wed, 31 Jan 2024 09:42:16 +0000 (10:42 +0100)] 
format_{graphite,influxdb,kairosdb,stackdriver}: Fix compiler warning.

Some compilers don't like empty statements, e.g.:

```
src/utils/format_kairosdb/format_kairosdb.c:122:8: error: label at end of compound statement
  122 |   case METRIC_TYPE_UNTYPED:
      |        ^~~~~~~~~~~~~~~~~~~
```

18 months agowrite_prometheus plugin: Add support for `METRIC_TYPE_FPCOUNTER`.
Florian Forster [Wed, 31 Jan 2024 07:46:29 +0000 (08:46 +0100)] 
write_prometheus plugin: Add support for `METRIC_TYPE_FPCOUNTER`.

18 months agoformat_stackdriver: Add support for `METRIC_TYPE_FPCOUNTER`.
Florian Forster [Wed, 31 Jan 2024 07:46:29 +0000 (08:46 +0100)] 
format_stackdriver: Add support for `METRIC_TYPE_FPCOUNTER`.

18 months agoformat_open_telemetry: Add support for `METRIC_TYPE_FPCOUNTER`.
Florian Forster [Wed, 31 Jan 2024 07:46:29 +0000 (08:46 +0100)] 
format_open_telemetry: Add support for `METRIC_TYPE_FPCOUNTER`.

18 months agoformat_kairosdb: Add support for `METRIC_TYPE_FPCOUNTER`.
Florian Forster [Wed, 31 Jan 2024 07:46:29 +0000 (08:46 +0100)] 
format_kairosdb: Add support for `METRIC_TYPE_FPCOUNTER`.

18 months agoformat_json: Add support for `METRIC_TYPE_FPCOUNTER`.
Florian Forster [Wed, 31 Jan 2024 07:46:29 +0000 (08:46 +0100)] 
format_json: Add support for `METRIC_TYPE_FPCOUNTER`.

18 months agoformat_influxdb: Add support for `METRIC_TYPE_FPCOUNTER`.
Florian Forster [Wed, 31 Jan 2024 07:46:29 +0000 (08:46 +0100)] 
format_influxdb: Add support for `METRIC_TYPE_FPCOUNTER`.

18 months agoformat_graphite: Add support for `METRIC_TYPE_FPCOUNTER`.
Florian Forster [Wed, 31 Jan 2024 07:46:29 +0000 (08:46 +0100)] 
format_graphite: Add support for `METRIC_TYPE_FPCOUNTER`.

18 months agocmds: Add support for `METRIC_TYPE_FPCOUNTER`.
Florian Forster [Wed, 31 Jan 2024 07:46:29 +0000 (08:46 +0100)] 
cmds: Add support for `METRIC_TYPE_FPCOUNTER`.

18 months agocommon: Add support for `METRIC_TYPE_FPCOUNTER`.
Florian Forster [Wed, 31 Jan 2024 07:46:29 +0000 (08:46 +0100)] 
common: Add support for `METRIC_TYPE_FPCOUNTER`.

18 months agoDaemon: Add a new metric type for floating point counters.
Florian Forster [Wed, 31 Jan 2024 07:42:16 +0000 (08:42 +0100)] 
Daemon: Add a new metric type for floating point counters.

18 months agoMerge pull request #4265 from octo/6/cache
Florian Forster [Wed, 31 Jan 2024 13:38:01 +0000 (14:38 +0100)] 
Merge pull request #4265 from octo/6/cache

[collectd 6] cache: Provide the first metric value available alongside the first metric time.

18 months agosrc/daemon/utils_cache_test.c: Add a test case for decreasing gauges. 4265/head
Florian Forster [Wed, 31 Jan 2024 12:53:14 +0000 (13:53 +0100)] 
src/daemon/utils_cache_test.c: Add a test case for decreasing gauges.

18 months agoformat_stackdriver: Add missing `break` statements.
Florian Forster [Wed, 31 Jan 2024 12:47:34 +0000 (13:47 +0100)] 
format_stackdriver: Add missing `break` statements.

18 months agoformat_stackdriver: Consistently handle `METRIC_TYPE_UNTYPED` as an error.
Florian Forster [Wed, 31 Jan 2024 12:46:28 +0000 (13:46 +0100)] 
format_stackdriver: Consistently handle `METRIC_TYPE_UNTYPED` as an error.

18 months agosrc/daemon/utils_cache.h: Unify comment style.
Florian Forster [Wed, 31 Jan 2024 12:45:58 +0000 (13:45 +0100)] 
src/daemon/utils_cache.h: Unify comment style.

18 months agoformat_stackdriver: Use the new `uc_first_metric()` function.
Florian Forster [Wed, 31 Jan 2024 07:37:49 +0000 (08:37 +0100)] 
format_stackdriver: Use the new `uc_first_metric()` function.

18 months agosrc/daemon/utils_cache.c: Let `uc_get_rate()` return early when called with a gauge...
Florian Forster [Wed, 31 Jan 2024 07:32:20 +0000 (08:32 +0100)] 
src/daemon/utils_cache.c: Let `uc_get_rate()` return early when called with a gauge metric.

18 months agosrc/daemon/utils_cache.c: Add documentation for `uc_get_rate()`.
Florian Forster [Wed, 31 Jan 2024 07:18:46 +0000 (08:18 +0100)] 
src/daemon/utils_cache.c: Add documentation for `uc_get_rate()`.

This also improved the return values to give more information about which error condition occurred.

18 months agosrc/daemon/utils_cache.c: Change `uc_first_metric()` to return time and value.
Florian Forster [Wed, 31 Jan 2024 06:47:19 +0000 (07:47 +0100)] 
src/daemon/utils_cache.c: Change `uc_first_metric()` to return time and value.

Returning both in one call ensures these values are consistent, i.e. it avoids
the case that there might have been an update inbewtween reading time and
value.

18 months agosrc/daemon/utils_cache.c: Automatically initialize the cache when needed.
Florian Forster [Tue, 30 Jan 2024 12:22:52 +0000 (13:22 +0100)] 
src/daemon/utils_cache.c: Automatically initialize the cache when needed.

This simplifies writing unit tests using the cache.

18 months agochore: Add unit test for `uc_get_rate`.
Florian Forster [Tue, 30 Jan 2024 12:18:40 +0000 (13:18 +0100)] 
chore: Add unit test for `uc_get_rate`.

18 months agoMerge pull request #4264 from eero-t/gcc-extra
Florian Forster [Wed, 31 Jan 2024 09:47:16 +0000 (10:47 +0100)] 
Merge pull request #4264 from eero-t/gcc-extra

[collectd 6, WIP] Fix more GCC "-Wextra" warnings in collectd core

18 months agoMerge pull request #4262 from eero-t/gcc-pedantic-func
Florian Forster [Wed, 31 Jan 2024 08:26:08 +0000 (09:26 +0100)] 
Merge pull request #4262 from eero-t/gcc-pedantic-func

[collectd 6, WIP] Fix more GCC "-Wpedantic" warnings

18 months agomessage_parser.c: fix -Wextra warnings 4264/head
Eero Tamminen [Tue, 30 Jan 2024 16:59:46 +0000 (18:59 +0200)] 
message_parser.c: fix -Wextra warnings

And arg name in comment for the function calling message parser
callback.

Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
18 months agoproc_pids.c: fix signed vs. unsigned comparison warnings
Eero Tamminen [Tue, 30 Jan 2024 15:51:51 +0000 (17:51 +0200)] 
proc_pids.c: fix signed vs. unsigned comparison warnings

Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
18 months agoformat_stackdriver.c: use counter_t instead of casts
Eero Tamminen [Tue, 30 Jan 2024 15:50:29 +0000 (17:50 +0200)] 
format_stackdriver.c: use counter_t instead of casts

All current uses are for counter_t comparisons, so let's just use that
type.  Gets rid of signed vs unsigned comparison warning.

Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
18 months agomdevents.c: fix -Wpedantic warnings on array initialization 4262/head
Eero Tamminen [Tue, 30 Jan 2024 11:07:11 +0000 (13:07 +0200)] 
mdevents.c: fix -Wpedantic warnings on array initialization

"{}" initializers are C23 feature, not C99 one:
https://en.cppreference.com/w/c/language/array_initialization

In first 2 cases initialization was redundant as "regerror()" and
"regexec()" fill the given arrays. Event initialization needed to be
fixed as last struct item writing is conditional.

Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
18 months agorest of plugins: __FUNCTION__ -> __func__ (C99)
Eero Tamminen [Tue, 30 Jan 2024 10:42:42 +0000 (12:42 +0200)] 
rest of plugins: __FUNCTION__ -> __func__ (C99)

Fixes -Wpendantic warnings in rest of plugins.

Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
18 months agodpdk*.c: __FUNCTION__ -> __func__ (C99)
Eero Tamminen [Tue, 30 Jan 2024 10:38:38 +0000 (12:38 +0200)] 
dpdk*.c: __FUNCTION__ -> __func__ (C99)

Same -Wpendantic warnings fixes for plugin code.

Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
18 months agoutils/dpdk/dpdk.*: __FUNCTION__ -> __func__ (C99)
Eero Tamminen [Tue, 30 Jan 2024 10:28:04 +0000 (12:28 +0200)] 
utils/dpdk/dpdk.*: __FUNCTION__ -> __func__ (C99)

Fixes -Wpendantic warnings, __func__ supported since GCC 2.95.

Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
18 months agoutils/ovs/ovs.c: __FUNCTION__ -> __func__ (C99)
Eero Tamminen [Fri, 19 Jan 2024 10:42:42 +0000 (12:42 +0200)] 
utils/ovs/ovs.c: __FUNCTION__ -> __func__ (C99)

Fixes -Wpedantic warnings.

Collectd requires C99 support, and __func__ is supported since GCC 2.95 / C99.

Btw. For C++ code, the issue would be murkier. C++11 added __func__
support, but one cannot check just C++ version because MSVC reported
older spec until recently:
- https://devblogs.microsoft.com/cppblog/msvc-now-correctly-reports-__cplusplus/

More info on latter:
- https://stackoverflow.com/questions/7008485/func-or-function-or-manual-const-char-id
- https://learn.microsoft.com/en-us/cpp/cpp/func?view=msvc-170 +

Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
18 months agoutils/cmds/cmds_test.c: fix -Wpendantic/-Wformat warning
Eero Tamminen [Tue, 30 Jan 2024 10:19:29 +0000 (12:19 +0200)] 
utils/cmds/cmds_test.c: fix -Wpendantic/-Wformat warning

Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
18 months agoMerge pull request #4261 from eero-t/gcc-extra
Eero Tamminen [Tue, 30 Jan 2024 10:06:16 +0000 (12:06 +0200)] 
Merge pull request #4261 from eero-t/gcc-extra

[collectd 6]: Fix some GCC "-Wextra" warnings in collectd core

18 months agoutils/metadata/meta_data.c: fix -Wnull-dereference warning 4261/head
Eero Tamminen [Thu, 28 Dec 2023 18:02:07 +0000 (20:02 +0200)] 
utils/metadata/meta_data.c: fix -Wnull-dereference warning

Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
18 months agoplugin.c: use union as generic callback type
Eero Tamminen [Mon, 29 Jan 2024 14:44:09 +0000 (16:44 +0200)] 
plugin.c: use union as generic callback type

Fix for -Wcast-function-type (part of -Wextra).

Fixes: d9d5025a0645
Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
18 months agoutils_cache.c: fix obsolete comment
Eero Tamminen [Mon, 29 Jan 2024 16:44:44 +0000 (18:44 +0200)] 
utils_cache.c: fix obsolete comment

Fixes: 95a54dd0f69c04
Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
18 months agoMerge pull request #4258 from octo/6/write_redis
Florian Forster [Mon, 29 Jan 2024 16:05:03 +0000 (17:05 +0100)] 
Merge pull request #4258 from octo/6/write_redis

[collectd 6] feat: Port the write_redis plugin to collectd 6.

18 months ago.cirrus.yml: Rename `checks_script` to `make_distcheck_script`. 4259/head
Florian Forster [Mon, 29 Jan 2024 13:17:40 +0000 (14:17 +0100)] 
.cirrus.yml: Rename `checks_script` to `make_distcheck_script`.

18 months agosrc/daemon/utils_cache.c: Add comment about initializing `ce->values_gauge` for non... 4258/head
Florian Forster [Mon, 29 Jan 2024 13:15:24 +0000 (14:15 +0100)] 
src/daemon/utils_cache.c: Add comment about initializing `ce->values_gauge` for non-gauge types.

18 months agoMerge pull request #4257 from octo/6/dispatch_metric_family
Florian Forster [Mon, 29 Jan 2024 10:17:39 +0000 (11:17 +0100)] 
Merge pull request #4257 from octo/6/dispatch_metric_family

[collectd 6] fix: Handle metric families with zero metrics gracefully.

18 months agosrc/daemon/plugin.c: Log a debug message when a metric family has no metrics. 4257/head
Florian Forster [Fri, 26 Jan 2024 13:37:56 +0000 (14:37 +0100)] 
src/daemon/plugin.c: Log a debug message when a metric family has no metrics.

18 months agoping plugin: Call `plugin_dispatch_metric_family` unconditionally.
Florian Forster [Fri, 26 Jan 2024 12:20:24 +0000 (13:20 +0100)] 
ping plugin: Call `plugin_dispatch_metric_family` unconditionally.

18 months agoirq plugin: Call `plugin_dispatch_metric_family` unconditionally.
Florian Forster [Fri, 26 Jan 2024 12:20:24 +0000 (13:20 +0100)] 
irq plugin: Call `plugin_dispatch_metric_family` unconditionally.

18 months agoipc plugin: Call `plugin_dispatch_metric_family` unconditionally.
Florian Forster [Fri, 26 Jan 2024 12:20:24 +0000 (13:20 +0100)] 
ipc plugin: Call `plugin_dispatch_metric_family` unconditionally.

18 months agodisk plugin: Call `plugin_dispatch_metric_family` unconditionally.
Florian Forster [Fri, 26 Jan 2024 12:20:24 +0000 (13:20 +0100)] 
disk plugin: Call `plugin_dispatch_metric_family` unconditionally.

18 months agodf plugin: Call `plugin_dispatch_metric_family` unconditionally.
Florian Forster [Fri, 26 Jan 2024 12:20:24 +0000 (13:20 +0100)] 
df plugin: Call `plugin_dispatch_metric_family` unconditionally.

18 months agochrony plugin: Call `plugin_dispatch_metric_family` unconditionally.
Florian Forster [Fri, 26 Jan 2024 12:20:24 +0000 (13:20 +0100)] 
chrony plugin: Call `plugin_dispatch_metric_family` unconditionally.

18 months agofix: Handle metric families with zero metrics gracefully.
Florian Forster [Fri, 26 Jan 2024 12:13:53 +0000 (13:13 +0100)] 
fix: Handle metric families with zero metrics gracefully.

This allows plugins to call `plugin_dispatch_metric_family()` unconditionally.

18 months agoUpdate ChangeLog for version 6.0.0.rc1. collectd-6.0.0.rc1
Florian Forster [Mon, 29 Jan 2024 08:38:32 +0000 (09:38 +0100)] 
Update ChangeLog for version 6.0.0.rc1.

18 months agosrc/collectd.conf.pod: Fix typos and an incoherent sentence.
Florian Forster [Mon, 29 Jan 2024 07:45:31 +0000 (08:45 +0100)] 
src/collectd.conf.pod: Fix typos and an incoherent sentence.

Co-authored-by: Eero Tamminen <eero.t.tamminen@intel.com>
18 months agowrite_redis plugin: Avoid duplication of an int literal.
Eero Tamminen [Mon, 29 Jan 2024 07:32:39 +0000 (08:32 +0100)] 
write_redis plugin: Avoid duplication of an int literal.

18 months agoformat_json: Use `STATIC_ARRAY_SIZE` when iterating over a static array.
Florian Forster [Mon, 29 Jan 2024 07:27:36 +0000 (08:27 +0100)] 
format_json: Use `STATIC_ARRAY_SIZE` when iterating over a static array.

18 months agowrite_redis plugin: Set the default timeout to one second.
Florian Forster [Mon, 29 Jan 2024 07:24:18 +0000 (08:24 +0100)] 
write_redis plugin: Set the default timeout to one second.

This changes the behavior back to collectd 5 behavior.

18 months ago.cirrus.yml: Upload `.log` files as artifacts.
Florian Forster [Mon, 29 Jan 2024 06:55:14 +0000 (07:55 +0100)] 
.cirrus.yml: Upload `.log` files as artifacts.

18 months agoAuto-Merge pull request #4243 from eero-t/gcc-pedantic
collectd bot [Sat, 27 Jan 2024 09:06:52 +0000 (10:06 +0100)] 
Auto-Merge pull request #4243 from eero-t/gcc-pedantic

Automatically merged due to "Automerge" label

18 months agoplugin.c: -Wpendantic cast fixes for callback handling 4243/head
Eero Tamminen [Fri, 26 Jan 2024 17:51:20 +0000 (19:51 +0200)] 
plugin.c: -Wpendantic cast fixes for callback handling

Remove void* _data_ pointer casts with correct function pointer types
and casts.  In some cases this allowed dropping the cast completely,
as I used same type for "cf_callback" member as the simplest init()
and shutdown() callbacks.

Only remaining pedantic warning is unfixable, as dlsym() API returns
void* data pointer, instead of function pointer.

Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
18 months agovl_lookup_test.c: -Wpedantic lookup_create() arg cast fixes
Eero Tamminen [Fri, 26 Jan 2024 17:02:04 +0000 (19:02 +0200)] 
vl_lookup_test.c: -Wpedantic lookup_create() arg cast fixes

Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
18 months agovalue_list_test.c: add missing include
Eero Tamminen [Fri, 26 Jan 2024 16:20:41 +0000 (18:20 +0200)] 
value_list_test.c: add missing include

For STATIC_ARRAY_SIZE.

Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
18 months agoutf8_test.c: fix -Wpedantic sign issue
Eero Tamminen [Fri, 26 Jan 2024 16:21:33 +0000 (18:21 +0200)] 
utf8_test.c: fix -Wpedantic sign issue

While GCC defaults to char being unsigned, tests would fail when
char is signed, so just declare strings to be uint8_t for utf8.

Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
18 months ago.gitignore: simplify + add more things to ignore
Eero Tamminen [Tue, 23 Jan 2024 09:51:42 +0000 (11:51 +0200)] 
.gitignore: simplify + add more things to ignore

Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>