]> git.ipfire.org Git - thirdparty/rspamd.git/log
thirdparty/rspamd.git
2 years ago[Minor] Align scores of Spamhaus DBL, SURBL, URIBL DNSBL symbols 4557/head
twesterhever [Wed, 2 Aug 2023 13:11:03 +0000 (13:11 +0000)] 
[Minor] Align scores of Spamhaus DBL, SURBL, URIBL DNSBL symbols

Given that they have about the same false positive rate, it makes sense
to treat them equal in terms of scoring:
- Particular threats (phishing, malware) are scored a bit higher than
  mere spam domain listings
- "Abused legitimate" listings are scored lower for some DNSBLs already,
  this has now been aligned.
- For SURBL, cracked and abused sites are treated with the same score.

2 years ago[Minor] Increase score of URIBL_XBL
twesterhever [Wed, 2 Aug 2023 13:09:29 +0000 (13:09 +0000)] 
[Minor] Increase score of URIBL_XBL

This aids with detecting FQDNs hosted on hacked machines, such as used
in Fast Flux-style botnet spam.

2 years ago[Minor] Reduce score of URIBL_SBL_CSS
twesterhever [Wed, 2 Aug 2023 13:07:59 +0000 (13:07 +0000)] 
[Minor] Reduce score of URIBL_SBL_CSS

Given that CSS is an automated component of SBL, this should not receive
the same scoring as manually conducted SBL listings. Particularly for
shared hosting environments, CSS hits on IP addresses derived from FQDNs
sometimes were found to be scored a bit too high.

2 years agoMerge pull request #4556 from twesterhever/temp-improve-freemail-aff
Vsevolod Stakhov [Wed, 2 Aug 2023 12:33:03 +0000 (13:33 +0100)] 
Merge pull request #4556 from twesterhever/temp-improve-freemail-aff

[Minor] Improve catch rates of FREEMAIL_AFF

2 years ago[Minor] Improve catch rates of FREEMAIL_AFF 4556/head
twesterhever [Wed, 2 Aug 2023 07:40:09 +0000 (07:40 +0000)] 
[Minor] Improve catch rates of FREEMAIL_AFF

2 years ago[Feature] Add `sentinel_password` option
Vsevolod Stakhov [Tue, 1 Aug 2023 15:07:13 +0000 (16:07 +0100)] 
[Feature] Add `sentinel_password` option

2 years ago[Minor] Link with libatomic where possible
Vsevolod Stakhov [Mon, 31 Jul 2023 15:06:44 +0000 (16:06 +0100)] 
[Minor] Link with libatomic where possible

Issue: #4552

2 years ago[Dep] Update fmtlib to 10.0.0
Vsevolod Stakhov [Mon, 31 Jul 2023 10:28:28 +0000 (11:28 +0100)] 
[Dep] Update fmtlib to 10.0.0

2 years ago[Minor] Add fmt::format specialisation
Vsevolod Stakhov [Mon, 31 Jul 2023 10:27:28 +0000 (11:27 +0100)] 
[Minor] Add fmt::format specialisation

2 years ago[Minor] Add missing include
Vsevolod Stakhov [Mon, 31 Jul 2023 09:14:39 +0000 (10:14 +0100)] 
[Minor] Add missing include

2 years ago[Minor] Remove SunPro support as it is not really supported
Vsevolod Stakhov [Sun, 30 Jul 2023 20:07:56 +0000 (21:07 +0100)] 
[Minor] Remove SunPro support as it is not really supported

2 years ago[Minor] Remove unused var
Vsevolod Stakhov [Sat, 29 Jul 2023 18:29:52 +0000 (19:29 +0100)] 
[Minor] Remove unused var

2 years ago[Minor] Improve log message
Vsevolod Stakhov [Fri, 28 Jul 2023 14:55:08 +0000 (15:55 +0100)] 
[Minor] Improve log message

2 years ago[Fix] Avoid race between config new/free by using a counter
Vsevolod Stakhov [Thu, 27 Jul 2023 13:57:22 +0000 (14:57 +0100)] 
[Fix] Avoid race between config new/free by using a counter

2 years ago[Minor] Fix pointers operations
Vsevolod Stakhov [Wed, 26 Jul 2023 13:49:56 +0000 (14:49 +0100)] 
[Minor] Fix pointers operations

2 years ago[Minor] Remove no longer used files
Vsevolod Stakhov [Wed, 26 Jul 2023 13:19:39 +0000 (14:19 +0100)] 
[Minor] Remove no longer used files

2 years ago[Minor] Add .overcommit.yml file so I won't loose my checks
Vsevolod Stakhov [Wed, 26 Jul 2023 12:53:17 +0000 (13:53 +0100)] 
[Minor] Add .overcommit.yml file so I won't loose my checks

2 years ago[Minor] Add Lua methods to get urls order
Vsevolod Stakhov [Wed, 26 Jul 2023 12:43:45 +0000 (13:43 +0100)] 
[Minor] Add Lua methods to get urls order

2 years ago[Rework] Use clang-format to unify formatting in all sources
Vsevolod Stakhov [Wed, 26 Jul 2023 09:49:23 +0000 (10:49 +0100)] 
[Rework] Use clang-format to unify formatting in all sources

No meaningful changes.

2 years ago[Feature] Add order to urls structure
Vsevolod Stakhov [Tue, 25 Jul 2023 14:56:43 +0000 (15:56 +0100)] 
[Feature] Add order to urls structure

2 years ago[Minor] Oops: I have written too long in C++
Vsevolod Stakhov [Mon, 24 Jul 2023 12:28:53 +0000 (13:28 +0100)] 
[Minor] Oops: I have written too long in C++

2 years ago[Feature] Process HTML parts before text ones
Vsevolod Stakhov [Mon, 24 Jul 2023 12:27:44 +0000 (13:27 +0100)] 
[Feature] Process HTML parts before text ones

2 years ago[Minor] Slightly change the text processing logic
Vsevolod Stakhov [Mon, 24 Jul 2023 12:09:16 +0000 (13:09 +0100)] 
[Minor] Slightly change the text processing logic

2 years agoMerge pull request #4549 from fatalbanana/ratelimit
Vsevolod Stakhov [Tue, 25 Jul 2023 10:16:38 +0000 (11:16 +0100)] 
Merge pull request #4549 from fatalbanana/ratelimit

[Minor] Minor fixes for previous ratelimit changes

2 years ago[Minor] Minor fixes for previous ratelimit changes 4549/head
Andrew Lewis [Mon, 24 Jul 2023 17:00:36 +0000 (19:00 +0200)] 
[Minor] Minor fixes for previous ratelimit changes

2 years ago[Minor] Propagate port from url parser
Vsevolod Stakhov [Mon, 24 Jul 2023 09:56:06 +0000 (10:56 +0100)] 
[Minor] Propagate port from url parser

2 years ago[Minor] Restore old port behaviour
Vsevolod Stakhov [Mon, 24 Jul 2023 09:37:22 +0000 (10:37 +0100)] 
[Minor] Restore old port behaviour

2 years ago[Feature] Reorganise struct rspamd_url to be 64 bytes size
Vsevolod Stakhov [Sun, 23 Jul 2023 19:41:02 +0000 (20:41 +0100)] 
[Feature] Reorganise struct rspamd_url to be 64 bytes size

2 years ago[Minor] Limit sse41 code to sse41 and x86_64
Vsevolod Stakhov [Sun, 23 Jul 2023 09:43:53 +0000 (10:43 +0100)] 
[Minor] Limit sse41 code to sse41 and x86_64

2 years agoMerge pull request #4547 from rheoli/dmarc_txt_fix
Vsevolod Stakhov [Sat, 22 Jul 2023 18:31:14 +0000 (19:31 +0100)] 
Merge pull request #4547 from rheoli/dmarc_txt_fix

[Fix] dmarc gramar - allow spaces before ";"

2 years ago[Minor] Use unique ptr
Vsevolod Stakhov [Fri, 21 Jul 2023 13:01:24 +0000 (14:01 +0100)] 
[Minor] Use unique ptr

2 years ago[Fix] dmarc gramar - allow spaces before ";" 4547/head
Stephan Toggweiler [Fri, 21 Jul 2023 07:15:07 +0000 (09:15 +0200)] 
[Fix] dmarc gramar - allow spaces before ";"

The ABNF in https://www.rfc-editor.org/rfc/rfc7489#section-6.4 define that its allowed to have spaces before ";"

2 years ago[Minor] Add Lua API for transliterate function
Vsevolod Stakhov [Thu, 20 Jul 2023 21:18:33 +0000 (22:18 +0100)] 
[Minor] Add Lua API for transliterate function

2 years ago[Feature] Add function to transliterate utf8 to ascii with some normalisation
Vsevolod Stakhov [Thu, 20 Jul 2023 20:43:08 +0000 (21:43 +0100)] 
[Feature] Add function to transliterate utf8 to ascii with some normalisation

2 years ago[Minor] Remove assertion in lieu of a log message
Vsevolod Stakhov [Mon, 17 Jul 2023 20:05:33 +0000 (21:05 +0100)] 
[Minor] Remove assertion in lieu of a log message

Issue: #4533
Closes: #4533
2 years agoAnother try for RHEL9
Vsevolod Stakhov [Mon, 17 Jul 2023 16:17:33 +0000 (17:17 +0100)] 
Another try for RHEL9

2 years ago[Minor] Another try to use the proper linker
Vsevolod Stakhov [Sun, 16 Jul 2023 21:18:57 +0000 (22:18 +0100)] 
[Minor] Another try to use the proper linker

2 years ago[Minor] Do not use lld when clang is not the compiler...
Vsevolod Stakhov [Sun, 16 Jul 2023 21:09:46 +0000 (22:09 +0100)] 
[Minor] Do not use lld when clang is not the compiler...

2 years agoMerge pull request #4541 from sthen/patch-1
Vsevolod Stakhov [Sat, 15 Jul 2023 12:38:04 +0000 (13:38 +0100)] 
Merge pull request #4541 from sthen/patch-1

replace ECDSA_sign_setup/ECDSA_sign_ex with ECDSA_sign

2 years agoreplace ECDSA_sign_setup/ECDSA_sign_ex with ECDSA_sign 4541/head
Stuart Henderson [Sat, 15 Jul 2023 11:41:55 +0000 (11:41 +0000)] 
replace ECDSA_sign_setup/ECDSA_sign_ex with ECDSA_sign

There's no need to use ECDSA_sign_setup/ECDSA_sign_ex separately, a single call to ECDSA_sign will handle everything that's needed here.

Avoids breakage with a soon-to-be-committed change to LibreSSL to remove ECDSA_sign_setup/ex from libcrypto.

2 years agoMerge pull request #4539 from dragoangel/patch-3
Vsevolod Stakhov [Thu, 13 Jul 2023 14:48:46 +0000 (15:48 +0100)] 
Merge pull request #4539 from dragoangel/patch-3

[Minor] A bit better apple_x_mailer regex

2 years agoAdjust apple_x_mailer regex 4539/head
Dmitriy Alekseev [Wed, 12 Jul 2023 15:02:00 +0000 (18:02 +0300)] 
Adjust apple_x_mailer regex

2 years ago[Minor] A bit better apple_x_mailer regex
Dmitriy Alekseev [Wed, 12 Jul 2023 11:00:25 +0000 (14:00 +0300)] 
[Minor] A bit better apple_x_mailer regex

2 years agoMerge pull request #4538 from dragoangel/patch-2
Vsevolod Stakhov [Wed, 12 Jul 2023 10:42:58 +0000 (11:42 +0100)] 
Merge pull request #4538 from dragoangel/patch-2

[Feature] Detect Apple Mail and remove scores for their known common behavior

2 years agoOptimize apple_ios_x_mailer regex 4538/head
Dmitriy Alekseev [Wed, 12 Jul 2023 10:23:33 +0000 (13:23 +0300)] 
Optimize apple_ios_x_mailer regex

2 years agoMerge pull request #4537 from moesoha/relay/ip_map
Vsevolod Stakhov [Tue, 11 Jul 2023 18:55:30 +0000 (19:55 +0100)] 
Merge pull request #4537 from moesoha/relay/ip_map

[Feature] external_relay: add ip_map strategy

2 years agoAdd composites exclusions for known Apple Mail bad symbols
Dmitriy Alekseev [Tue, 11 Jul 2023 18:28:43 +0000 (21:28 +0300)] 
Add composites exclusions for known Apple Mail bad symbols

2 years agoSupport regex rules to detect Apple Mail
Dmitriy Alekseev [Tue, 11 Jul 2023 18:22:17 +0000 (21:22 +0300)] 
Support regex rules to detect Apple Mail

2 years ago[Feature] external_relay: add ip_map strategy 4537/head
Soha Jin [Tue, 11 Jul 2023 12:28:07 +0000 (20:28 +0800)] 
[Feature] external_relay: add ip_map strategy

2 years ago[Fix] test external_relay: count should always be the last rule,
Soha Jin [Tue, 11 Jul 2023 12:27:53 +0000 (20:27 +0800)] 
[Fix] test external_relay: count should always be the last rule,
as it have no matching condition

2 years ago[Minor] Fix another `enum` usage in fmt
Vsevolod Stakhov [Sun, 9 Jul 2023 21:41:28 +0000 (22:41 +0100)] 
[Minor] Fix another `enum` usage in fmt

Issue: #4482

2 years agoMerge pull request #4532 from mrueg/bookworm
Vsevolod Stakhov [Thu, 6 Jul 2023 20:50:24 +0000 (21:50 +0100)] 
Merge pull request #4532 from mrueg/bookworm

Dockerfile: Switch to bookworm

2 years agoDockerfile: Switch to bookworm 4532/head
Manuel Rüger [Wed, 5 Jul 2023 20:41:14 +0000 (22:41 +0200)] 
Dockerfile: Switch to bookworm

2 years ago[Minor] Fix fuzzy_unlearn_handler when a flag is specified
Vsevolod Stakhov [Wed, 5 Jul 2023 20:33:36 +0000 (21:33 +0100)] 
[Minor] Fix fuzzy_unlearn_handler when a flag is specified

Issue: #4531

2 years ago[Minor] One more compatibility fix
Vsevolod Stakhov [Mon, 3 Jul 2023 22:00:12 +0000 (23:00 +0100)] 
[Minor] One more compatibility fix

2 years ago[Minor] Try to be more compatible
Vsevolod Stakhov [Sun, 2 Jul 2023 16:39:07 +0000 (17:39 +0100)] 
[Minor] Try to be more compatible

2 years ago[Minor] Lua_magic: Try to reduce fp rate for html heuristic
Vsevolod Stakhov [Sun, 2 Jul 2023 16:33:28 +0000 (17:33 +0100)] 
[Minor] Lua_magic: Try to reduce fp rate for html heuristic

2 years ago[Minor] Fix log message
Vsevolod Stakhov [Sat, 1 Jul 2023 19:02:35 +0000 (20:02 +0100)] 
[Minor] Fix log message

2 years ago[Minor] Try to save ratelimits from the proper worker
Vsevolod Stakhov [Sat, 1 Jul 2023 18:56:23 +0000 (19:56 +0100)] 
[Minor] Try to save ratelimits from the proper worker

2 years ago[Feature] Save fuzzy ratelimit buckets
Vsevolod Stakhov [Sat, 1 Jul 2023 14:22:10 +0000 (15:22 +0100)] 
[Feature] Save fuzzy ratelimit buckets

2 years ago[Minor] Do not block rate limit elements in fuzzy forever
Vsevolod Stakhov [Sat, 1 Jul 2023 13:28:43 +0000 (14:28 +0100)] 
[Minor] Do not block rate limit elements in fuzzy forever

2 years ago[Feature] Allow fuzzy workers to exchange blocked information
Vsevolod Stakhov [Sat, 1 Jul 2023 12:32:22 +0000 (13:32 +0100)] 
[Feature] Allow fuzzy workers to exchange blocked information

2 years ago[Minor] Remove redundant check
Vsevolod Stakhov [Mon, 26 Jun 2023 20:01:25 +0000 (21:01 +0100)] 
[Minor] Remove redundant check

2 years ago[Feature] Preliminary implementation of dynamic composites
Vsevolod Stakhov [Sun, 25 Jun 2023 18:37:58 +0000 (19:37 +0100)] 
[Feature] Preliminary implementation of dynamic composites

2 years ago[Minor] Missing include?
Vsevolod Stakhov [Sat, 24 Jun 2023 18:28:33 +0000 (19:28 +0100)] 
[Minor] Missing include?

2 years ago[Tests] Add unit tests
Vsevolod Stakhov [Sat, 24 Jun 2023 14:52:34 +0000 (15:52 +0100)] 
[Tests] Add unit tests

2 years ago[Minor] Add utility to split strings on some character
Vsevolod Stakhov [Sat, 24 Jun 2023 14:51:57 +0000 (15:51 +0100)] 
[Minor] Add utility to split strings on some character

2 years ago[Minor] Add utility to iterate over a list of newline separated strings
Vsevolod Stakhov [Sat, 24 Jun 2023 13:55:55 +0000 (14:55 +0100)] 
[Minor] Add utility to iterate over a list of newline separated strings

2 years agoMerge pull request #4519 from twesterhever/temp-html-attachments
Vsevolod Stakhov [Fri, 23 Jun 2023 19:40:35 +0000 (20:40 +0100)] 
Merge pull request #4519 from twesterhever/temp-html-attachments

[Enhancement] Treat HTML attachments as (slightly) bad

2 years agoMerge pull request #4520 from mariojansen/master
Vsevolod Stakhov [Fri, 23 Jun 2023 16:57:59 +0000 (17:57 +0100)] 
Merge pull request #4520 from mariojansen/master

if elasticsearch_version >= 7 we should not send the _type to elastic…

2 years agoif elasticsearch_version >= 7 we should not send the _type to elasticsearch, deprecat... 4520/head
Mario Jansen [Fri, 23 Jun 2023 11:59:50 +0000 (13:59 +0200)] 
if elasticsearch_version >= 7 we should not send the _type to elasticsearch, deprecated in es 7, obsolete in es 8

2 years ago[Minor] Fix missing and superflous comma 4519/head
twesterhever [Fri, 23 Jun 2023 08:54:21 +0000 (08:54 +0000)] 
[Minor] Fix missing and superflous comma

Thanks, @moisseev!

2 years agoMerge pull request #4497 from twesterhever/temp-improve-has-google-redir
Vsevolod Stakhov [Thu, 22 Jun 2023 22:02:30 +0000 (23:02 +0100)] 
Merge pull request #4497 from twesterhever/temp-improve-has-google-redir

[Enhancement] Improve detection of Google redirection URLs

2 years agoKeep attachment filename suffix lists sorted
twesterhever [Thu, 22 Jun 2023 21:01:26 +0000 (21:01 +0000)] 
Keep attachment filename suffix lists sorted

2 years agoTreat HTML attachments as bad
twesterhever [Thu, 22 Jun 2023 20:58:18 +0000 (20:58 +0000)] 
Treat HTML attachments as bad

2 years ago[Minor] Remove superfluous '|' in regular expression 4497/head
twesterhever [Thu, 22 Jun 2023 20:51:54 +0000 (20:51 +0000)] 
[Minor] Remove superfluous '|' in regular expression

2 years ago[Minor] Simplify regular expression for HAS_GOOGLE_REDIR
twesterhever [Thu, 22 Jun 2023 20:50:03 +0000 (20:50 +0000)] 
[Minor] Simplify regular expression for HAS_GOOGLE_REDIR

https://github.com/rspamd/rspamd/pull/4497#issuecomment-1586265815

2 years agoMerge pull request #4518 from twesterhever/temp-chm-suffix
Vsevolod Stakhov [Tue, 20 Jun 2023 21:35:04 +0000 (22:35 +0100)] 
Merge pull request #4518 from twesterhever/temp-chm-suffix

[Minor] Increase score for .chm attachments

2 years ago[Minor] Increase score for attachment types already blocked by GMail and Outlook 4518/head
twesterhever [Tue, 20 Jun 2023 15:57:48 +0000 (15:57 +0000)] 
[Minor] Increase score for attachment types already blocked by GMail and Outlook

https://github.com/rspamd/rspamd/pull/4518#issuecomment-1598655957

2 years ago[Minor] Increase score for .chm attachments
twesterhever [Tue, 20 Jun 2023 11:47:08 +0000 (11:47 +0000)] 
[Minor] Increase score for .chm attachments

2 years agoMerge pull request #4517 from JasonStephenson/bugfix/7z-cte-fix
Vsevolod Stakhov [Mon, 19 Jun 2023 21:37:29 +0000 (22:37 +0100)] 
Merge pull request #4517 from JasonStephenson/bugfix/7z-cte-fix

Use the correct mime format for 7z

2 years agoUse the correct mime format for 7z 4517/head
Jason Stephenson [Mon, 19 Jun 2023 14:42:57 +0000 (15:42 +0100)] 
Use the correct mime format for 7z

2 years ago[Minor] Use 1.0 as static score for dynamic symbols, erm
Vsevolod Stakhov [Sun, 18 Jun 2023 18:57:29 +0000 (19:57 +0100)] 
[Minor] Use 1.0 as static score for dynamic symbols, erm

2 years ago[Minor] Add fail-safe for composites processing
Vsevolod Stakhov [Sat, 17 Jun 2023 14:45:39 +0000 (15:45 +0100)] 
[Minor] Add fail-safe for composites processing

2 years ago[Minor] Allow silent addition of the composites from the configuration
Vsevolod Stakhov [Sat, 17 Jun 2023 14:43:12 +0000 (15:43 +0100)] 
[Minor] Allow silent addition of the composites from the configuration

2 years ago[Minor] Get rid of one more GHashTable
Vsevolod Stakhov [Sat, 17 Jun 2023 14:20:27 +0000 (15:20 +0100)] 
[Minor] Get rid of one more GHashTable

2 years ago[Minor] Add utility macros for static hash tables
Vsevolod Stakhov [Sat, 17 Jun 2023 14:20:12 +0000 (15:20 +0100)] 
[Minor] Add utility macros for static hash tables

2 years ago[Minor] Define simple ftok hash and equal functions
Vsevolod Stakhov [Sat, 17 Jun 2023 14:01:36 +0000 (15:01 +0100)] 
[Minor] Define simple ftok hash and equal functions

2 years ago[Minor] Use wyhash for string hashing
Vsevolod Stakhov [Sat, 17 Jun 2023 13:57:44 +0000 (14:57 +0100)] 
[Minor] Use wyhash for string hashing

2 years ago[Feature] Khash: Allow static initialisation
Vsevolod Stakhov [Sat, 17 Jun 2023 13:50:08 +0000 (14:50 +0100)] 
[Feature] Khash: Allow static initialisation

2 years ago[Fix] Try harder to clean pending bucket
Vsevolod Stakhov [Sat, 17 Jun 2023 12:06:52 +0000 (13:06 +0100)] 
[Fix] Try harder to clean pending bucket

Issue: #4467

2 years ago[Minor] Oops, fix build
Vsevolod Stakhov [Sat, 17 Jun 2023 11:22:00 +0000 (12:22 +0100)] 
[Minor] Oops, fix build

2 years ago[Minor] Allow to allocate rspamd_text from task
Vsevolod Stakhov [Sat, 17 Jun 2023 11:19:01 +0000 (12:19 +0100)] 
[Minor] Allow to allocate rspamd_text from task

2 years ago[Minor] Fix Lua stack
Vsevolod Stakhov [Wed, 14 Jun 2023 21:31:16 +0000 (22:31 +0100)] 
[Minor] Fix Lua stack

2 years ago[Minor] Another workaround for a broken OpenSSL API
Vsevolod Stakhov [Wed, 14 Jun 2023 18:31:13 +0000 (19:31 +0100)] 
[Minor] Another workaround for a broken OpenSSL API

2 years ago[Minor] Parse remaning content when reaching html limit
Vsevolod Stakhov [Tue, 13 Jun 2023 21:10:17 +0000 (22:10 +0100)] 
[Minor] Parse remaning content when reaching html limit

2 years ago[Minor] Fix another usage of EC_POINT_point2bn
Vsevolod Stakhov [Mon, 12 Jun 2023 11:23:15 +0000 (12:23 +0100)] 
[Minor] Fix another usage of EC_POINT_point2bn

2 years ago[Minor] Try to fix build with (broken) OpenSSL API
Vsevolod Stakhov [Mon, 12 Jun 2023 10:52:00 +0000 (11:52 +0100)] 
[Minor] Try to fix build with (broken) OpenSSL API

2 years agoMerge pull request #4494 from twesterhever/temp-arm-google-firebase
Vsevolod Stakhov [Sun, 11 Jun 2023 18:00:02 +0000 (19:00 +0100)] 
Merge pull request #4494 from twesterhever/temp-arm-google-firebase

[Rules] Make Google Firebase rule productive

2 years ago[Minor] Adjust prototype
Vsevolod Stakhov [Sat, 10 Jun 2023 21:45:21 +0000 (22:45 +0100)] 
[Minor] Adjust prototype