]> git.ipfire.org Git - thirdparty/rrdtool-1.x.git/log
thirdparty/rrdtool-1.x.git
11 years agocleanup: fix link target 472/head
Peter A. Bigot [Fri, 16 May 2014 14:18:48 +0000 (09:18 -0500)] 
cleanup: fix link target

11 years agocleanup: remove compiler warnings
Peter A. Bigot [Fri, 16 May 2014 14:16:19 +0000 (09:16 -0500)] 
cleanup: remove compiler warnings

Eliminate the cause of several diagnostics emitted by gcc 4.6.3 and
4.9.0:

- index, time, tmpfile, optind, and remove are all globally-visible
  symbols that were shadowed by local declarations
- time_t may be a signed type, resulting in a signed/unsigned comparison
  warning from an operation in rrd_xport
- bypass declarations of variables not referenced due to DISABLE_FLOCK

11 years agoMerge pull request #468 from pabigot/enh-create-with-dur
Tobias Oetiker [Fri, 16 May 2014 11:27:58 +0000 (13:27 +0200)] 
Merge pull request #468 from pabigot/enh-create-with-dur

rrdcreate: support scale suffix for heartbeat/steps/rows

11 years agorrdcreate: improve scale support 468/head
Peter A. Bigot [Fri, 16 May 2014 11:09:48 +0000 (06:09 -0500)] 
rrdcreate: improve scale support

- Fix missed diagnostic for negative values accepted by strtoul.
- Add detailed diagnostics for parsing failures.
- Add diagnostic when duration-based RRA steps (rows) are not multiples of
  PDP interval (RRA span).
- Fix row count when PDP interval not one second.
- Extend documentation to special-function RRA example.

11 years agorrdcreate: support scale suffix for heartbeat/steps/rows
Peter A. Bigot [Thu, 15 May 2014 21:27:41 +0000 (16:27 -0500)] 
rrdcreate: support scale suffix for heartbeat/steps/rows

This feature allows this opaque create specification:

  rrdtool create power1.rrd \
    --start 0 --step 1 \
    DS:watts:GAUGE:300:0:24000 \
    RRA:AVERAGE:0.5:1:864000 \
    RRA:AVERAGE:0.5:60:129600 \
    RRA:AVERAGE:0.5:3600:13392 \
    RRA:AVERAGE:0.5:86400:3660

to be expressed with more understandable durations:

  rrdtool create power2.rrd \
    --start 0 --step 1s \
    DS:watts:GAUGE:5m:0:24000 \
    RRA:AVERAGE:0.5:1s:10d \
    RRA:AVERAGE:0.5:1m:90d \
    RRA:AVERAGE:0.5:1h:18M \
    RRA:AVERAGE:0.5:1d:10y

Signed-off-by: Peter A. Bigot <pab@pabigot.com>
11 years agotry to make coveralls work
Tobias Oetiker [Thu, 15 May 2014 14:08:22 +0000 (16:08 +0200)] 
try to make coveralls work

11 years agoMerge pull request #467 from oetiker/flock-option
Tobias Oetiker [Wed, 14 May 2014 14:56:23 +0000 (16:56 +0200)] 
Merge pull request #467 from oetiker/flock-option

Flock option

11 years agoMerge branch 'master' into flock-option 467/head
Tobias Oetiker [Wed, 14 May 2014 14:31:24 +0000 (16:31 +0200)] 
Merge branch 'master' into flock-option

11 years agoautogen.sh is now bootstrap!
Tobias Oetiker [Wed, 14 May 2014 14:29:11 +0000 (16:29 +0200)] 
autogen.sh is now bootstrap!

11 years agomake file locking compiletime configurable
Tobias Oetiker [Wed, 14 May 2014 14:23:32 +0000 (16:23 +0200)] 
make file locking compiletime configurable

11 years agomake file locking compiletime configurable
Tobias Oetiker [Wed, 14 May 2014 14:23:28 +0000 (16:23 +0200)] 
make file locking compiletime configurable

11 years agothat file should be called bootstrap it seems
Tobias Oetiker [Wed, 14 May 2014 13:15:27 +0000 (15:15 +0200)] 
that file should be called bootstrap it seems

11 years agoMerge pull request #465 from msperl/master-predictperc
Tobias Oetiker [Wed, 7 May 2014 06:03:03 +0000 (08:03 +0200)] 
Merge pull request #465 from msperl/master-predictperc

added PREDICTPERC(entil) CDEF function

11 years agoadded interpolation for percentile 465/head
Martin Sperl [Tue, 6 May 2014 21:37:47 +0000 (21:37 +0000)] 
added interpolation for percentile

11 years agoadded PREDICTPERC function
Martin Sperl [Tue, 6 May 2014 20:12:44 +0000 (20:12 +0000)] 
added PREDICTPERC function
there is one still open question: should we interpolate to get the final value?
Say: if we have 8 values, and we want thd 95th percventile, then
we should actually take the 6.65th 0-based index value (=95/100*(8-1)).
with the current implementation we round, so we return actually the 100th percentile.
what we could also do is:
value=val[floor(idx)]+(idx-floor(idx))*(val[floor(idx)+1]-val[floor(idx)])
(besides some boundry checking for the explicit percentile 100)

this should get decided prior to final merging

11 years agoMerge pull request #464 from aelse/issue463-fix-xport-json
Tobias Oetiker [Tue, 6 May 2014 07:30:02 +0000 (09:30 +0200)] 
Merge pull request #464 from aelse/issue463-fix-xport-json

Fix #463 - account for step in xport json

11 years agoFix #463 - account for step in xport json 464/head
Alexander Else [Tue, 6 May 2014 07:22:50 +0000 (17:22 +1000)] 
Fix #463 - account for step in xport json

Final element check changed from end to end-step

11 years agoMerge pull request #460 from tokkee/build
Tobias Oetiker [Tue, 6 May 2014 06:33:37 +0000 (08:33 +0200)] 
Merge pull request #460 from tokkee/build

Fixed various compiler warnings

11 years agoMerge pull request #462 from msperl/master-cached+template
Tobias Oetiker [Mon, 5 May 2014 20:12:27 +0000 (22:12 +0200)] 
Merge pull request #462 from msperl/master-cached+template

enable --template when using --daemon

11 years agoenabled template for rrdcached updates 462/head
Martin Sperl [Mon, 5 May 2014 16:18:55 +0000 (16:18 +0000)] 
enabled template for rrdcached updates
this essentially "expands" the template to a "normal" update
based on the structure from the file itself.
This structure is cached in a GTree until the process dies - no validation is done to check if the file changed in the meantime

11 years agoadded option to strip path away when using rrdcached
Martin Sperl [Mon, 5 May 2014 16:10:31 +0000 (16:10 +0000)] 
added option to strip path away when using rrdcached

11 years agorrd_daemon: Fixed the resolved_path argument passed to realpath(). 460/head
Sebastian Harl [Sat, 26 Apr 2014 10:33:10 +0000 (12:33 +0200)] 
rrd_daemon: Fixed the resolved_path argument passed to realpath().

The function expects a character pointer, not a pointer to an array of
character pointers.

11 years agoFixed invalid type conversions.
Sebastian Harl [Sat, 26 Apr 2014 10:28:17 +0000 (12:28 +0200)] 
Fixed invalid type conversions.

11 years agoFixed various unused variable compiler warnings.
Sebastian Harl [Sat, 26 Apr 2014 10:27:44 +0000 (12:27 +0200)] 
Fixed various unused variable compiler warnings.

11 years agosrc/Makefile: Link rrdcached against ALL_LIBS directly.
Sebastian Harl [Sat, 26 Apr 2014 09:51:01 +0000 (11:51 +0200)] 
src/Makefile: Link rrdcached against ALL_LIBS directly.

rrdcached uses glib and, thus, needs to be linked against the lib directly.
While some linkers work fine since librrd_th is linked against ALL_LIBS, some
other linkers don't.

11 years agoMerge pull request #459 from tokkee/debbts606844
Tobias Oetiker [Fri, 25 Apr 2014 21:11:27 +0000 (23:11 +0200)] 
Merge pull request #459 from tokkee/debbts606844

rrdupdate(1): Removed a duplicate section.

11 years agorrdupdate(1): Removed a duplicate section. 459/head
Sebastian Harl [Fri, 25 Apr 2014 19:32:10 +0000 (21:32 +0200)] 
rrdupdate(1): Removed a duplicate section.

Presumably, this was caused by some merge.

Reported by Sandro Tosi in https://bugs.debian.org/603507

11 years agotrying to get coverage for shared library
Tobias Oetiker [Sat, 29 Mar 2014 21:01:58 +0000 (22:01 +0100)] 
trying to get coverage for shared library

11 years agocoveralls.io
Tobias Oetiker [Sat, 29 Mar 2014 20:50:56 +0000 (21:50 +0100)] 
coveralls.io

11 years agoONLY gcov should run in the src directory
Tobias Oetiker [Sat, 29 Mar 2014 06:31:43 +0000 (07:31 +0100)] 
ONLY gcov should run in the src directory

11 years agogcov must run in the source directoy
Tobias Oetiker [Sat, 29 Mar 2014 06:15:47 +0000 (07:15 +0100)] 
gcov must run in the source directoy

11 years agoit seems we fail to build the ruby bindings of testcoverage is active :-(
Tobias Oetiker [Sat, 29 Mar 2014 05:46:54 +0000 (06:46 +0100)] 
it seems we fail to build the ruby bindings of testcoverage is active :-(

11 years agoappend the modified CFLGAS do not replace them
Tobias Oetiker [Sat, 29 Mar 2014 05:37:26 +0000 (06:37 +0100)] 
append the modified CFLGAS do not replace them

11 years agoMerge branch 'master' of github.com:oetiker/rrdtool-1.x
Tobias Oetiker [Sat, 29 Mar 2014 05:29:30 +0000 (06:29 +0100)] 
Merge branch 'master' of github.com:oetiker/rrdtool-1.x

Conflicts:
.travis.yml

11 years agofirst go at test coverage
Tobias Oetiker [Sat, 29 Mar 2014 05:26:38 +0000 (06:26 +0100)] 
first go at test coverage

11 years agoMerge pull request #456 from laiwei/master
Tobias Oetiker [Tue, 25 Mar 2014 22:36:50 +0000 (23:36 +0100)] 
Merge pull request #456 from laiwei/master

bugfix: add a lock in handle_request_create, fix the rrdcached crash

11 years agobugfix: add a lock in handle_request_create, fix the rrdcached crash 456/head
laiwei [Mon, 24 Mar 2014 03:47:17 +0000 (11:47 +0800)] 
bugfix: add a lock in handle_request_create, fix the rrdcached crash

11 years agoMerge pull request #455 from schweikert/rrds-xport-documentation
Tobias Oetiker [Thu, 20 Mar 2014 15:35:49 +0000 (16:35 +0100)] 
Merge pull request #455 from schweikert/rrds-xport-documentation

add documentation for RRDs::xport

11 years agoadd documentation for RRDs::xport 455/head
David Schweikert [Thu, 20 Mar 2014 14:45:32 +0000 (15:45 +0100)] 
add documentation for RRDs::xport

11 years agoMerge pull request #454 from stamfest/unify-tune-modify
Tobias Oetiker [Tue, 18 Mar 2014 04:59:42 +0000 (05:59 +0100)] 
Merge pull request #454 from stamfest/unify-tune-modify

Unify tune modify

11 years agoMerge branch 'tobi-master' into unify-tune-modify 454/head
Peter Stamfest [Mon, 17 Mar 2014 23:40:29 +0000 (00:40 +0100)] 
Merge branch 'tobi-master' into unify-tune-modify

11 years agoremove "modify" command - we have folded the functionality into "tune"
Peter Stamfest [Mon, 17 Mar 2014 21:41:44 +0000 (22:41 +0100)] 
remove "modify" command - we have folded the functionality into "tune"

11 years agoModify tests to match new "tune" command
Peter Stamfest [Mon, 17 Mar 2014 07:41:02 +0000 (08:41 +0100)] 
Modify tests to match new "tune" command

11 years agoFix warning
Peter Stamfest [Mon, 17 Mar 2014 07:40:27 +0000 (08:40 +0100)] 
Fix warning

11 years agorrdcached integration also with "tune"
Peter Stamfest [Mon, 17 Mar 2014 07:39:50 +0000 (08:39 +0100)] 
rrdcached integration also with "tune"

11 years agoFirst step to really integrate modify into tune. Currently implemented
Peter Stamfest [Mon, 17 Mar 2014 07:39:00 +0000 (08:39 +0100)] 
First step to really integrate modify into tune. Currently implemented
by doing all the "tune" conversions in place and doing the "modify"
operations through a temporary RRD file with a followed move to
the original file

11 years agovalgrind suppression for pixman_constructor, to hide memory leaks
Peter Stamfest [Sun, 16 Mar 2014 16:44:49 +0000 (17:44 +0100)] 
valgrind suppression for pixman_constructor, to hide memory leaks
created during library init

11 years agoFix all usages of setlocale: setlocale might (and on linux DOES)
Peter Stamfest [Sun, 16 Mar 2014 16:36:23 +0000 (17:36 +0100)] 
Fix all usages of setlocale: setlocale might (and on linux DOES)
return a pointer to memory handled internally by libc, calling
setlocale twice and using the data returned from the first call
later on causes access to already free'd memory. This was clearly
seen through valgrind. Eg. use

  TESTS_STYLE=valgrind ./tests/tune2

with this cs backed-out and you will see valgrind problems
related to setlocale.

11 years agorrd_tune: establish a single cleanup/return code path
Peter Stamfest [Sun, 16 Mar 2014 07:40:45 +0000 (08:40 +0100)] 
rrd_tune: establish a single cleanup/return code path
- fix a couple of resource leaks on the way

11 years agoactivate tune tests in test-suite
Peter Stamfest [Sun, 16 Mar 2014 09:39:20 +0000 (10:39 +0100)] 
activate tune tests in test-suite

11 years agoAnother "tune" test
Peter Stamfest [Sun, 16 Mar 2014 09:37:16 +0000 (10:37 +0100)] 
Another "tune" test
(there is a fd leak in parts of the tune code, used this test to
demonstrate it - kept for reference and general testing)

11 years agoadd some tune tests
Peter Stamfest [Sun, 16 Mar 2014 07:55:59 +0000 (08:55 +0100)] 
add some tune tests

11 years agoTrack open fds through valgrind
Peter Stamfest [Sun, 16 Mar 2014 08:37:53 +0000 (09:37 +0100)] 
Track open fds through valgrind

11 years agoMerge branch 'memory-management' into rrdmodify-master
Peter Stamfest [Sun, 16 Mar 2014 08:31:15 +0000 (09:31 +0100)] 
Merge branch 'memory-management' into rrdmodify-master

11 years agoFix nasty double-free error in rrd_free (duh!)
Peter Stamfest [Sun, 16 Mar 2014 08:27:24 +0000 (09:27 +0100)] 
Fix nasty double-free error in rrd_free (duh!)

11 years agoStart modify/tune unification
Peter Stamfest [Sat, 15 Mar 2014 20:48:48 +0000 (21:48 +0100)] 
Start modify/tune unification

11 years agoUse RRD_READVALUES to read data
Peter Stamfest [Sat, 15 Mar 2014 20:23:07 +0000 (21:23 +0100)] 
Use RRD_READVALUES to read data

11 years agoadd RRD_READVALUES option to rrd_open
Peter Stamfest [Sat, 15 Mar 2014 20:19:32 +0000 (21:19 +0100)] 
add RRD_READVALUES option to rrd_open
- in case of mmap just point to the correct position within the file

11 years agoMake rrd_free idempotent by resetting free'd pointers to NULL
Peter Stamfest [Sat, 15 Mar 2014 20:21:00 +0000 (21:21 +0100)] 
Make rrd_free idempotent by resetting free'd pointers to NULL

11 years agoget rid of temporarily introduced fixed hash value
Peter Stamfest [Fri, 14 Mar 2014 07:40:12 +0000 (08:40 +0100)] 
get rid of temporarily introduced fixed hash value

11 years agoMerge branch 'automake-based-checks' into memory-management
Peter Stamfest [Fri, 14 Mar 2014 07:19:38 +0000 (08:19 +0100)] 
Merge branch 'automake-based-checks' into memory-management

11 years agoNever ever should a function free an object that was passed in. At least this
Peter Stamfest [Wed, 12 Mar 2014 16:42:10 +0000 (17:42 +0100)] 
Never ever should a function free an object that was passed in. At least this
is my opinion.
Also get rid of a specialised rrd_free function and clean up exit paths of
functions.

11 years agoTry to handle freeing of mmapped and malloced rrd_t objects transparently
Peter Stamfest [Wed, 12 Mar 2014 16:39:13 +0000 (17:39 +0100)] 
Try to handle freeing of mmapped and malloced rrd_t objects transparently

This IS rather hackish - an OO inspired approach might be better, but adding
knowledge about mmapped memory to the free path even allows mixed
mmapped/malloced objects

11 years agoif a test fails report original exit code instead of just 1
Peter Stamfest [Fri, 14 Mar 2014 06:31:00 +0000 (07:31 +0100)] 
if a test fails report original exit code instead of just 1

11 years agoname individual tests in Makefile.am
Peter Stamfest [Thu, 13 Mar 2014 20:18:08 +0000 (21:18 +0100)] 
name individual tests in Makefile.am

11 years agoValgrind changes for travis - show log and include supressions
Peter Stamfest [Thu, 13 Mar 2014 10:50:27 +0000 (11:50 +0100)] 
Valgrind changes for travis - show log and include supressions

11 years agoCurrently, tests have to run in the CET timezone.
Peter Stamfest [Wed, 12 Mar 2014 21:15:46 +0000 (22:15 +0100)] 
Currently, tests have to run in the CET timezone.

11 years agoinstall valgrind - needed for test suite
Peter Stamfest [Wed, 12 Mar 2014 20:56:45 +0000 (21:56 +0100)] 
install valgrind - needed for test suite

11 years agotry to get travis to run the test suite....
Peter Stamfest [Wed, 12 Mar 2014 20:48:11 +0000 (21:48 +0100)] 
try to get travis to run the test suite....

11 years agoUse valgrind via travis
Peter Stamfest [Wed, 12 Mar 2014 20:12:30 +0000 (21:12 +0100)] 
Use valgrind via travis

11 years agoValgrind support for the test suite. valgrind gets used when called as "make check...
Peter Stamfest [Wed, 12 Mar 2014 20:11:12 +0000 (21:11 +0100)] 
Valgrind support for the test suite. valgrind gets used when called as "make check TESTS_STYLE=valgrind"

11 years agoUse automake based checks ("make check") and use the mechanism for travis
Peter Stamfest [Wed, 12 Mar 2014 16:50:33 +0000 (17:50 +0100)] 
Use automake based checks ("make check") and use the mechanism for travis

11 years agoMerge pull request #453 from laiwei/master
Tobias Oetiker [Tue, 11 Mar 2014 08:23:35 +0000 (09:23 +0100)] 
Merge pull request #453 from laiwei/master

bugfix: memory leak and dir-creating not work

11 years agofix missing realpath 453/head
laiwei [Tue, 11 Mar 2014 07:49:21 +0000 (15:49 +0800)] 
fix missing realpath

11 years agobugfix: free filecopy when create when recursive creating dir; bugfix: dir-creating...
laiwei [Tue, 11 Mar 2014 03:24:44 +0000 (11:24 +0800)] 
bugfix: free filecopy when create when recursive creating dir; bugfix: dir-creating not working

11 years agoMerge pull request #452 from stamfest/rrdmodify-master
Tobias Oetiker [Sun, 9 Mar 2014 17:30:39 +0000 (18:30 +0100)] 
Merge pull request #452 from stamfest/rrdmodify-master

Rrdmodify master

11 years agoRevert "Make modify command available using RRDs" 452/head
Peter Stamfest [Sat, 8 Mar 2014 12:32:49 +0000 (13:32 +0100)] 
Revert "Make modify command available using RRDs"

This reverts commit c77b6b7a567bd787baa98a9e459bd64e9ef39154.
This cs should not have been on this branch, but because the branch was
pushed before, it can only be reverted...

11 years agoimproved rrdmodify documentation
Peter Stamfest [Sat, 8 Mar 2014 10:20:54 +0000 (11:20 +0100)] 
improved rrdmodify documentation

11 years agoMake modify command available using RRDs
Peter Stamfest [Sat, 8 Mar 2014 08:22:37 +0000 (09:22 +0100)] 
Make modify command available using RRDs

11 years agoTake care to change CDPs when changing step size and change resize semantics
Peter Stamfest [Sat, 8 Mar 2014 08:21:04 +0000 (09:21 +0100)] 
Take care to change CDPs when changing step size and change resize semantics
- all RRA modifications are now done AFTER resizing

11 years agofix timezone in tests
Tobias Oetiker [Fri, 7 Mar 2014 08:12:04 +0000 (09:12 +0100)] 
fix timezone in tests

11 years agomore test invocation fixing
Tobias Oetiker [Fri, 7 Mar 2014 07:59:23 +0000 (08:59 +0100)] 
more test invocation fixing

11 years agoimprove step resizing, this still is experimental
Peter Stamfest [Fri, 7 Mar 2014 06:38:35 +0000 (07:38 +0100)] 
improve step resizing, this still is experimental

11 years agofixed stray mentions of rrdtool (not $RRDTOOL) in test scripts, causing them to fail...
Tobias Oetiker [Fri, 7 Mar 2014 05:09:47 +0000 (06:09 +0100)] 
fixed stray mentions of rrdtool (not $RRDTOOL) in test scripts, causing them to fail on travis

11 years agoanother try at fixing travis setup
Tobias Oetiker [Thu, 6 Mar 2014 22:39:07 +0000 (23:39 +0100)] 
another try at fixing travis setup

11 years agoFurther chop up rrd_modify_r in order to integrate step changes into DS/RRA
Peter Stamfest [Thu, 6 Mar 2014 21:54:13 +0000 (22:54 +0100)] 
Further chop up rrd_modify_r in order to integrate step changes into DS/RRA
modifications.

11 years agoextremely experimental RRD step stretching
Peter Stamfest [Thu, 6 Mar 2014 18:06:48 +0000 (19:06 +0100)] 
extremely experimental RRD step stretching

11 years agoanother try for integrating tests
Tobias Oetiker [Thu, 6 Mar 2014 16:09:25 +0000 (17:09 +0100)] 
another try for integrating tests

11 years agoit is tests not test
Tobias Oetiker [Thu, 6 Mar 2014 13:09:51 +0000 (14:09 +0100)] 
it is tests not test

11 years agoanother try with travis
Tobias Oetiker [Thu, 6 Mar 2014 09:54:03 +0000 (10:54 +0100)] 
another try with travis

11 years agoadded new tests to travis build
Tobias Oetiker [Thu, 6 Mar 2014 09:47:30 +0000 (10:47 +0100)] 
added new tests to travis build

11 years agoMerge pull request #450 from stamfest/rrdmodify-master
Tobias Oetiker [Thu, 6 Mar 2014 09:40:52 +0000 (10:40 +0100)] 
Merge pull request #450 from stamfest/rrdmodify-master

Rrdmodify master

11 years agoMerge pull request #451 from stamfest/small-fixes
Tobias Oetiker [Thu, 6 Mar 2014 09:39:28 +0000 (10:39 +0100)] 
Merge pull request #451 from stamfest/small-fixes

small fixes

11 years agobetter test flexibility - use a specific rrdtool to do the tests 450/head
Peter Stamfest [Thu, 6 Mar 2014 07:49:41 +0000 (08:49 +0100)] 
better test flexibility - use a specific rrdtool to do the tests

11 years agoFix nasty off-by-one error, causing incorrect CDP calculations when adding
Peter Stamfest [Thu, 6 Mar 2014 07:26:06 +0000 (08:26 +0100)] 
Fix nasty off-by-one error, causing incorrect CDP calculations when adding
new RRAs

11 years agoAdd alltests script to run all tests at once
Peter Stamfest [Wed, 5 Mar 2014 20:30:28 +0000 (21:30 +0100)] 
Add alltests script to run all tests at once

11 years agoAvoid some "unused" warnings during compilation 451/head
Peter Stamfest [Wed, 5 Mar 2014 19:51:52 +0000 (20:51 +0100)] 
Avoid some "unused" warnings during compilation

11 years agoAllow to ask for continuing tests for intergration testing
Peter Stamfest [Wed, 5 Mar 2014 19:48:38 +0000 (20:48 +0100)] 
Allow to ask for continuing tests for intergration testing

11 years agoSecond round of refactoring: Ripping apart rrd_modify_r into more digestable
Peter Stamfest [Wed, 5 Mar 2014 18:58:17 +0000 (19:58 +0100)] 
Second round of refactoring: Ripping apart rrd_modify_r into more digestable
pieces.

11 years agoRefactoring
Peter Stamfest [Wed, 5 Mar 2014 17:01:51 +0000 (18:01 +0100)] 
Refactoring
 - rename variables
 - modularize rrd_modify_r function (it really is a mess, right now...)