Peter A. Bigot [Tue, 20 May 2014 15:59:07 +0000 (10:59 -0500)]
rrdcached: support new option to listen on all addresses at default port
This functionality can be achieved with "-l ''" (specifying an empty
string for host:port) but empty strings may be dropped during option
processing in scripts. A separate option to support this capability is
much more clear.
Peter A. Bigot [Tue, 20 May 2014 15:08:15 +0000 (10:08 -0500)]
rrd_daemon: move include of arpa/inet.h to avoid use on Windows
arpa/inet.h may not be available on Windows systems; since I can't test
that, avoid trying to include it there. Since the code that depends on
it is conditional on a define that would be provided by it, there should
be no impact from its absence except that somebody who uses Windows
would have to rework the fix for ipv4-over-ipv6 for that platform.
Peter A. Bigot [Mon, 19 May 2014 19:47:44 +0000 (14:47 -0500)]
rrdcached: support wildcard listen specifications
The documentation suggested that the syntax "-l :42217" would cause the
daemon to listen on all available interfaces. The implementation didn't
follow through, until now.
Peter A. Bigot [Mon, 19 May 2014 18:09:21 +0000 (13:09 -0500)]
librrd.sym: add rrd_scaled_duration
This librrd function was found when linking executables where main() was
in a libtool convenience library, but not when linking rrdcached. The
solution is to add it into the secret file that specifies which files
are part of the public API.
Peter A. Bigot [Sat, 17 May 2014 21:21:34 +0000 (16:21 -0500)]
etc: rename sysv init scripts to denote RedHat environment dependency
These example scripts will only work on RedHat-based distributions that
support chkconfig and /etc/init.d/functions. They are not compatible
with current Linux Standard Base init scripts.
moli [Mon, 19 May 2014 08:39:37 +0000 (10:39 +0200)]
mods of #477 fixing help example and trying to fix anchors
rrdtool help example was clarified
and i'm trying to fix the html anchor here, but dont know how could i check if it's working or not. Googled and read http://perldoc.perl.org/perlpodspec.html still dont have a clue what does it say.
Peter A. Bigot [Sat, 17 May 2014 20:57:27 +0000 (15:57 -0500)]
make distcheck: complete updates required for support
Rework the tests so they can run in a situation where the source tests
directory is read-only. Also fix a couple minor issues with make
distclean and make distuninstallcheck.
Peter A. Bigot [Sat, 17 May 2014 20:05:53 +0000 (15:05 -0500)]
automake: full support for make check
Presence of the TESTS variable adds check as a target, but for this to
work completely all the test infrastructure needs to be part of the
distribution package, which is easiest if there's a Makefile.am in that
directory.
Peter A. Bigot [Sat, 17 May 2014 19:25:18 +0000 (14:25 -0500)]
automake: rework for separated builds
Standard practice (including the assumptions of make distcheck) is that
the system can be built in an out-of-tree directory referencing sources
in a read-only filesystem. The language-specific bindings build
infrastructure, particularly for perl, makes that difficult but
achievable.
Peter A. Bigot [Sat, 17 May 2014 12:42:26 +0000 (07:42 -0500)]
autoconf: rework config file locations
If we assume somebody puts the src directory in the include file path to
CC, we don't need relative symlinks to rrd_config.h which will make
separated builds much easier to support. Then we don't need to have the
config files in the root directory and symlinks back and forth between
there and src.
Peter A. Bigot [Sat, 17 May 2014 12:10:50 +0000 (07:10 -0500)]
automake: update dist checks for recent changes
Various files have been added and removed causing the dist and distcheck
Make targets to fail. This commit fixes dist; distcheck is improved but
is not complete because the bindings Makefile.am assumes the build is
performed in the source tree. (Standard autotool practice now is to
require support for separated builds.)
Peter A. Bigot [Fri, 16 May 2014 15:52:49 +0000 (10:52 -0500)]
rrd_scaled_duration: refactor as utility function
Move the infrastructure supporting expression of counts and durations by
suffixed integers into librrd where it can be used by other programs.
Clean up the documentation to remove redundancies.
Peter A. Bigot [Fri, 16 May 2014 14:42:49 +0000 (09:42 -0500)]
cleanup: fix make distclean in doc
RRD*.pod were in the repository, but were always generated and were
removed by "make distclean", resulting in an unexpected response from
"git status". Resolve this by removing them from the repository.
Also eliminate the wildcards from CLEANFILES, instead explicitly listing
all derived files.
Also add a couple files to EXTRADIST (PDF documentation and the RRD*.pod
files).
Peter A. Bigot [Fri, 16 May 2014 14:16:19 +0000 (09:16 -0500)]
cleanup: remove compiler warnings
Eliminate the cause of several diagnostics emitted by gcc 4.6.3 and
4.9.0:
- index, time, tmpfile, optind, and remove are all globally-visible
symbols that were shadowed by local declarations
- time_t may be a signed type, resulting in a signed/unsigned comparison
warning from an operation in rrd_xport
- bypass declarations of variables not referenced due to DISABLE_FLOCK
Peter A. Bigot [Fri, 16 May 2014 11:09:48 +0000 (06:09 -0500)]
rrdcreate: improve scale support
- Fix missed diagnostic for negative values accepted by strtoul.
- Add detailed diagnostics for parsing failures.
- Add diagnostic when duration-based RRA steps (rows) are not multiples of
PDP interval (RRA span).
- Fix row count when PDP interval not one second.
- Extend documentation to special-function RRA example.
Martin Sperl [Tue, 6 May 2014 20:12:44 +0000 (20:12 +0000)]
added PREDICTPERC function
there is one still open question: should we interpolate to get the final value?
Say: if we have 8 values, and we want thd 95th percventile, then
we should actually take the 6.65th 0-based index value (=95/100*(8-1)).
with the current implementation we round, so we return actually the 100th percentile.
what we could also do is:
value=val[floor(idx)]+(idx-floor(idx))*(val[floor(idx)+1]-val[floor(idx)])
(besides some boundry checking for the explicit percentile 100)
Martin Sperl [Mon, 5 May 2014 16:18:55 +0000 (16:18 +0000)]
enabled template for rrdcached updates
this essentially "expands" the template to a "normal" update
based on the structure from the file itself.
This structure is cached in a GTree until the process dies - no validation is done to check if the file changed in the meantime
Sebastian Harl [Sat, 26 Apr 2014 09:51:01 +0000 (11:51 +0200)]
src/Makefile: Link rrdcached against ALL_LIBS directly.
rrdcached uses glib and, thus, needs to be linked against the lib directly.
While some linkers work fine since librrd_th is linked against ALL_LIBS, some
other linkers don't.
Peter Stamfest [Mon, 17 Mar 2014 07:39:00 +0000 (08:39 +0100)]
First step to really integrate modify into tune. Currently implemented
by doing all the "tune" conversions in place and doing the "modify"
operations through a temporary RRD file with a followed move to
the original file
Peter Stamfest [Sun, 16 Mar 2014 16:36:23 +0000 (17:36 +0100)]
Fix all usages of setlocale: setlocale might (and on linux DOES)
return a pointer to memory handled internally by libc, calling
setlocale twice and using the data returned from the first call
later on causes access to already free'd memory. This was clearly
seen through valgrind. Eg. use
TESTS_STYLE=valgrind ./tests/tune2
with this cs backed-out and you will see valgrind problems
related to setlocale.