]> git.ipfire.org Git - thirdparty/rspamd.git/log
thirdparty/rspamd.git
9 months agoMerge branch 'rspamd:master' into fix-rbl-check_received 5255/head
teplynin [Sun, 15 Dec 2024 09:54:16 +0000 (12:54 +0300)] 
Merge branch 'rspamd:master' into fix-rbl-check_received

9 months agoUpdate src/plugins/lua/rbl.lua
teplynin [Sun, 15 Dec 2024 09:52:36 +0000 (12:52 +0300)] 
Update src/plugins/lua/rbl.lua

Co-authored-by: Vsevolod Stakhov <vsevolod@rspamd.com>
9 months ago[Minor] Slightly improve logging
Vsevolod Stakhov [Sun, 15 Dec 2024 09:43:04 +0000 (09:43 +0000)] 
[Minor] Slightly improve logging

9 months ago[CritFix] Allow to reupload scripts when Redis is restarted
Vsevolod Stakhov [Sun, 15 Dec 2024 09:29:07 +0000 (09:29 +0000)] 
[CritFix] Allow to reupload scripts when Redis is restarted

Issue: #5256

9 months agoSkipping check_received function for ip address if RBL use botch checks, 'from' and...
Mike Teplynin [Fri, 13 Dec 2024 17:20:15 +0000 (20:20 +0300)] 
Skipping check_received function for ip address if RBL use botch checks, 'from' and 'received'

9 months agoSkip extra RBL checks when Received IP same as From IP
Mike Teplynin [Fri, 13 Dec 2024 09:14:01 +0000 (12:14 +0300)] 
Skip extra RBL checks when Received IP same as From IP

9 months ago[Fix] Fix usage of the logging function
Vsevolod Stakhov [Thu, 12 Dec 2024 17:59:20 +0000 (17:59 +0000)] 
[Fix] Fix usage of the logging function

9 months agoMerge pull request #5254 from rspamd/vstakhov-phishing-fixes
Vsevolod Stakhov [Thu, 12 Dec 2024 11:54:01 +0000 (17:54 +0600)] 
Merge pull request #5254 from rspamd/vstakhov-phishing-fixes

Fix phishing symbol for the same domains

9 months ago[Minor] Replace rspamd_logger.debugm with proper lua_util.debugm 5254/head
Vsevolod Stakhov [Thu, 12 Dec 2024 11:27:36 +0000 (11:27 +0000)] 
[Minor] Replace rspamd_logger.debugm with proper lua_util.debugm

9 months ago[Fix] Phishing: Fix many cases of FP for the same domains
Vsevolod Stakhov [Thu, 12 Dec 2024 11:06:12 +0000 (11:06 +0000)] 
[Fix] Phishing: Fix many cases of FP for the same domains

9 months ago[Fix] Remove USPOOF_SINGLE_SCRIPT_CONFUSABLE from the checks
Vsevolod Stakhov [Thu, 12 Dec 2024 11:05:14 +0000 (11:05 +0000)] 
[Fix] Remove USPOOF_SINGLE_SCRIPT_CONFUSABLE from the checks

In fact, it just checks if string1 and string2 intersect or not, and
it is definitely not the check we want there.

9 months ago[Rework] Multimap should use only distinct text parts for content matching
Vsevolod Stakhov [Wed, 11 Dec 2024 13:55:03 +0000 (13:55 +0000)] 
[Rework] Multimap should use only distinct text parts for content matching

Issue: #5248

9 months ago[Feature] GPT: Try harder to find JSON in NN reply
Vsevolod Stakhov [Tue, 10 Dec 2024 15:09:07 +0000 (15:09 +0000)] 
[Feature] GPT: Try harder to find JSON in NN reply

9 months ago[Minor] GPT: use lua_mime routine to select text part
Vsevolod Stakhov [Tue, 10 Dec 2024 14:57:22 +0000 (14:57 +0000)] 
[Minor] GPT: use lua_mime routine to select text part

9 months ago[Minor] GPT: add `allow_passthrough` and `allow_ham` settings
Vsevolod Stakhov [Tue, 10 Dec 2024 14:22:22 +0000 (14:22 +0000)] 
[Minor] GPT: add `allow_passthrough` and `allow_ham` settings

9 months ago[Test] Breaking: dynamic symbols also require `score` to be set
Vsevolod Stakhov [Tue, 10 Dec 2024 13:45:58 +0000 (13:45 +0000)] 
[Test] Breaking: dynamic symbols also require `score` to be set

Issue: #5247

9 months agoMerge pull request #5241 from moisseev/webui
Vsevolod Stakhov [Tue, 10 Dec 2024 13:16:21 +0000 (19:16 +0600)] 
Merge pull request #5241 from moisseev/webui

[WebUI] Rework symbol description display on hover

9 months agoMerge pull request #5251 from rspamd/vstakhov-cumulative-tcp-timeout
Vsevolod Stakhov [Tue, 10 Dec 2024 12:55:09 +0000 (18:55 +0600)] 
Merge pull request #5251 from rspamd/vstakhov-cumulative-tcp-timeout

[Fix] Use cumulative timeout when dealing with TCP connections

9 months agoMerge pull request #5252 from moisseev/set_pre_result
Vsevolod Stakhov [Tue, 10 Dec 2024 12:54:13 +0000 (18:54 +0600)] 
Merge pull request #5252 from moisseev/set_pre_result

[Minor] Add missing action descriptions

9 months ago[Minor] Use `rule.score` when using dynamic symbols
Vsevolod Stakhov [Tue, 10 Dec 2024 12:50:53 +0000 (12:50 +0000)] 
[Minor] Use `rule.score` when using dynamic symbols

Issue: #5247

9 months ago[Minor] Add missing action descriptions 5252/head
Alexander Moisseev [Tue, 10 Dec 2024 12:02:24 +0000 (15:02 +0300)] 
[Minor] Add missing action descriptions

9 months agoMerge pull request #5240 from rspamd/vstakhov-anonymize-mime
Vsevolod Stakhov [Tue, 10 Dec 2024 11:46:13 +0000 (17:46 +0600)] 
Merge pull request #5240 from rspamd/vstakhov-anonymize-mime

Add tool to anonymize messages content

9 months ago[Minor] Some adjustments 5240/head
Vsevolod Stakhov [Tue, 10 Dec 2024 11:36:41 +0000 (11:36 +0000)] 
[Minor] Some adjustments

9 months ago[Minor] Make urls and emails unique
Vsevolod Stakhov [Mon, 9 Dec 2024 15:25:26 +0000 (15:25 +0000)] 
[Minor] Make urls and emails unique

9 months ago[Minor] Fix urls path issue
Vsevolod Stakhov [Mon, 9 Dec 2024 15:23:05 +0000 (15:23 +0000)] 
[Minor] Fix urls path issue

9 months ago[Fix] Some fixes to `rspamadm ratelimit`
Vsevolod Stakhov [Mon, 9 Dec 2024 14:25:33 +0000 (14:25 +0000)] 
[Fix] Some fixes to `rspamadm ratelimit`

9 months ago[Fix] Use cumulative timeout when dealing with TCP connections 5251/head
Vsevolod Stakhov [Mon, 9 Dec 2024 12:49:19 +0000 (12:49 +0000)] 
[Fix] Use cumulative timeout when dealing with TCP connections

9 months ago[Feature] Add include/exclude logic for headers
Vsevolod Stakhov [Sat, 7 Dec 2024 16:48:55 +0000 (16:48 +0000)] 
[Feature] Add include/exclude logic for headers

9 months agoMerge pull request #5249 from rspamd/vstakhov-fix-upstreams-rota
Vsevolod Stakhov [Sat, 7 Dec 2024 16:23:21 +0000 (22:23 +0600)] 
Merge pull request #5249 from rspamd/vstakhov-fix-upstreams-rota

[Feature] Improve address rotation algorithm

9 months ago[Feature] Improve address rotation algorithm 5249/head
Vsevolod Stakhov [Sat, 7 Dec 2024 15:43:55 +0000 (15:43 +0000)] 
[Feature] Improve address rotation algorithm

We apply the following algorithm:
1) Get the current element and it's AF
2) If the next element has the same AF, then we just move to the next element
3) If the next element has different AF, then we should find the next element with the same AF
4) If we cannot find such element, then we return the next element (switching AF)

9 months agoMerge pull request #5216 from left-try/issue#5148
Vsevolod Stakhov [Sat, 7 Dec 2024 11:08:28 +0000 (17:08 +0600)] 
Merge pull request #5216 from left-try/issue#5148

Add `rspamadm` tool to manage last ratelimit hits

9 months agoMerge branch 'master' into issue#5148 5216/head
Vsevolod Stakhov [Sat, 7 Dec 2024 10:17:01 +0000 (16:17 +0600)] 
Merge branch 'master' into issue#5148

9 months agoMerge pull request #5243 from rspamd/vstakhov-spf-eyeballs
Vsevolod Stakhov [Fri, 6 Dec 2024 11:06:29 +0000 (17:06 +0600)] 
Merge pull request #5243 from rspamd/vstakhov-spf-eyeballs

[Fix] Fix dealing with happy eyeballs in SPF

9 months agoMerge pull request #5246 from dragoangel/patch-8
Vsevolod Stakhov [Fri, 6 Dec 2024 11:06:19 +0000 (17:06 +0600)] 
Merge pull request #5246 from dragoangel/patch-8

Allow set gzip, keepalive and no_ssl_verify in metadata_exporter module

9 months agoAllow set gzip, keepalive and no_ssl_verify in metadata_exporter module 5246/head
Dmitriy Alekseev [Thu, 5 Dec 2024 20:11:50 +0000 (21:11 +0100)] 
Allow set gzip, keepalive and no_ssl_verify in metadata_exporter module

9 months ago[CritFix] Properly check dynamic keys in fuzzy storage
Vsevolod Stakhov [Thu, 5 Dec 2024 15:24:54 +0000 (15:24 +0000)] 
[CritFix] Properly check dynamic keys in fuzzy storage

9 months ago[Minor] Fix misprint
Vsevolod Stakhov [Thu, 5 Dec 2024 11:43:31 +0000 (11:43 +0000)] 
[Minor] Fix misprint

9 months ago[Minor] Fix jemalloc detection
Vsevolod Stakhov [Wed, 4 Dec 2024 09:48:43 +0000 (09:48 +0000)] 
[Minor] Fix jemalloc detection

9 months ago[Fix] Check DNS limits when resolving MX/PTR records 5243/head
Vsevolod Stakhov [Tue, 3 Dec 2024 12:36:47 +0000 (12:36 +0000)] 
[Fix] Check DNS limits when resolving MX/PTR records

9 months ago[Minor] Restore copyright style
Vsevolod Stakhov [Tue, 3 Dec 2024 12:14:32 +0000 (12:14 +0000)] 
[Minor] Restore copyright style

9 months ago[Fix] Fix dealing with happy eyeballs in SPF
Vsevolod Stakhov [Tue, 3 Dec 2024 12:13:05 +0000 (12:13 +0000)] 
[Fix] Fix dealing with happy eyeballs in SPF

9 months ago[Minor] Try to stringify meta headers
Vsevolod Stakhov [Mon, 2 Dec 2024 14:37:15 +0000 (14:37 +0000)] 
[Minor] Try to stringify meta headers

Issue: #5237

9 months ago[Fix] Use `dkim_signing` for `sign_headers` option
Vsevolod Stakhov [Mon, 2 Dec 2024 14:24:58 +0000 (14:24 +0000)] 
[Fix] Use `dkim_signing` for `sign_headers` option

Issue: #5225

9 months ago[Minor] Some more adjustments
Vsevolod Stakhov [Mon, 2 Dec 2024 13:39:22 +0000 (13:39 +0000)] 
[Minor] Some more adjustments

9 months ago[Feature] Unify displayed part selection
Vsevolod Stakhov [Sat, 30 Nov 2024 14:56:37 +0000 (14:56 +0000)] 
[Feature] Unify displayed part selection

9 months ago[WebUI] Rework symbol description display on hover 5241/head
Alexander Moisseev [Fri, 29 Nov 2024 16:21:58 +0000 (19:21 +0300)] 
[WebUI] Rework symbol description display on hover

- Replaced 'abbr title' with dynamic description display on hover or focus
- Added tabindex for keyboard accessibility
- Improved symbol rendering using template literals for readability

9 months ago[Project] Add tool to rspamadm
Vsevolod Stakhov [Fri, 29 Nov 2024 13:40:11 +0000 (13:40 +0000)] 
[Project] Add tool to rspamadm

9 months ago[Project] Initial stuff to implement messages anonymization
Vsevolod Stakhov [Tue, 26 Nov 2024 17:13:08 +0000 (17:13 +0000)] 
[Project] Initial stuff to implement messages anonymization

9 months agoMerge pull request #5239 from rspamd/vstakhov-simdutf
Vsevolod Stakhov [Fri, 29 Nov 2024 12:15:27 +0000 (18:15 +0600)] 
Merge pull request #5239 from rspamd/vstakhov-simdutf

[Rework] Replace fastutf with simdutf

9 months ago[Test] Fix tests 5239/head
Vsevolod Stakhov [Fri, 29 Nov 2024 12:06:48 +0000 (12:06 +0000)] 
[Test] Fix tests

9 months ago[Minor] Various fixes
Vsevolod Stakhov [Fri, 29 Nov 2024 11:52:32 +0000 (11:52 +0000)] 
[Minor] Various fixes

9 months ago[Rework] Replace fastutf with simdutf
Vsevolod Stakhov [Fri, 29 Nov 2024 11:31:35 +0000 (11:31 +0000)] 
[Rework] Replace fastutf with simdutf

Simdutf is faster and has way better support of the architectures (especially
when it comes to non-x86 stuff). Hence, it is a good idea to use it instead
of the non-supported fastutf8 stuff.

9 months agoMerge pull request #5233 from rspamd/vstakhov-strip-attachments
Vsevolod Stakhov [Tue, 26 Nov 2024 14:05:39 +0000 (20:05 +0600)] 
Merge pull request #5233 from rspamd/vstakhov-strip-attachments

Allow to strip attachments

9 months agoMerge branch 'rspamd:master' into issue#5148
Ivan Stakhov [Tue, 26 Nov 2024 10:33:23 +0000 (13:33 +0300)] 
Merge branch 'rspamd:master' into issue#5148

9 months ago[Project] Various fixes and `rspamadm mime strip` command 5233/head
Vsevolod Stakhov [Mon, 25 Nov 2024 12:23:01 +0000 (12:23 +0000)] 
[Project] Various fixes and `rspamadm mime strip` command

9 months ago[Project] Add routine to strip attachments
Vsevolod Stakhov [Mon, 25 Nov 2024 11:55:25 +0000 (11:55 +0000)] 
[Project] Add routine to strip attachments

9 months agoMerge pull request #5232 from rspamd/vstakhov-fuzzy-limits-display
Vsevolod Stakhov [Mon, 25 Nov 2024 11:19:07 +0000 (17:19 +0600)] 
Merge pull request #5232 from rspamd/vstakhov-fuzzy-limits-display

[Feature] Dump current ratelimits for fuzzy keys

9 months ago[Minor] Do not fail on empty limits 5232/head
Vsevolod Stakhov [Mon, 25 Nov 2024 11:10:17 +0000 (11:10 +0000)] 
[Minor] Do not fail on empty limits

9 months ago[Minor] Some display/adding fixes
Vsevolod Stakhov [Mon, 25 Nov 2024 11:04:53 +0000 (11:04 +0000)] 
[Minor] Some display/adding fixes

9 months ago[Minor] Improve format
Vsevolod Stakhov [Mon, 25 Nov 2024 10:52:38 +0000 (10:52 +0000)] 
[Minor] Improve format

9 months ago[Feature] Show stats in rspamadm
Vsevolod Stakhov [Mon, 25 Nov 2024 10:29:38 +0000 (10:29 +0000)] 
[Feature] Show stats in rspamadm

9 months ago[Feature] Dump current ratelimits for fuzzy keys
Vsevolod Stakhov [Fri, 22 Nov 2024 11:15:57 +0000 (11:15 +0000)] 
[Feature] Dump current ratelimits for fuzzy keys

9 months agoMerge branch 'rspamd:master' into issue#5148
Ivan Stakhov [Wed, 20 Nov 2024 16:53:07 +0000 (19:53 +0300)] 
Merge branch 'rspamd:master' into issue#5148

9 months agoMerge pull request #5223 from rspamd/vstakhov-fix-2047-encode
Vsevolod Stakhov [Mon, 18 Nov 2024 20:39:23 +0000 (02:39 +0600)] 
Merge pull request #5223 from rspamd/vstakhov-fix-2047-encode

Fix RFC 2047 encoding

9 months ago[Fix] Sigh, another fix 5223/head
Vsevolod Stakhov [Mon, 18 Nov 2024 18:43:03 +0000 (18:43 +0000)] 
[Fix] Sigh, another fix

9 months ago[Test] Fix some tests again
Vsevolod Stakhov [Mon, 18 Nov 2024 17:43:00 +0000 (17:43 +0000)] 
[Test] Fix some tests again

9 months ago[Fix] More things to fix
Vsevolod Stakhov [Mon, 18 Nov 2024 17:30:51 +0000 (17:30 +0000)] 
[Fix] More things to fix

9 months ago[Test] Test encode with decode
Vsevolod Stakhov [Mon, 18 Nov 2024 16:51:44 +0000 (16:51 +0000)] 
[Test] Test encode with decode

9 months ago[Test] Rework tests structure
Vsevolod Stakhov [Mon, 18 Nov 2024 16:37:39 +0000 (16:37 +0000)] 
[Test] Rework tests structure

9 months ago[Fix] More fixes to rfc2047 encoding
Vsevolod Stakhov [Mon, 18 Nov 2024 16:31:15 +0000 (16:31 +0000)] 
[Fix] More fixes to rfc2047 encoding

9 months ago[Minor] Some more fixes
Vsevolod Stakhov [Sat, 16 Nov 2024 18:10:12 +0000 (18:10 +0000)] 
[Minor] Some more fixes

9 months ago[Fix] Some more fixes
Vsevolod Stakhov [Sat, 16 Nov 2024 17:46:44 +0000 (17:46 +0000)] 
[Fix] Some more fixes

9 months ago[Rework] Rewrite rfc2047 encoding as it was totally broken
Vsevolod Stakhov [Sat, 16 Nov 2024 15:45:56 +0000 (15:45 +0000)] 
[Rework] Rewrite rfc2047 encoding as it was totally broken

9 months ago[Minor] Get rid of glib utf8 functions
Vsevolod Stakhov [Sat, 16 Nov 2024 14:26:54 +0000 (14:26 +0000)] 
[Minor] Get rid of glib utf8 functions

10 months agoMerge remote-tracking branch 'origin/issue#5148' into issue#5148
left-try [Fri, 15 Nov 2024 23:18:55 +0000 (05:18 +0600)] 
Merge remote-tracking branch 'origin/issue#5148' into issue#5148

10 months ago[Minor] Make unused function used
left-try [Fri, 15 Nov 2024 23:18:45 +0000 (05:18 +0600)] 
[Minor] Make unused function used

10 months agoMerge branch 'rspamd:master' into issue#5148
Ivan Stakhov [Fri, 15 Nov 2024 23:17:44 +0000 (02:17 +0300)] 
Merge branch 'rspamd:master' into issue#5148

10 months ago[Minor] Clean up code and fix some mistakes
left-try [Fri, 15 Nov 2024 23:06:52 +0000 (05:06 +0600)] 
[Minor] Clean up code and fix some mistakes

10 months ago[Fix] Dmarc: Properly encode structured headers
Vsevolod Stakhov [Fri, 15 Nov 2024 09:54:20 +0000 (09:54 +0000)] 
[Fix] Dmarc: Properly encode structured headers

Issue: #5221

10 months ago[Fix] Milter headers: fold before encoding
Vsevolod Stakhov [Fri, 15 Nov 2024 09:00:42 +0000 (09:00 +0000)] 
[Fix] Milter headers: fold before encoding

10 months ago[Minor] Small clean up
left-try [Thu, 14 Nov 2024 03:51:58 +0000 (09:51 +0600)] 
[Minor] Small clean up

10 months ago[Minor] Small clean up for error handling
left-try [Thu, 14 Nov 2024 03:39:20 +0000 (09:39 +0600)] 
[Minor] Small clean up for error handling

10 months agoMerge pull request #5219 from moisseev/elastic-conf
Vsevolod Stakhov [Wed, 13 Nov 2024 12:10:41 +0000 (18:10 +0600)] 
Merge pull request #5219 from moisseev/elastic-conf

[Conf] Fix comments in elastic.conf

10 months agoMerge branch 'rspamd:master' into issue#5148
Ivan Stakhov [Mon, 11 Nov 2024 15:33:51 +0000 (18:33 +0300)] 
Merge branch 'rspamd:master' into issue#5148

10 months ago[Conf] Fix comments in elastic.conf 5219/head
Alexander Moisseev [Mon, 11 Nov 2024 15:24:27 +0000 (18:24 +0300)] 
[Conf] Fix comments in elastic.conf

10 months agoMerge pull request #5162 from left-try/master
Vsevolod Stakhov [Mon, 11 Nov 2024 12:54:51 +0000 (18:54 +0600)] 
Merge pull request #5162 from left-try/master

Store LRU cache of last filled ratelimit buckets

10 months agoMerge pull request #5186 from dragoangel/actualize-elastic-module
Vsevolod Stakhov [Mon, 11 Nov 2024 12:53:52 +0000 (18:53 +0600)] 
Merge pull request #5186 from dragoangel/actualize-elastic-module

[Rework] Breaking: Actualize elastic module

10 months agoMerge pull request #5214 from rspamd/vstakhov-conf-reorg
Vsevolod Stakhov [Mon, 11 Nov 2024 12:06:06 +0000 (18:06 +0600)] 
Merge pull request #5214 from rspamd/vstakhov-conf-reorg

[Conf] Add more ways to extend Rspamd configuration

10 months agoMerge branch 'master' into vstakhov-conf-reorg 5214/head
Vsevolod Stakhov [Sun, 10 Nov 2024 12:11:46 +0000 (18:11 +0600)] 
Merge branch 'master' into vstakhov-conf-reorg

10 months agoMerge pull request #5218 from moisseev/fa6
Vsevolod Stakhov [Sun, 10 Nov 2024 12:11:33 +0000 (18:11 +0600)] 
Merge pull request #5218 from moisseev/fa6

[WebUI] Upgrade Font Awesome to v6.6.0

10 months agoMerge pull request #5217 from moisseev/webui
Vsevolod Stakhov [Sun, 10 Nov 2024 12:11:24 +0000 (18:11 +0600)] 
Merge pull request #5217 from moisseev/webui

[WebUI] Update RequireJS to address CVE-2024-38999

10 months ago[WebUI] Upgrade Font Awesome to v6.6.0 5218/head
Alexander Moisseev [Sat, 9 Nov 2024 15:08:53 +0000 (18:08 +0300)] 
[WebUI] Upgrade Font Awesome to v6.6.0

10 months ago[Conf] Allow to install examples conditionally
Vsevolod Stakhov [Sat, 9 Nov 2024 13:41:02 +0000 (13:41 +0000)] 
[Conf] Allow to install examples conditionally

10 months ago[WebUI] Update RequireJS to address CVE-2024-38999 5217/head
Alexander Moisseev [Sat, 9 Nov 2024 12:40:10 +0000 (15:40 +0300)] 
[WebUI] Update RequireJS to address CVE-2024-38999

Upgraded RequireJS from 2.3.6 to 2.3.7
to mitigate prototype pollution vulnerability (CVE-2024-38999) in `s.contexts._.configure` function,
which could allow arbitrary code execution or Denial of Service.

10 months agoFix missing non_en false due to fill_empty_strings function 5186/head
Dmitriy Alekseev [Fri, 8 Nov 2024 11:30:16 +0000 (12:30 +0100)] 
Fix missing non_en false due to fill_empty_strings function

10 months ago[CI] Add ability to run GA on any push from any branch
left-try [Thu, 7 Nov 2024 12:48:46 +0000 (18:48 +0600)] 
[CI] Add ability to run GA on any push from any branch

10 months ago[Feature] Add ratelimit util to manage last filled ratelimit buckets
left-try [Thu, 7 Nov 2024 12:48:12 +0000 (18:48 +0600)] 
[Feature] Add ratelimit util to manage last filled ratelimit buckets

10 months agoMerge branch 'master' into master 5162/head
Ivan Stakhov [Thu, 7 Nov 2024 07:42:47 +0000 (10:42 +0300)] 
Merge branch 'master' into master

10 months agoMerge pull request #5213 from rspamd/vstakhov-surbl-conf-fix
Vsevolod Stakhov [Wed, 6 Nov 2024 19:02:24 +0000 (01:02 +0600)] 
Merge pull request #5213 from rspamd/vstakhov-surbl-conf-fix

[Conf] Use full hostnames for SURBL

10 months ago[Minor] Fix optionality
Vsevolod Stakhov [Wed, 6 Nov 2024 13:56:56 +0000 (13:56 +0000)] 
[Minor] Fix optionality