fix style

   src/rrd_cgi.c
   src/rrd_create.c
   src/rrd_daemon.c
   src/rrd_dump.c
   src/rrd_fetch.c
   src/rrd_first.c
   src/rrd_flushcached.c
   src/rrd_graph_helper.c
   src/rrd_info.c
   src/rrd_last.c
   src/rrd_lastupdate.c
   src/rrd_update.c

src/rrd_cgi.c: fix Coverity CID#13625 Truncated stdio return value

src/rrd_daemon.c: fix Coverity CID#13627 Unchecked return value from library

        CWE-252 / https://cwe.mitre.org/data/definitions/252.html

src/rrd_fetch_libdbi.c: fix Coverity CID#13630 Unchecked return value

        CWE-252 / https://cwe.mitre.org/data/definitions/252.html

src/rrd_fetch_libdbi.c: fix Coverity CID#13634 Logically dead code

        CWE-561 / https://cwe.mitre.org/data/definitions/561.html

        NOTE: this seems like a copy & paste error; either we compare
        'h1' to (char)-1 in which case the code cannot be reached (the
        same test is already done & it returns from the function), or
        (more likely) it should be 'h2' instead.

src/rrd_daemon.c: fix Coverity CID#13637 Missing unlock

        CWE-667 / https://cwe.mitre.org/data/definitions/667.html

src/rrd_xport.c: fix Coverity CID#13640 Array compared against 0

        CWE-398 / https://cwe.mitre.org/data/definitions/398.html

        (im->gdes[i].legend == 0) doesn't make sense;
        im->gdes[i].legend declared as
          char      legend[FMT_LEG_LEN + 5];  /* legend */

        NOTE: fix to be checked to ensure it conserves the intended functionality.

src/rrd_graph_helper.c: fix Coverity CIDs#13641,#13642 Dereference null return value

        CWE-476 / https://cwe.mitre.org/data/definitions/476.html

bindings/perl-shared/RRDs.xs: fix Coverity CID#13647 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_cgi.c: fix Coverity CID#13652 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_cgi.c: fix Coverity CID#13654 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_cgi.c: fix Coverity CID#13655 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_daemon.c: fix Coverity CIDs#13659,#13660 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_hw.c: fix Coverity CIDs#13664,#13665 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_open.c: fix Coverity CID#13666 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_xport.c: fix Coverity CIDs#13670,#13671 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_daemon.c: fix Coverity CID#13672 Pointer to local outside scope

        CWE-562 / https://cwe.mitre.org/data/definitions/562.html

src/rrd_graph_helper.c: fix Coverity CID#13675 Dereference before null check

        CWE-476 / https://cwe.mitre.org/data/definitions/476.html

src/rrd_open.c: fix Coverity CID#13676 Dereference before null check

        CWE-476 / https://cwe.mitre.org/data/definitions/476.html

src/rrd_utils.c: fix Coverity CID#13677 Sizeof not portable

        CWE-467 / https://cwe.mitre.org/data/definitions/467.html

src/rrd_fetch_libdbi.c: fix Coverity CID#13678 Copy into fixed size buffer (buffer overflow)

        CWE-120 / https://cwe.mitre.org/data/definitions/120.html

src/rrd_parsetime.c: fix Coverity CID#13692 Missing varargs init or cleanup

        CWE-573 / https://cwe.mitre.org/data/definitions/573.html

src/rrd_client.c: fix Coverity CID#17400 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

        + possible segfault when accessing res->message and res == NULL

src/rrd_client.c: fix Coverity CID#17401 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_xport.c: fix Coverity CID#23524 Uninitialized scalar variable

        CWE-457 / https://cwe.mitre.org/data/definitions/457.html

src/rrd_fetch_libdbi.c: fix Coverity CID#26513 Buffer not null terminated

        CWE-170 / https://cwe.mitre.org/data/definitions/170.html

src/rrd_graph.c: fix Coverity CID#26514 Buffer not null terminated

        CWE-170 / https://cwe.mitre.org/data/definitions/170.html

src/rrd_flushcached.c: fix Coverity CID#26516 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_lastupdate.c: fix Coverity CID#26518 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_graph_helper.c: fix Coverity CID#26523 Buffer not null terminated

        CWE-170 / https://cwe.mitre.org/data/definitions/170.html

src/rrd_fetch.c: fix Coverity CID#26524 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_daemon.c: fix Coverity CID#26525 Buffer not null terminated

        CWE-170 / https://cwe.mitre.org/data/definitions/170.html

src/rrd_graph_helper.c: fix Coverity CID#26527 Buffer not null terminated

        CWE-170 / https://cwe.mitre.org/data/definitions/170.html

src/rrd_first.c: fix Coverity CID#26528 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_create.c: fix Coverity CID#26529 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_last.c: fix Coverity CID#26531 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_update.c: fix Coverity CID#26532 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_dump.c: fix Coverity CID#26534 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_info.c: fix Coverity CID#26535 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_cgi.c: fix Coverity CIDs#17398,#13656 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_cgi.c: fix Coverity CID#13656 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_daemon.c: fix Coverity CID#32399 Buffer not null terminated

        CWE-170 / https://cwe.mitre.org/data/definitions/170.html

src/rrd_create.c: fix Coverity CID#32400 Buffer not null terminated

        CWE-170 / https://cwe.mitre.org/data/definitions/170.html

src/rrd_graph_helper.c: fix Coverity CID#32401 Buffer not null terminated

        CWE-170 / https://cwe.mitre.org/data/definitions/170.html

src/rrd_open.c: fix Coverity CID#32402 Unchecked return value from library

        CWE-252 / https://cwe.mitre.org/data/definitions/252.html

src/rrd_modify.c: fix Coverity CID#32405 Logically dead code

        CWE-561 / https://cwe.mitre.org/data/definitions/561.html

src/rrd_modify.c: fix Coverity CID#32406 Logically dead code

        CWE-561 / https://cwe.mitre.org/data/definitions/561.html

        Either
                finalout = rrd_modify_structure == NULL => goto done;
        or
                finalout = rrd_modify_structure != NULL => rc = 0;

src/rrd_daemon.c: fix Coverity CID#32408 Missing unlock

        CWE-667 / https://cwe.mitre.org/data/definitions/667.html

src/rrd_client.c: fix Coverity CID#32409 Missing unlock

        CWE-667 / https://cwe.mitre.org/data/definitions/667.html

src/rrd_daemon.c: fix Coverity CID#32412 Nesting level does not match indentation

        CWE-483 / https://cwe.mitre.org/data/definitions/483.html

src/rrd_graph.c: fix Coverity CID#32414 Array compared against 0

        CWE-398 / https://cwe.mitre.org/data/definitions/398.html

        'im' declared as:      image_desc_t *im
        im->gdes[i] is:        graph_desc_t *gdes; /* points to an array of graph elements */
        im->gdes[i].format is: char format[FMT_LEG_LEN + 5];  /* format for PRINT AND GPRINT */

        Comparing a stack variable to NULL doesn't make sense.

src/rrd_daemon.c: fix Coverity CIDs#32415,#26519 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_daemon.c: fix Coverity CID#32416 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_daemon.c: fix Coverity CID#32417 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_daemon.c: fix Coverity CIDs#32418,#32419 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_daemon.c: fix Coverity CIDs#32420,#26530 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_daemon.c: fix Coverity CID#32421 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_create.c: fix Coverity CID#32422 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_tune.c: fix Coverity CID#32424 Improper use of negative value

        CWE-394 / https://cwe.mitre.org/data/definitions/394.html

        Note: optparse_init() and optparse_long() which can modify the
        'options' variable in rrd_tune() can never set options.optind
        to a negative value.

src/rrd_create.c: fix Coverity CID#32425 Insecure temporary file

        CWE-377 / https://cwe.mitre.org/data/definitions/377.html

src/rrd_modify.c: fix Coverity CID#32426 Copy into fixed size buffer

        CWE-120 / https://cwe.mitre.org/data/definitions/120.html

src/rrd_create.c: fix Coverity CID#32427 Copy into fixed size buffer (buffer overflow)

        CWE-120 / https://cwe.mitre.org/data/definitions/120.html

bindings/perl-shared/RRDs.xs: fix Coverity CID#32428 Uninitialized pointer read

        CWE-457 / https://cwe.mitre.org/data/definitions/457.html

src/rrd_create.c: fix Coverity CID#32429 Uninitialized pointer read

        CWE-457 / https://cwe.mitre.org/data/definitions/457.html

src/rrd_tune.c: fix Coverity CID#32430 Uninitialized pointer read

        CWE-457 / https://cwe.mitre.org/data/definitions/457.html

Merge pull request #710 from nirgal/patch-4

 CHANGES about supported lua versions

nagle not nagel

Merge branch 'master' of github.com:oetiker/rrdtool-1.x

fix release number

Merge pull request #712 from gitter-badger/gitter-badge-1

Add a Gitter chat badge to README.md

Add Gitter badge

 CHANGES about supported lua versions

lua 5.1 already was supported.
What version 1.6.0 brings is lua 5.2 and lua 5.3 support.

travis-link

prep master for new checkins

remove extra spaces

fix for #707

ignore all so files in tcl

Merge pull request #708 from oetiker/new-calc

a bunch of new RPN functions coming up for 1.6

fix expected results

add new RPN functions: AVG, SMIN, SMAX, STDEV, POW, MEDIAN

Merge pull request #706 from stevenh/disable-nagle

Disable nagel algorithm

Disable nagel algorithm

Disable TCP's nagal algorithm which was causing massive slowdown
in processing rrdcached requests.

Also check for other setsockopt call errors.

Merge pull request #703 from nirgal/verbose_tests

Fixed tests when VERBOSE is on

Fixed tests when VERBOSE is on

Define RRDTOOL_V from RRDTOOL, but only after RRDTOOL is defined.
Output the header showing witch command is run on stderr, not stdout.

make the vnames in the test a bit more interesting ... especially verify that having a - and numbers in the vname is fine

re allow - in vnames since it seems to have worked for some in 1.4

added rpn1.output

Merge branch 'master' of github.com:oetiker/rrdtool-1.x

- is not allowed in vnames!

Merge pull request #694 from nirgal/patch-1

Minor spelling in documetation

make sure people don't confuse the MASTER branche with the 1.5 branche ...

Merge pull request #696 from jskiba99/fix-typo

Fix spelling typos

Fix spelling typos

Minor spelling in documetation

Merge pull request #693 from ntyni/master

Use memmove instead of memcpy in rrd_write() to fix undefined behaviour

Use memmove instead of memcpy in rrd_write() to fix undefined behaviour

At least rrdtune ends up calling rrd_write() with the same memory
area for the source and the destination, causing undefined behaviour
that has been observed to actually break on the mips architecture.

Bug-Debian: https://bugs.debian.org/805391
Bug: https://github.com/oetiker/rrdtool-1.x/issues/688

Merge pull request #692 from RomeroMalaquias/master

Avoiding conditional directives that split up parts of statements.

Avoiding conditional directives that split up parts of statements.

--use-mirrors is not supported anymore

Merge pull request #691 from pocek/typo

doc: Fix a typo in an example