]>
git.ipfire.org Git - thirdparty/rrdtool-1.x.git/log
Marek Schimara [Wed, 31 Aug 2016 12:35:49 +0000 (14:35 +0200)]
tests/: adds list1 'rrdtool list' test script
Marek Schimara [Tue, 30 Aug 2016 15:06:28 +0000 (17:06 +0200)]
src/rrd_daemon.c,src/rrd_list.c: moves LIST-specific code into rrd_list_r
Marek Schimara [Thu, 25 Aug 2016 14:35:49 +0000 (16:35 +0200)]
src/rrd_list.c: fix option handling
Marek Schimara [Thu, 25 Aug 2016 08:19:54 +0000 (10:19 +0200)]
src/rrd_daemon.c: adds symlink check for the 'LIST' command
make sure we aren't following a symlink pointing outside of
base_dir
Marek Schimara [Wed, 24 Aug 2016 13:20:43 +0000 (15:20 +0200)]
doc: adds documentation for the LIST command
Sebastien Dugue [Fri, 13 Feb 2015 09:29:36 +0000 (10:29 +0100)]
Perl shared bindings: Add bindings for the LIST command
Sebastien Dugue [Thu, 30 Oct 2014 08:33:26 +0000 (09:33 +0100)]
Python bindings: Add bindings for the LIST command
Sebastien Dugue [Tue, 28 Oct 2014 14:37:03 +0000 (15:37 +0100)]
rrd_daemon: Add LIST command to list the rrd databases
Tobias Oetiker [Wed, 24 Aug 2016 09:34:23 +0000 (11:34 +0200)]
Merge pull request #732 from Marek77/pr_mkdir
Fix "mkdir -p"
Tobias Oetiker [Wed, 24 Aug 2016 08:41:24 +0000 (10:41 +0200)]
Merge pull request #731 from Marek77/pr_loglevel
rrdcached: Adds CLI option '-V log_level'
Jean-Vincent Ficet [Tue, 10 Feb 2015 15:39:18 +0000 (16:39 +0100)]
rrd_daemon: Log strerror(errno) when rrd_mkdir_p() fails
Log strerror(errno) when rrd_mkdir_p() fails in order to know what went wrong
from a client application perspective.
In this particular case, rrd_mkdir_p failed due to the lack of inodes.
Sending a message with 'No Space left on device' allowed the application
to limit the logs in the code in charge of handling the
RRDTOOL_FILESYSTEM_FULL error, rather than flooding the logs with all
the failed queries.
Jean-Vincent Ficet [Mon, 9 Feb 2015 15:26:00 +0000 (16:26 +0100)]
rrd_utils: Fix broken recusive directory creation in multithreaded context
Multithreaded applications can issue CREATE commands simultaneously
from several threads. Such commands may require to create directories
from the same root path.
Example:
Thread #1 creates /var/cache/rrd/data/switch/isw61/board0/chip1/port1
Thread #2 creates /var/cache/rrd/data/switch/isw61/board0/chip1/port3
If 2 threads attempt to create the above directories, one thread may
fail when creating a directory already created by the other thread.
The mkdir syscall fails with an error (errno = EEXIST), which causes
the whole CREATE transaction to fail.
Fixed by checking errno after invoking mkdir when creating
directories recursively.
Marek Schimara [Wed, 24 Aug 2016 08:00:58 +0000 (10:00 +0200)]
doc/rrdcached.pod: adds description of the '-V log_level' CLI option
Tobias Oetiker [Wed, 24 Aug 2016 07:28:27 +0000 (09:28 +0200)]
Merge pull request #730 from Marek77/pr_acinclude
m4/acinclude.m4: fix for build error 'possibly undefined macro: AS_VAR_COPY
Tobias Oetiker [Tue, 23 Aug 2016 14:19:20 +0000 (16:19 +0200)]
Merge pull request #729 from Marek77/pr_fallocate
src/rrd_open.c: fix crash (SIGBUS) trying to CREATE a rrd on a full fs
Marek Schimara [Fri, 24 Jun 2016 08:27:55 +0000 (10:27 +0200)]
src/rrd_daemon.c: adds option '-V LOGLEVEL'
Default log level when this flag is NOT present: LOG_ERR
Marek Schimara [Wed, 22 Jun 2016 08:41:25 +0000 (10:41 +0200)]
m4/acinclude.m4: fix for build error 'possibly undefined macro: AS_VAR_COPY'
This happens with autoconf 2.63 or older (RHEL 6)
Marek Schimara [Thu, 12 Sep 2013 11:57:50 +0000 (13:57 +0200)]
src/rrd_open.c: fix crash (SIGBUS) trying to CREATE a rrd on a full filesystem
Condition (posix_fallocate(rrd_simple_file->fd, 0, newfile_size) == -1)
is always FALSE so this check passes all the time.
See man posix_fallocate()
Tobias Oetiker [Thu, 14 Jul 2016 11:26:58 +0000 (13:26 +0200)]
Merge pull request #716 from Marek77/master_coverity
Master coverity
Tobias Oetiker [Thu, 14 Jul 2016 11:26:42 +0000 (13:26 +0200)]
Merge pull request #723 from N3WWN/master
FIX for Issue 695 - master branch
Rich Alloway [Wed, 13 Jul 2016 12:50:00 +0000 (08:50 -0400)]
FIX for Issue 695 - master branch
Tobias Oetiker [Tue, 5 Jul 2016 15:00:38 +0000 (17:00 +0200)]
Merge pull request #715 from itensionanders/coords
Output legend coords, for making img map
Anders Björklund [Sun, 26 Jun 2016 11:53:02 +0000 (13:53 +0200)]
Show legend coords in graphv, for making img map
Anders Björklund [Sun, 26 Jun 2016 11:53:02 +0000 (13:53 +0200)]
Add gfx_get_text_height function, to match width
Marek Schimara [Mon, 27 Jun 2016 09:04:37 +0000 (11:04 +0200)]
fix style
src/rrd_cgi.c
src/rrd_create.c
src/rrd_daemon.c
src/rrd_dump.c
src/rrd_fetch.c
src/rrd_first.c
src/rrd_flushcached.c
src/rrd_graph_helper.c
src/rrd_info.c
src/rrd_last.c
src/rrd_lastupdate.c
src/rrd_update.c
Marek Schimara [Fri, 17 Jun 2016 11:40:08 +0000 (13:40 +0200)]
src/rrd_cgi.c: fix Coverity CID#13625 Truncated stdio return value
Marek Schimara [Fri, 17 Jun 2016 11:33:55 +0000 (13:33 +0200)]
src/rrd_daemon.c: fix Coverity CID#13627 Unchecked return value from library
CWE-252 / https://cwe.mitre.org/data/definitions/252.html
Marek Schimara [Fri, 17 Jun 2016 11:27:07 +0000 (13:27 +0200)]
src/rrd_fetch_libdbi.c: fix Coverity CID#13630 Unchecked return value
CWE-252 / https://cwe.mitre.org/data/definitions/252.html
Marek Schimara [Fri, 17 Jun 2016 11:19:43 +0000 (13:19 +0200)]
src/rrd_fetch_libdbi.c: fix Coverity CID#13634 Logically dead code
CWE-561 / https://cwe.mitre.org/data/definitions/561.html
NOTE: this seems like a copy & paste error; either we compare
'h1' to (char)-1 in which case the code cannot be reached (the
same test is already done & it returns from the function), or
(more likely) it should be 'h2' instead.
Marek Schimara [Fri, 17 Jun 2016 11:16:50 +0000 (13:16 +0200)]
src/rrd_daemon.c: fix Coverity CID#13637 Missing unlock
CWE-667 / https://cwe.mitre.org/data/definitions/667.html
Marek Schimara [Fri, 17 Jun 2016 11:08:27 +0000 (13:08 +0200)]
src/rrd_xport.c: fix Coverity CID#13640 Array compared against 0
CWE-398 / https://cwe.mitre.org/data/definitions/398.html
(im->gdes[i].legend == 0) doesn't make sense;
im->gdes[i].legend declared as
char legend[FMT_LEG_LEN + 5]; /* legend */
NOTE: fix to be checked to ensure it conserves the intended functionality.
Marek Schimara [Fri, 17 Jun 2016 11:01:40 +0000 (13:01 +0200)]
src/rrd_graph_helper.c: fix Coverity CIDs#13641,#13642 Dereference null return value
CWE-476 / https://cwe.mitre.org/data/definitions/476.html
Marek Schimara [Fri, 17 Jun 2016 09:28:17 +0000 (11:28 +0200)]
bindings/perl-shared/RRDs.xs: fix Coverity CID#13647 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Fri, 17 Jun 2016 09:17:51 +0000 (11:17 +0200)]
src/rrd_cgi.c: fix Coverity CID#13652 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Fri, 17 Jun 2016 09:09:28 +0000 (11:09 +0200)]
src/rrd_cgi.c: fix Coverity CID#13654 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Fri, 17 Jun 2016 08:54:29 +0000 (10:54 +0200)]
src/rrd_cgi.c: fix Coverity CID#13655 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Fri, 17 Jun 2016 08:38:22 +0000 (10:38 +0200)]
src/rrd_daemon.c: fix Coverity CIDs#13659,#13660 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Fri, 17 Jun 2016 08:15:31 +0000 (10:15 +0200)]
src/rrd_hw.c: fix Coverity CIDs#13664,#13665 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Fri, 17 Jun 2016 08:10:05 +0000 (10:10 +0200)]
src/rrd_open.c: fix Coverity CID#13666 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Fri, 17 Jun 2016 08:04:46 +0000 (10:04 +0200)]
src/rrd_xport.c: fix Coverity CIDs#13670,#13671 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Fri, 17 Jun 2016 07:52:55 +0000 (09:52 +0200)]
src/rrd_daemon.c: fix Coverity CID#13672 Pointer to local outside scope
CWE-562 / https://cwe.mitre.org/data/definitions/562.html
Marek Schimara [Fri, 17 Jun 2016 07:47:25 +0000 (09:47 +0200)]
src/rrd_graph_helper.c: fix Coverity CID#13675 Dereference before null check
CWE-476 / https://cwe.mitre.org/data/definitions/476.html
Marek Schimara [Fri, 17 Jun 2016 07:45:28 +0000 (09:45 +0200)]
src/rrd_open.c: fix Coverity CID#13676 Dereference before null check
CWE-476 / https://cwe.mitre.org/data/definitions/476.html
Marek Schimara [Fri, 17 Jun 2016 07:40:47 +0000 (09:40 +0200)]
src/rrd_utils.c: fix Coverity CID#13677 Sizeof not portable
CWE-467 / https://cwe.mitre.org/data/definitions/467.html
Marek Schimara [Fri, 17 Jun 2016 07:37:46 +0000 (09:37 +0200)]
src/rrd_fetch_libdbi.c: fix Coverity CID#13678 Copy into fixed size buffer (buffer overflow)
CWE-120 / https://cwe.mitre.org/data/definitions/120.html
Marek Schimara [Fri, 17 Jun 2016 07:19:54 +0000 (09:19 +0200)]
src/rrd_parsetime.c: fix Coverity CID#13692 Missing varargs init or cleanup
CWE-573 / https://cwe.mitre.org/data/definitions/573.html
Marek Schimara [Fri, 17 Jun 2016 06:44:29 +0000 (08:44 +0200)]
src/rrd_client.c: fix Coverity CID#17400 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
+ possible segfault when accessing res->message and res == NULL
Marek Schimara [Thu, 16 Jun 2016 14:51:13 +0000 (16:51 +0200)]
src/rrd_client.c: fix Coverity CID#17401 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Thu, 16 Jun 2016 14:09:00 +0000 (16:09 +0200)]
src/rrd_xport.c: fix Coverity CID#23524 Uninitialized scalar variable
CWE-457 / https://cwe.mitre.org/data/definitions/457.html
Marek Schimara [Thu, 16 Jun 2016 13:57:27 +0000 (15:57 +0200)]
src/rrd_fetch_libdbi.c: fix Coverity CID#26513 Buffer not null terminated
CWE-170 / https://cwe.mitre.org/data/definitions/170.html
Marek Schimara [Thu, 16 Jun 2016 13:54:17 +0000 (15:54 +0200)]
src/rrd_graph.c: fix Coverity CID#26514 Buffer not null terminated
CWE-170 / https://cwe.mitre.org/data/definitions/170.html
Marek Schimara [Thu, 16 Jun 2016 13:49:32 +0000 (15:49 +0200)]
src/rrd_flushcached.c: fix Coverity CID#26516 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Thu, 16 Jun 2016 13:43:55 +0000 (15:43 +0200)]
src/rrd_lastupdate.c: fix Coverity CID#26518 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Thu, 16 Jun 2016 13:35:22 +0000 (15:35 +0200)]
src/rrd_graph_helper.c: fix Coverity CID#26523 Buffer not null terminated
CWE-170 / https://cwe.mitre.org/data/definitions/170.html
Marek Schimara [Thu, 16 Jun 2016 11:55:39 +0000 (13:55 +0200)]
src/rrd_fetch.c: fix Coverity CID#26524 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Thu, 16 Jun 2016 11:45:54 +0000 (13:45 +0200)]
src/rrd_daemon.c: fix Coverity CID#26525 Buffer not null terminated
CWE-170 / https://cwe.mitre.org/data/definitions/170.html
Marek Schimara [Thu, 16 Jun 2016 11:31:26 +0000 (13:31 +0200)]
src/rrd_graph_helper.c: fix Coverity CID#26527 Buffer not null terminated
CWE-170 / https://cwe.mitre.org/data/definitions/170.html
Marek Schimara [Thu, 16 Jun 2016 11:23:39 +0000 (13:23 +0200)]
src/rrd_first.c: fix Coverity CID#26528 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Thu, 16 Jun 2016 11:18:37 +0000 (13:18 +0200)]
src/rrd_create.c: fix Coverity CID#26529 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Thu, 16 Jun 2016 09:37:01 +0000 (11:37 +0200)]
src/rrd_last.c: fix Coverity CID#26531 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Thu, 16 Jun 2016 09:31:41 +0000 (11:31 +0200)]
src/rrd_update.c: fix Coverity CID#26532 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Thu, 16 Jun 2016 09:19:49 +0000 (11:19 +0200)]
src/rrd_dump.c: fix Coverity CID#26534 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Thu, 16 Jun 2016 09:16:48 +0000 (11:16 +0200)]
src/rrd_info.c: fix Coverity CID#26535 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Thu, 16 Jun 2016 09:02:27 +0000 (11:02 +0200)]
src/rrd_cgi.c: fix Coverity CIDs#17398,#13656 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Thu, 16 Jun 2016 07:06:45 +0000 (09:06 +0200)]
src/rrd_cgi.c: fix Coverity CID#13656 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Wed, 15 Jun 2016 14:40:05 +0000 (16:40 +0200)]
src/rrd_daemon.c: fix Coverity CID#32399 Buffer not null terminated
CWE-170 / https://cwe.mitre.org/data/definitions/170.html
Marek Schimara [Wed, 15 Jun 2016 14:30:32 +0000 (16:30 +0200)]
src/rrd_create.c: fix Coverity CID#32400 Buffer not null terminated
CWE-170 / https://cwe.mitre.org/data/definitions/170.html
Marek Schimara [Wed, 15 Jun 2016 14:19:16 +0000 (16:19 +0200)]
src/rrd_graph_helper.c: fix Coverity CID#32401 Buffer not null terminated
CWE-170 / https://cwe.mitre.org/data/definitions/170.html
Marek Schimara [Wed, 15 Jun 2016 14:12:47 +0000 (16:12 +0200)]
src/rrd_open.c: fix Coverity CID#32402 Unchecked return value from library
CWE-252 / https://cwe.mitre.org/data/definitions/252.html
Marek Schimara [Wed, 15 Jun 2016 13:53:52 +0000 (15:53 +0200)]
src/rrd_modify.c: fix Coverity CID#32405 Logically dead code
CWE-561 / https://cwe.mitre.org/data/definitions/561.html
Marek Schimara [Wed, 15 Jun 2016 13:48:34 +0000 (15:48 +0200)]
src/rrd_modify.c: fix Coverity CID#32406 Logically dead code
CWE-561 / https://cwe.mitre.org/data/definitions/561.html
Either
finalout = rrd_modify_structure == NULL => goto done;
or
finalout = rrd_modify_structure != NULL => rc = 0;
Marek Schimara [Wed, 15 Jun 2016 13:36:28 +0000 (15:36 +0200)]
src/rrd_daemon.c: fix Coverity CID#32408 Missing unlock
CWE-667 / https://cwe.mitre.org/data/definitions/667.html
Marek Schimara [Wed, 15 Jun 2016 13:31:27 +0000 (15:31 +0200)]
src/rrd_client.c: fix Coverity CID#32409 Missing unlock
CWE-667 / https://cwe.mitre.org/data/definitions/667.html
Marek Schimara [Wed, 15 Jun 2016 13:03:35 +0000 (15:03 +0200)]
src/rrd_daemon.c: fix Coverity CID#32412 Nesting level does not match indentation
CWE-483 / https://cwe.mitre.org/data/definitions/483.html
Marek Schimara [Wed, 15 Jun 2016 12:52:33 +0000 (14:52 +0200)]
src/rrd_graph.c: fix Coverity CID#32414 Array compared against 0
CWE-398 / https://cwe.mitre.org/data/definitions/398.html
'im' declared as: image_desc_t *im
im->gdes[i] is: graph_desc_t *gdes; /* points to an array of graph elements */
im->gdes[i].format is: char format[FMT_LEG_LEN + 5]; /* format for PRINT AND GPRINT */
Comparing a stack variable to NULL doesn't make sense.
Marek Schimara [Wed, 15 Jun 2016 11:26:55 +0000 (13:26 +0200)]
src/rrd_daemon.c: fix Coverity CIDs#32415,#26519 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Wed, 15 Jun 2016 11:23:51 +0000 (13:23 +0200)]
src/rrd_daemon.c: fix Coverity CID#32416 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Wed, 15 Jun 2016 11:17:45 +0000 (13:17 +0200)]
src/rrd_daemon.c: fix Coverity CID#32417 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Wed, 15 Jun 2016 09:34:49 +0000 (11:34 +0200)]
src/rrd_daemon.c: fix Coverity CIDs#32418,#32419 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Wed, 15 Jun 2016 09:09:34 +0000 (11:09 +0200)]
src/rrd_daemon.c: fix Coverity CIDs#32420,#26530 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Wed, 15 Jun 2016 08:56:37 +0000 (10:56 +0200)]
src/rrd_daemon.c: fix Coverity CID#32421 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Wed, 15 Jun 2016 08:39:44 +0000 (10:39 +0200)]
src/rrd_create.c: fix Coverity CID#32422 Resource leak
CWE-404 / https://cwe.mitre.org/data/definitions/404.html
Marek Schimara [Wed, 15 Jun 2016 07:59:25 +0000 (09:59 +0200)]
src/rrd_tune.c: fix Coverity CID#32424 Improper use of negative value
CWE-394 / https://cwe.mitre.org/data/definitions/394.html
Note: optparse_init() and optparse_long() which can modify the
'options' variable in rrd_tune() can never set options.optind
to a negative value.
Marek Schimara [Wed, 15 Jun 2016 07:25:45 +0000 (09:25 +0200)]
src/rrd_create.c: fix Coverity CID#32425 Insecure temporary file
CWE-377 / https://cwe.mitre.org/data/definitions/377.html
Marek Schimara [Tue, 14 Jun 2016 15:02:11 +0000 (17:02 +0200)]
src/rrd_modify.c: fix Coverity CID#32426 Copy into fixed size buffer
CWE-120 / https://cwe.mitre.org/data/definitions/120.html
Marek Schimara [Tue, 14 Jun 2016 14:55:25 +0000 (16:55 +0200)]
src/rrd_create.c: fix Coverity CID#32427 Copy into fixed size buffer (buffer overflow)
CWE-120 / https://cwe.mitre.org/data/definitions/120.html
Marek Schimara [Tue, 14 Jun 2016 14:46:46 +0000 (16:46 +0200)]
bindings/perl-shared/RRDs.xs: fix Coverity CID#32428 Uninitialized pointer read
CWE-457 / https://cwe.mitre.org/data/definitions/457.html
Marek Schimara [Tue, 14 Jun 2016 14:05:29 +0000 (16:05 +0200)]
src/rrd_create.c: fix Coverity CID#32429 Uninitialized pointer read
CWE-457 / https://cwe.mitre.org/data/definitions/457.html
Marek Schimara [Tue, 14 Jun 2016 14:04:09 +0000 (16:04 +0200)]
src/rrd_tune.c: fix Coverity CID#32430 Uninitialized pointer read
CWE-457 / https://cwe.mitre.org/data/definitions/457.html
Tobias Oetiker [Tue, 21 Jun 2016 12:18:23 +0000 (14:18 +0200)]
Merge pull request #710 from nirgal/patch-4
CHANGES about supported lua versions
Tobias Oetiker [Mon, 23 May 2016 15:59:43 +0000 (17:59 +0200)]
nagle not nagel
Tobias Oetiker [Mon, 9 May 2016 06:39:15 +0000 (08:39 +0200)]
Merge branch 'master' of github.com:oetiker/rrdtool-1.x
Tobias Oetiker [Mon, 9 May 2016 06:38:57 +0000 (08:38 +0200)]
fix release number
Tobias Oetiker [Fri, 22 Apr 2016 15:19:14 +0000 (17:19 +0200)]
Merge pull request #712 from gitter-badger/gitter-badge-1
Add a Gitter chat badge to README.md
The Gitter Badger [Fri, 22 Apr 2016 15:18:29 +0000 (15:18 +0000)]
Add Gitter badge
nirgal [Fri, 22 Apr 2016 15:14:41 +0000 (17:14 +0200)]
CHANGES about supported lua versions
lua 5.1 already was supported.
What version 1.6.0 brings is lua 5.2 and lua 5.3 support.
Tobias Oetiker [Tue, 19 Apr 2016 16:05:16 +0000 (18:05 +0200)]
travis-link
Tobias Oetiker [Tue, 19 Apr 2016 15:50:15 +0000 (17:50 +0200)]
prep master for new checkins
Tobias Oetiker [Tue, 19 Apr 2016 09:17:55 +0000 (11:17 +0200)]
remove extra spaces
Tobias Oetiker [Tue, 19 Apr 2016 08:01:07 +0000 (10:01 +0200)]
fix for #707