]> git.ipfire.org Git - thirdparty/pdns.git/log
thirdparty/pdns.git
2 years agoAdd a fuzzing target for YaHTTP 9709/head
Remi Gacogne [Thu, 12 Nov 2020 08:01:23 +0000 (09:01 +0100)] 
Add a fuzzing target for YaHTTP

2 years agoMerge pull request #12210 from rgacogne/auth-remotebackend-tests-failures
Otto Moerbeek [Mon, 28 Nov 2022 11:07:30 +0000 (12:07 +0100)] 
Merge pull request #12210 from rgacogne/auth-remotebackend-tests-failures

auth: Better error handling in the remote backend tests

2 years agoMerge pull request #11966 from darnuria/clang-tidy/empty
Otto Moerbeek [Mon, 28 Nov 2022 10:58:57 +0000 (11:58 +0100)] 
Merge pull request #11966 from darnuria/clang-tidy/empty

[clang-tidy] pdns_utils use empty where possible + move decl to assignation site.

2 years agoMerge pull request #11910 from darnuria/clang-tidy/get-line
Otto Moerbeek [Mon, 28 Nov 2022 10:52:34 +0000 (11:52 +0100)] 
Merge pull request #11910 from darnuria/clang-tidy/get-line

[clang-tidy]: DynListener::getLine.

2 years agoMerge pull request #11968 from darnuria/clang-tidy/nullptr/pdns-utils
Otto Moerbeek [Mon, 28 Nov 2022 10:50:11 +0000 (11:50 +0100)] 
Merge pull request #11968 from darnuria/clang-tidy/nullptr/pdns-utils

[clang-tidy] Use nullptr explicitly and initialize directly.

2 years agoMerge pull request #12059 from darnuria/clang-tidy/geoipbackend
Otto Moerbeek [Mon, 28 Nov 2022 10:49:21 +0000 (11:49 +0100)] 
Merge pull request #12059 from darnuria/clang-tidy/geoipbackend

Clang tidy/geoipbackend

2 years agoMerge pull request #12060 from darnuria/clang-tidy/bindbackend
Otto Moerbeek [Mon, 28 Nov 2022 10:43:01 +0000 (11:43 +0100)] 
Merge pull request #12060 from darnuria/clang-tidy/bindbackend

Clang tidy/bindbackend

2 years agoMerge pull request #11505 from jroessler-ox/docs-auth-api-examples
Remi Gacogne [Mon, 28 Nov 2022 09:24:38 +0000 (10:24 +0100)] 
Merge pull request #11505 from jroessler-ox/docs-auth-api-examples

updates to API documentation of Auth

2 years agoMerge pull request #12095 from darnuria/array1
Remi Gacogne [Mon, 28 Nov 2022 09:14:47 +0000 (10:14 +0100)] 
Merge pull request #12095 from darnuria/array1

[clang-tidy:array] in dns.cc/hh std::array instead of c array.

2 years agoMerge pull request #12180 from humphd/docker-compose-doc-update
Remi Gacogne [Mon, 28 Nov 2022 09:12:10 +0000 (10:12 +0100)] 
Merge pull request #12180 from humphd/docker-compose-doc-update

Update Docker README to mention dependency on git submodule

2 years agoMerge pull request #12235 from Habbie/sphinxcontrib-openapi-py3.10
Peter van Dijk [Fri, 25 Nov 2022 15:40:41 +0000 (16:40 +0100)] 
Merge pull request #12235 from Habbie/sphinxcontrib-openapi-py3.10

auth docs build, bump sphinxcontrib-openapi to a version compatible with Python 3.10

2 years agoauth docs build, bump sphinxcontrib-openapi to a version compatible with Python 3.10 12235/head
Peter van Dijk [Fri, 25 Nov 2022 14:45:30 +0000 (15:45 +0100)] 
auth docs build, bump sphinxcontrib-openapi to a version compatible with Python 3.10

fixes #12204

2 years agoMerge pull request #12233 from omoerbeek/rec-prep-4.5.12-4.6.5-4.7.4
Otto Moerbeek [Fri, 25 Nov 2022 12:58:49 +0000 (13:58 +0100)] 
Merge pull request #12233 from omoerbeek/rec-prep-4.5.12-4.6.5-4.7.4

Prep for rec-4.5.12 rec-4.6.5 rec-4.7.4

2 years agoPrep for rec-4.5.12 rec-4.6.5 rec-4.7.4 12233/head
Otto Moerbeek [Wed, 23 Nov 2022 11:14:30 +0000 (12:14 +0100)] 
Prep for rec-4.5.12 rec-4.6.5 rec-4.7.4

2 years agoMerge pull request #12214 from omoerbeek/dnsdist-regresss-speedup
Otto Moerbeek [Tue, 22 Nov 2022 12:57:57 +0000 (13:57 +0100)] 
Merge pull request #12214 from omoerbeek/dnsdist-regresss-speedup

dnsdist: regress speedup

2 years agoMerge pull request #12152 from omoerbeek/rec-macos-asan-testrunner
Otto Moerbeek [Tue, 22 Nov 2022 12:22:23 +0000 (13:22 +0100)] 
Merge pull request #12152 from omoerbeek/rec-macos-asan-testrunner

rec: Disable test_MtaskerException on Apple Silicon if asan is enabled.

2 years agoMerge pull request #12195 from rgacogne/ddist-lazy-logs
Remi Gacogne [Tue, 22 Nov 2022 12:21:10 +0000 (13:21 +0100)] 
Merge pull request #12195 from rgacogne/ddist-lazy-logs

dnsdist: Fix duplicated first delay in lazy mode, add more log messages

2 years agoMerge pull request #12220 from rgacogne/rgacogne-patch-1
Remi Gacogne [Tue, 22 Nov 2022 09:32:38 +0000 (10:32 +0100)] 
Merge pull request #12220 from rgacogne/rgacogne-patch-1

dnsdist: Fix typo in the doc for setUDPSocketBufferSizes

2 years agodnsdist: Fix typo in the doc for setUDPSocketBufferSizes 12220/head
Remi Gacogne [Tue, 22 Nov 2022 08:54:42 +0000 (09:54 +0100)] 
dnsdist: Fix typo in the doc for setUDPSocketBufferSizes

2 years agoMerge pull request #12219 from omoerbeek/rec-refresh-vs-infra
Otto Moerbeek [Tue, 22 Nov 2022 07:38:29 +0000 (08:38 +0100)] 
Merge pull request #12219 from omoerbeek/rec-refresh-vs-infra

rec: Infra queries should not use refresh mode.

2 years agoValue in test_Carbon can also be float 12214/head
Otto Moerbeek [Mon, 21 Nov 2022 19:34:29 +0000 (20:34 +0100)] 
Value in test_Carbon can also be float

2 years agoSome tests need a bit of extra delay.
Otto Moerbeek [Mon, 21 Nov 2022 08:05:08 +0000 (09:05 +0100)] 
Some tests need a bit of extra delay.

2 years agoInfra queries should not use refresh mode. 12219/head
Otto Moerbeek [Mon, 21 Nov 2022 10:38:54 +0000 (11:38 +0100)] 
Infra queries should not use refresh mode.

When I introduced serve state in #11776, I reintroduced the mistake previously fixed in #11376.
Fixes #12078

2 years agoSmarter startup delay: wait for listen port to come alive
Otto Moerbeek [Fri, 18 Nov 2022 10:14:53 +0000 (11:14 +0100)] 
Smarter startup delay: wait for listen port to come alive

2 years agoMerge pull request #12206 from tacerus/rpm-systemd
Peter van Dijk [Fri, 18 Nov 2022 11:07:44 +0000 (12:07 +0100)] 
Merge pull request #12206 from tacerus/rpm-systemd

Clear systemd-units dependency

2 years agodnsdist: Test the exponential back-off delays 12195/head
Remi Gacogne [Fri, 18 Nov 2022 11:03:02 +0000 (12:03 +0100)] 
dnsdist: Test the exponential back-off delays

2 years agoUpdate systemd dependencies 12206/head
Georg Pfuetzenreuter [Thu, 17 Nov 2022 21:13:36 +0000 (22:13 +0100)] 
Update systemd dependencies

Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
2 years agoUse smart&fast killProcess from recursor regresssion test
Otto Moerbeek [Fri, 18 Nov 2022 09:38:48 +0000 (10:38 +0100)] 
Use smart&fast killProcess from recursor regresssion test

2 years agoMerge pull request #12209 from omoerbeek/rec-prep-4.8.0-rc1
Otto Moerbeek [Fri, 18 Nov 2022 09:37:55 +0000 (10:37 +0100)] 
Merge pull request #12209 from omoerbeek/rec-prep-4.8.0-rc1

Prep for rec-4.8.0-rc1

2 years agoauth: Better error handling in the remote backend tests 12210/head
Remi Gacogne [Fri, 18 Nov 2022 09:04:30 +0000 (10:04 +0100)] 
auth: Better error handling in the remote backend tests

2 years agoPrep for rec-4.8.0-rc1 12209/head
Otto Moerbeek [Fri, 18 Nov 2022 08:15:49 +0000 (09:15 +0100)] 
Prep for rec-4.8.0-rc1

2 years agoMerge pull request #12199 from omoerbeek/rec-forward-ds-negcache
Otto Moerbeek [Wed, 16 Nov 2022 13:51:58 +0000 (14:51 +0100)] 
Merge pull request #12199 from omoerbeek/rec-forward-ds-negcache

rec: Also consider recursive forward in the "forwarded DS should not end up in negCache code."

2 years agoMerge pull request #12198 from omoerbeek/rec-processrecords-opt
Otto Moerbeek [Wed, 16 Nov 2022 13:29:05 +0000 (14:29 +0100)] 
Merge pull request #12198 from omoerbeek/rec-processrecords-opt

rec: Correct skip record condition in processRecords

2 years agoAlso consider recursive forward in the "forwarded DS should not end up in negCache... 12199/head
Otto Moerbeek [Wed, 16 Nov 2022 12:58:04 +0000 (13:58 +0100)] 
Also consider recursive forward in the "forwarded DS should not end up in negCache code."

With @rgacogne and @phonedph1
Fixes #12189

2 years agoCorrect skip record condition in processRecords. 12198/head
Otto Moerbeek [Wed, 16 Nov 2022 12:49:59 +0000 (13:49 +0100)] 
Correct skip record condition in processRecords.

Noted the other day by @rgacogne

2 years agodnsdist: Fix duplicated first delay in lazy mode, add more log messages
Remi Gacogne [Tue, 15 Nov 2022 15:34:04 +0000 (16:34 +0100)] 
dnsdist: Fix duplicated first delay in lazy mode, add more log messages

2 years agoMerge pull request #12194 from omoerbeek/address-typo
Otto Moerbeek [Tue, 15 Nov 2022 15:22:51 +0000 (16:22 +0100)] 
Merge pull request #12194 from omoerbeek/address-typo

Fix typo

2 years agoFix typo 12194/head
Otto Moerbeek [Tue, 15 Nov 2022 13:47:51 +0000 (14:47 +0100)] 
Fix typo

2 years agoMerge pull request #12114 from rgacogne/ddist-fix-warning-backoff-coeff
Remi Gacogne [Tue, 15 Nov 2022 13:01:18 +0000 (14:01 +0100)] 
Merge pull request #12114 from rgacogne/ddist-fix-warning-backoff-coeff

dnsdist: Fix 'comparison of integer expressions of different signedness' warning

2 years agodnsdist: Apply suggestion from Otto (unsigned -> double) 12114/head
Remi Gacogne [Tue, 15 Nov 2022 11:32:40 +0000 (12:32 +0100)] 
dnsdist: Apply suggestion from Otto (unsigned -> double)

Co-authored-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
2 years agoMerge pull request #12175 from omoerbeek/rec-getdsrecords-qm
Otto Moerbeek [Mon, 14 Nov 2022 13:58:19 +0000 (14:58 +0100)] 
Merge pull request #12175 from omoerbeek/rec-getdsrecords-qm

rec: Get DS records with QM switched on.

2 years agoFix test (from rgacogne) 12175/head
Otto Moerbeek [Mon, 14 Nov 2022 12:46:04 +0000 (13:46 +0100)] 
Fix test (from rgacogne)

Do this by merging https://github.com/PowerDNS/pdns/commit/994d2e09f088f2908a887e2539f8abbd1e36d003.diff

For some unknown reason (maybe the same reason rgacogne was not able to create a PR for this?)
a cherry pick did not work, so do a "manual" diff and patch of Remi's work.

2 years agoAvoid a race in wiping the cache and fix test_Bogus by explictly
Otto Moerbeek [Mon, 7 Nov 2022 13:24:19 +0000 (14:24 +0100)] 
Avoid a race in wiping the cache and fix test_Bogus by explictly
filling the aggressive cache.

2 years agoMerge pull request #12177 from rgacogne/ddist-fix-value-or-boost
Remi Gacogne [Thu, 10 Nov 2022 08:53:55 +0000 (09:53 +0100)] 
Merge pull request #12177 from rgacogne/ddist-fix-value-or-boost

dnsdist: Fix building with boost < 1.56

2 years agoMerge pull request #12157 from mind04/auth-list-zones
Peter van Dijk [Wed, 9 Nov 2022 09:21:26 +0000 (10:21 +0100)] 
Merge pull request #12157 from mind04/auth-list-zones

auth: fix pdns_control list-zones

2 years agoUpdate docker-compose docs to mention git submodule 12180/head
David Humphrey [Tue, 8 Nov 2022 22:25:06 +0000 (17:25 -0500)] 
Update docker-compose docs to mention git submodule

2 years agodnsdist: Fix building with boost < 1.56 12177/head
Remi Gacogne [Tue, 8 Nov 2022 09:36:07 +0000 (10:36 +0100)] 
dnsdist: Fix building with boost < 1.56

boost::optional::value_or() has been introduced in 1.56
and we only require 1.53, so stop using it.

2 years agoMerge pull request #12174 from omoerbeek/rec-prep-4.8.0-beta2
Otto Moerbeek [Mon, 7 Nov 2022 12:44:34 +0000 (13:44 +0100)] 
Merge pull request #12174 from omoerbeek/rec-prep-4.8.0-beta2

rec: Prep for rec-4.8.0-beta2

2 years agoGet DS records with QM switched on.
Otto Moerbeek [Mon, 7 Nov 2022 08:03:51 +0000 (09:03 +0100)] 
Get DS records with QM switched on.

This avoid a.root-servers.net going Bogus, which can happen
if the .net NS are not cached and we miss the cut.

Fixes #12160 and avoids the need to prime the .net NS records explicitly.

2 years agoPrep for rec-4.8.0-beta2 12174/head
Otto Moerbeek [Fri, 4 Nov 2022 13:42:01 +0000 (14:42 +0100)] 
Prep for rec-4.8.0-beta2

2 years ago[clang-tidy] non-init k_size and z_size in secureZone. 11966/head
Axel Viala [Sat, 17 Sep 2022 11:01:51 +0000 (13:01 +0200)] 
[clang-tidy] non-init k_size and z_size in secureZone.

2 years ago[clang-tidy] use collection.empty() where possible in pdns_utils.
Axel Viala [Wed, 14 Sep 2022 16:14:15 +0000 (18:14 +0200)] 
[clang-tidy] use collection.empty() where possible in pdns_utils.

2 years ago[clang-tidy] Use nullptr explicitly and initialize directly. 11968/head
Axel Viala [Wed, 14 Sep 2022 16:16:21 +0000 (18:16 +0200)] 
[clang-tidy] Use nullptr explicitly and initialize directly.

2 years ago[clang-tidy] Use find with better override. 12059/head
Axel Viala [Mon, 3 Oct 2022 21:33:22 +0000 (23:33 +0200)] 
[clang-tidy] Use find with better override.

2 years ago[clang-tidy][geoip-backend] Use std::Array and constify weekday/months.
Axel Viala [Sat, 1 Oct 2022 11:45:38 +0000 (13:45 +0200)] 
[clang-tidy][geoip-backend] Use std::Array and constify weekday/months.

2 years ago[clang-tidy][geoip-backend] use nullptr.
Axel Viala [Sat, 1 Oct 2022 11:45:07 +0000 (13:45 +0200)] 
[clang-tidy][geoip-backend] use nullptr.

- review @rgacogne remove `static_cast` on nullptr

Co-authored-by: Remi Gacogne <github@coredump.fr>
2 years ago[bind-backend] Clang-tidy init bools. 12060/head
Axel Viala [Tue, 4 Oct 2022 12:45:30 +0000 (14:45 +0200)] 
[bind-backend] Clang-tidy init bools.

2 years ago[bind-backend] Clang-tidy use use empty.
Axel Viala [Tue, 4 Oct 2022 12:45:30 +0000 (14:45 +0200)] 
[bind-backend] Clang-tidy use use empty.

2 years ago[bind-backend] Clang-tidy use nullptr.
Axel Viala [Tue, 4 Oct 2022 12:45:30 +0000 (14:45 +0200)] 
[bind-backend] Clang-tidy use nullptr.

2 years ago[bind-backend] Clang-tidy using.
Axel Viala [Tue, 4 Oct 2022 12:45:30 +0000 (14:45 +0200)] 
[bind-backend] Clang-tidy using.

2 years ago[bind-backend] Clang-tidy use auto.
Axel Viala [Tue, 4 Oct 2022 12:45:30 +0000 (14:45 +0200)] 
[bind-backend] Clang-tidy use auto.

2 years ago[bind-backend] Clang-tidy use cpp header.
Axel Viala [Thu, 29 Sep 2022 10:40:28 +0000 (12:40 +0200)] 
[bind-backend] Clang-tidy use cpp header.

2 years agoerror if the stack base and size cannot be determined when using ASAN 12152/head
Otto Moerbeek [Fri, 4 Nov 2022 09:04:01 +0000 (10:04 +0100)] 
error if the stack base and size cannot be determined when using ASAN

2 years agoMerge pull request #12155 from omoerbeek/rec-snmp-rcodes
Otto Moerbeek [Thu, 3 Nov 2022 12:20:00 +0000 (13:20 +0100)] 
Merge pull request #12155 from omoerbeek/rec-snmp-rcodes

Rec: fix snmp rcodes OIDs

2 years agoTypo 12155/head
Otto Moerbeek [Thu, 3 Nov 2022 12:16:03 +0000 (13:16 +0100)] 
Typo

Co-authored-by: Charles-Henri Bruyand <charleshenri.bruyand+github@gmail.com>
2 years agoMerge pull request #12125 from omoerbeek/ixfr-timeout
Otto Moerbeek [Thu, 3 Nov 2022 09:50:56 +0000 (10:50 +0100)] 
Merge pull request #12125 from omoerbeek/ixfr-timeout

Timout handling for ixfrs as a client.

2 years agoBetter wording in comment 12125/head
Otto Moerbeek [Thu, 3 Nov 2022 08:50:12 +0000 (09:50 +0100)] 
Better wording in comment

Co-authored-by: Peter van Dijk <peter.van.dijk@powerdns.com>
2 years agoauth: fix pdns_control list-zones 12157/head
Kees Monshouwer [Wed, 2 Nov 2022 20:35:25 +0000 (21:35 +0100)] 
auth: fix pdns_control list-zones

2 years agoClarify Prometheus names
Otto Moerbeek [Wed, 2 Nov 2022 14:56:17 +0000 (15:56 +0100)] 
Clarify Prometheus names

2 years agoFix snmp OID numbers for rcode stats
Otto Moerbeek [Wed, 2 Nov 2022 14:44:46 +0000 (15:44 +0100)] 
Fix snmp OID numbers for rcode stats

2 years agoAdd dnsdist-17 for Ubuntu Jammy and EL-9 to repo test script (#12153)
aerique [Wed, 2 Nov 2022 13:42:10 +0000 (14:42 +0100)] 
Add dnsdist-17 for Ubuntu Jammy and EL-9 to repo test script (#12153)

* Add dnsdist-17 for EL9 and Ubuntu Jammy to repo test script.
* Fix issue with EPEL for EL9 in repo test script.

2 years agoMerge pull request #12149 from Habbie/dnsdist-1.7.3-docs
Peter van Dijk [Wed, 2 Nov 2022 11:38:43 +0000 (12:38 +0100)] 
Merge pull request #12149 from Habbie/dnsdist-1.7.3-docs

dnsdist-1.7.3: docs and secpoll

2 years agoDisable test_MtaskerException on Apple Silicon if asan is enabled. Works around ...
Otto Moerbeek [Wed, 2 Nov 2022 10:49:19 +0000 (11:49 +0100)] 
Disable test_MtaskerException on Apple Silicon if asan is enabled. Works around #12151

2 years agoMerge pull request #12122 from omoerbeek/trace-regex-qtype
Otto Moerbeek [Wed, 2 Nov 2022 09:20:31 +0000 (10:20 +0100)] 
Merge pull request #12122 from omoerbeek/trace-regex-qtype

rec: Implement output operator for QTypes.

2 years agodnsdist-1.7.3: docs and secpoll 12149/head
Peter van Dijk [Tue, 1 Nov 2022 21:51:48 +0000 (22:51 +0100)] 
dnsdist-1.7.3: docs and secpoll

2 years agoMerge pull request #12148 from Habbie/auth-4.7.2-docs
Peter van Dijk [Tue, 1 Nov 2022 13:14:13 +0000 (14:14 +0100)] 
Merge pull request #12148 from Habbie/auth-4.7.2-docs

auth-4.7.2: secpoll & docs

2 years agoauth-4.7.2: secpoll & docs 12148/head
Peter van Dijk [Tue, 1 Nov 2022 12:46:10 +0000 (13:46 +0100)] 
auth-4.7.2: secpoll & docs

2 years agoMerge pull request #12140 from omoerbeek/rec-auth-unauth-cache-replace-fix
Otto Moerbeek [Tue, 1 Nov 2022 12:40:10 +0000 (13:40 +0100)] 
Merge pull request #12140 from omoerbeek/rec-auth-unauth-cache-replace-fix

rec: QM can get confused by expiring infra records

2 years agotypo in comment 12140/head
Otto Moerbeek [Tue, 1 Nov 2022 11:38:54 +0000 (12:38 +0100)] 
typo in comment

Co-authored-by: Peter van Dijk <peter.van.dijk@powerdns.com>
2 years agoAdd test
Otto Moerbeek [Tue, 1 Nov 2022 11:06:32 +0000 (12:06 +0100)] 
Add test

2 years agoMerge pull request #12138 from Habbie/auth-4.7.1-docs
Peter van Dijk [Mon, 31 Oct 2022 14:53:07 +0000 (15:53 +0100)] 
Merge pull request #12138 from Habbie/auth-4.7.1-docs

auth-4.7.1: secpoll and docs

2 years agoRevert "upgrade to auth-4.7"
Peter van Dijk [Fri, 28 Oct 2022 14:02:52 +0000 (16:02 +0200)] 
Revert "upgrade to auth-4.7"

This reverts commit e71ce4c386e47adc64bfd5307e0d37b08bee4ffc.

2 years agoupgrade to auth-4.7
Peter van Dijk [Fri, 28 Oct 2022 14:01:01 +0000 (16:01 +0200)] 
upgrade to auth-4.7

2 years agoMerge pull request #12141 from PowerDNS/dispatch-upload
Peter van Dijk [Fri, 28 Oct 2022 12:29:37 +0000 (14:29 +0200)] 
Merge pull request #12141 from PowerDNS/dispatch-upload

github builds: upload to downloads.powerdns.com

2 years agogithub builds: upload to downloads.powerdns.com 12141/head
Peter van Dijk [Fri, 28 Oct 2022 07:53:05 +0000 (09:53 +0200)] 
github builds: upload to downloads.powerdns.com

2 years agoQM can get confused by expiring infra records, so be a bit more lenient
Otto Moerbeek [Fri, 28 Oct 2022 10:06:27 +0000 (12:06 +0200)] 
QM can get confused by expiring infra records, so be a bit more lenient
with replacing auth records by unauth, as unauth (typically infra
records) might come in while we are resolving.

Should fix #12078

2 years agoauth-4.7.1: secpoll and docs 12138/head
Peter van Dijk [Fri, 28 Oct 2022 08:10:17 +0000 (10:10 +0200)] 
auth-4.7.1: secpoll and docs

2 years agoclang-tidy: Avoid C cast do a reinterpret_cast. 11910/head
Axel Viala [Wed, 26 Oct 2022 17:28:07 +0000 (19:28 +0200)] 
clang-tidy: Avoid C cast do a reinterpret_cast.

2 years agoclang-tidy: Braces + avoid else after throw.
Axel Viala [Wed, 26 Oct 2022 17:23:00 +0000 (19:23 +0200)] 
clang-tidy: Braces + avoid else after throw.

2 years agoNIT: move len near usage.
Axel Viala [Fri, 23 Sep 2022 10:13:40 +0000 (12:13 +0200)] 
NIT: move len near usage.

2 years agoclang-tidy: DynListener::getLine.
Axel Viala [Fri, 2 Sep 2022 20:38:34 +0000 (22:38 +0200)] 
clang-tidy: DynListener::getLine.

Fix founds with:

- [readability-implicit-bool-conversion]
  - pdns/dynlistener.cc:256
  - pdns/dynlistener.cc:272:8

- [readability-container-data-pointer]
  - pdns/dynlistener.cc:240:19
  - pdns/dynlistener.cc:245:25
  - pdns/dynlistener.cc:256:17
  - dns/dynlistener.cc:263:17

- [bugprone-narrowing-conversions,cppcoreguidelines-narrowing-conversions]
  - pdns/dynlistener.cc:240:29
  - pdns/dynlistener.cc:256:27

Avoided to fix `if` related to avoid making too much noise.

2 years agoTimout handling for ixfrs as a client.
Otto Moerbeek [Mon, 24 Oct 2022 14:25:59 +0000 (16:25 +0200)] 
Timout handling for ixfrs as a client.

One complicating factor is that this is shared code, but auth and
rec do not agree on the definiton of the timeout value: auth states
it is a maximum idle time, while rec state it is the total xfr time.
While both apporaches make sense and in the end we would like to
enforce both, we now go for a more simple solution that respects
auth or rec behaviour based on a flag.

2 years agoPass an object as const ref 12122/head
Otto Moerbeek [Wed, 26 Oct 2022 05:56:47 +0000 (07:56 +0200)] 
Pass an object as const ref

Co-authored-by: Charles-Henri Bruyand <charleshenri.bruyand+github@gmail.com>
2 years agoMerge pull request #12120 from omoerbeek/rec-qm-avoid-loop
Otto Moerbeek [Wed, 26 Oct 2022 05:55:21 +0000 (07:55 +0200)] 
Merge pull request #12120 from omoerbeek/rec-qm-avoid-loop

rec: If we encounter a loop in QM, continue with the next iteration.

2 years agoMerge pull request #12130 from omoerbeek/auth-axfr-refresh-check
Otto Moerbeek [Tue, 25 Oct 2022 15:48:52 +0000 (17:48 +0200)] 
Merge pull request #12130 from omoerbeek/auth-axfr-refresh-check

Auth: xfr refresh check

2 years agoMerge pull request #12133 from omoerbeek/rec-fix-lockedcache-regress
Otto Moerbeek [Tue, 25 Oct 2022 15:14:10 +0000 (17:14 +0200)] 
Merge pull request #12133 from omoerbeek/rec-fix-lockedcache-regress

rec: Fix assertAlmostEqual call to compare absolute difference

2 years agoMerge pull request #12063 from omoerbeek/rec-protobuf-teardown
Otto Moerbeek [Tue, 25 Oct 2022 15:07:20 +0000 (17:07 +0200)] 
Merge pull request #12063 from omoerbeek/rec-protobuf-teardown

rec: Compare old and new config for protobuf logger config objects on Lua config reload

2 years agoUse > for frehsness test, to be consistent with the lmdb backend 12130/head
Otto Moerbeek [Tue, 25 Oct 2022 13:33:45 +0000 (15:33 +0200)] 
Use > for frehsness test, to be consistent with the lmdb backend

2 years agoMerge pull request #12132 from omoerbeek/auth-lua-test-sleep
Peter van Dijk [Tue, 25 Oct 2022 14:20:40 +0000 (16:20 +0200)] 
Merge pull request #12132 from omoerbeek/auth-lua-test-sleep

auth: take into account default urlcheck timeout is 2 seconds for Lua records tests

2 years agoFix assertAlmostEqual call to compare absolute difference 12133/head
Otto Moerbeek [Tue, 25 Oct 2022 14:15:07 +0000 (16:15 +0200)] 
Fix assertAlmostEqual call to compare absolute difference