]>
git.ipfire.org Git - thirdparty/pdns.git/log
Otto Moerbeek [Mon, 12 Jun 2023 09:22:56 +0000 (11:22 +0200)]
Merge pull request #12900 from omoerbeek/rec-serve-stale-dup-cname
rec: Prevent duplicate C/DNAMEs being included when doing serve-stale
Otto Moerbeek [Mon, 12 Jun 2023 09:02:02 +0000 (11:02 +0200)]
Don't double print and delint
Remi Gacogne [Mon, 12 Jun 2023 09:04:51 +0000 (11:04 +0200)]
dnsdist: Remove a racy test in the AsynchronousHolder unit tests
We are adding an expired event so the worker thread of the
AsynchronousHolder can pick it up immediately, even before we come
back from the call to push(), which leads to a racy test.
This was observed on GitHub Actions when running with TSAN:
```
FAIL: testrunner
================
Running 170 test cases...
test-dnsdistasync.cc(156): error: in "test_dnsdistasync/test_AddingExpiredEvent": check !holder->empty() has failed
*** 1 failure is detected in the test module "unit"
FAIL testrunner (exit status: 201)
```
Otto Moerbeek [Mon, 12 Jun 2023 09:03:50 +0000 (11:03 +0200)]
Merge pull request #12896 from omoerbeek/rec-nod-metrics
rec: expose NOD/UDR metrics
Otto Moerbeek [Mon, 12 Jun 2023 08:41:02 +0000 (10:41 +0200)]
rec: uid_t and gid_t can be unsigned, so doing > on and -1 value is tricky
Otto Moerbeek [Mon, 12 Jun 2023 08:35:34 +0000 (10:35 +0200)]
Merge pull request #12883 from omoerbeek/rec-rpz-soa
rec: add SOA to RPZ modified answers if configured to do so
Otto Moerbeek [Mon, 12 Jun 2023 08:33:47 +0000 (10:33 +0200)]
delint
Otto Moerbeek [Mon, 12 Jun 2023 08:14:03 +0000 (10:14 +0200)]
Process review comments
Remi Gacogne [Mon, 12 Jun 2023 08:10:20 +0000 (10:10 +0200)]
Merge pull request #12840 from phonedph1/patch-39
Update dnsdist-console.cc
Otto Moerbeek [Mon, 12 Jun 2023 07:08:10 +0000 (09:08 +0200)]
Add tests to see if CNAME records are not included multiple times
Remi Gacogne [Mon, 12 Jun 2023 08:08:45 +0000 (10:08 +0200)]
Merge pull request #12839 from phonedph1/patch-38
Update rules-actions.rst
Otto Moerbeek [Mon, 12 Jun 2023 07:40:18 +0000 (09:40 +0200)]
rec: Escape (by prepending "PDNS") message keys that are special to systemd-journal
Otto Moerbeek [Fri, 9 Jun 2023 09:51:04 +0000 (11:51 +0200)]
rec: Prevent duplicate C/DNAMEs to be included when doing serve-stale
This can happen if the CNAME record itself was found, but its target not
Otto Moerbeek [Fri, 9 Jun 2023 06:06:06 +0000 (08:06 +0200)]
Merge pull request #12898 from omoerbeek/rec-depth
rec: keep track of max depth reached and report it if !quiet
Otto Moerbeek [Thu, 8 Jun 2023 11:22:43 +0000 (13:22 +0200)]
Prometheus does not like counter names ending in -count
Otto Moerbeek [Thu, 8 Jun 2023 10:49:01 +0000 (12:49 +0200)]
(Partial) Tidy
Otto Moerbeek [Thu, 8 Jun 2023 10:44:17 +0000 (12:44 +0200)]
rec: keep track of max depth reaches and report it if !quiet
This is enough for now, mostly a metric only interesting to devs
Otto Moerbeek [Thu, 8 Jun 2023 10:11:26 +0000 (12:11 +0200)]
Extend SNMP test to include new OIDs
Otto Moerbeek [Thu, 8 Jun 2023 09:52:02 +0000 (11:52 +0200)]
Add Prometheus and SNMP version of NOD/UDR metrics
Otto Moerbeek [Thu, 8 Jun 2023 09:30:01 +0000 (11:30 +0200)]
Keep track of metrics for NOD and UDR events.
While there, change level of ndr logs to Notice, it was Debug before
Otto Moerbeek [Wed, 7 Jun 2023 10:27:30 +0000 (12:27 +0200)]
Add docs
Otto Moerbeek [Wed, 7 Jun 2023 10:10:26 +0000 (12:10 +0200)]
Add rec_control command to list supported algo names
Otto Moerbeek [Wed, 7 Jun 2023 09:42:48 +0000 (11:42 +0200)]
Distinguish auto and manual disabling in logging
Otto Moerbeek [Wed, 7 Jun 2023 08:19:13 +0000 (10:19 +0200)]
Impelement verification of algos 5 and 7
Otto Moerbeek [Tue, 6 Jun 2023 14:11:59 +0000 (16:11 +0200)]
rec: implement a way to disable specific DNSSEC algorithms
This could be needed when runing RHEL9, to avoid having zones signed
with algo 5 or 7 going Bogus. RHEL9 does not support these algorithms,
unless the globalsecurity policy is modified.
Peter van Dijk [Tue, 6 Jun 2023 07:49:02 +0000 (09:49 +0200)]
Merge pull request #12889 from Habbie/auth-4.8-eol-update
auth 4.8: EOL update
Peter van Dijk [Mon, 5 Jun 2023 14:34:15 +0000 (16:34 +0200)]
auth 4.8: EOL update
Otto Moerbeek [Fri, 2 Jun 2023 12:16:40 +0000 (14:16 +0200)]
delint
Otto Moerbeek [Fri, 2 Jun 2023 12:09:10 +0000 (14:09 +0200)]
Merge pull request #12793 from omoerbeek/assorted-delint
Another set of delinting
Otto Moerbeek [Fri, 2 Jun 2023 09:05:33 +0000 (11:05 +0200)]
Merge pull request #12867 from omoerbeek/rec-prep-4.9.0-beta1
rec: Prep for rec-4.9.0-beta1
Otto Moerbeek [Wed, 31 May 2023 08:28:00 +0000 (10:28 +0200)]
Prep for rec-4.9.0-beta1
Peter van Dijk [Thu, 1 Jun 2023 19:13:48 +0000 (21:13 +0200)]
Merge pull request #12880 from Habbie/swagger-no-docker
swagger-syntax-check: run outside of Docker
Peter van Dijk [Thu, 1 Jun 2023 18:39:56 +0000 (20:39 +0200)]
builder-dispatch: add debian-bookworm target to defaults
Peter van Dijk [Thu, 1 Jun 2023 16:57:17 +0000 (18:57 +0200)]
swagger-syntax-check: run outside of Docker
Peter van Dijk [Thu, 1 Jun 2023 16:28:17 +0000 (18:28 +0200)]
Merge pull request #12875 from Habbie/upgrade-notes-46-47-master
auth upgrading: fix 4.6/4.7 header; update LMDB text
romeroalx [Thu, 1 Jun 2023 14:57:59 +0000 (16:57 +0200)]
Merge pull request #12856 from romeroalx/enable-ipv6-actions-container
Enable ipv6 for actions running on docker containers
Peter van Dijk [Thu, 1 Jun 2023 12:03:58 +0000 (14:03 +0200)]
auth upgrading: fix 4.6/4.7 header; update LMDB text
Peter van Dijk [Thu, 1 Jun 2023 11:16:54 +0000 (13:16 +0200)]
Merge pull request #12874 from Habbie/auth-4.8.0-docs-secpoll
auth-4.8.0: docs and secpoll
Peter van Dijk [Thu, 1 Jun 2023 11:04:59 +0000 (13:04 +0200)]
auth-4.8.0: docs and secpoll
aerique [Thu, 1 Jun 2023 10:56:12 +0000 (12:56 +0200)]
Merge pull request #12873 from aerique/feature/add-bookwork-to-repo-test-script
Add Bookworm to repo test script.
Erik Winkels [Thu, 1 Jun 2023 09:41:23 +0000 (11:41 +0200)]
Add Bookworm to repo test script.
Add Debian Bookworm for `auth-master` & `auth-48` to repo test script.
Peter van Dijk [Wed, 31 May 2023 21:14:54 +0000 (23:14 +0200)]
Merge pull request #12866 from Habbie/auth-lmdb-dup-delete
auth lmdb: delete duplicate domain entries in deleteDomain
Otto Moerbeek [Tue, 30 May 2023 12:24:33 +0000 (14:24 +0200)]
Add test and fix TC=1 adding of SOA record
Otto Moerbeek [Tue, 30 May 2023 11:49:03 +0000 (13:49 +0200)]
rec: add SOA to RPZ result if configured to do so
Fixes #8232
Peter van Dijk [Wed, 31 May 2023 11:54:11 +0000 (13:54 +0200)]
Merge pull request #12860 from Habbie/auth-ent-wildcard
auth: do not answer with broken TYPE0 data when expanding an ENT wildcard
Peter van Dijk [Wed, 31 May 2023 11:53:52 +0000 (13:53 +0200)]
Merge pull request #12859 from Habbie/pdnsutil-edit-zone-wrong-key
pdnsutil: if user pushes unknown key in response to "problem with zone" prompt, do not throw away their changes
Peter van Dijk [Sun, 28 May 2023 21:05:35 +0000 (23:05 +0200)]
auth: do not answer with broken TYPE0 data when expanding an ENT wildcard
Otto Moerbeek [Tue, 16 May 2023 10:05:07 +0000 (12:05 +0200)]
Process review comments
Otto Moerbeek [Wed, 10 May 2023 07:44:52 +0000 (09:44 +0200)]
Reformat
Otto Moerbeek [Tue, 9 May 2023 11:15:34 +0000 (13:15 +0200)]
More delinting
A set of random files made clean. During this process .clang-tidy.full
was also amended a bit.
Peter van Dijk [Wed, 31 May 2023 08:33:56 +0000 (10:33 +0200)]
document shards=1 enforcement
Peter van Dijk [Wed, 31 May 2023 08:33:48 +0000 (10:33 +0200)]
format
Peter van Dijk [Wed, 31 May 2023 08:25:12 +0000 (10:25 +0200)]
simplify
Otto Moerbeek [Wed, 31 May 2023 07:52:37 +0000 (09:52 +0200)]
Merge pull request #12862 from omoerbeek/rec-recursion-bound
rec: bound maximum recursion depth to 16.
Otto Moerbeek [Wed, 31 May 2023 07:52:22 +0000 (09:52 +0200)]
Merge pull request #12861 from omoerbeek/rec-no-refresh
rec: Introduce a way to completely disable root-refresh
Peter van Dijk [Wed, 31 May 2023 07:34:02 +0000 (09:34 +0200)]
use d_transactiondomain[id]
Peter van Dijk [Wed, 31 May 2023 07:27:48 +0000 (09:27 +0200)]
Update modules/lmdbbackend/lmdbbackend.cc
Co-authored-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Peter van Dijk [Wed, 31 May 2023 07:25:26 +0000 (09:25 +0200)]
only throw when idvec is empty
Otto Moerbeek [Wed, 31 May 2023 06:39:36 +0000 (08:39 +0200)]
Merge pull request #12673 from omoerbeek/rec-origttl
rec: Sanitize d_orig_ttl stored in record cache
Peter van Dijk [Tue, 30 May 2023 16:50:47 +0000 (18:50 +0200)]
auth lmdb: enforce shards=1 when running in lightning-stream mode
Peter van Dijk [Tue, 30 May 2023 15:03:47 +0000 (17:03 +0200)]
auth lmdb: delete duplicate domain entries in deleteDomain
Otto Moerbeek [Tue, 30 May 2023 14:02:15 +0000 (16:02 +0200)]
Add the d_orig_ttl sanitization back, there still is a case where
it can wrap (which I'm unable to spot right now).
Otto Moerbeek [Tue, 30 May 2023 13:04:16 +0000 (15:04 +0200)]
Merge pull request #12863 from omoerbeek/rec-val-log-typo
rec: fix typo in trace message
Otto Moerbeek [Tue, 30 May 2023 13:03:58 +0000 (15:03 +0200)]
Merge pull request #12838 from omoerbeek/delint-rec-tcp
Delint rec-tcp.cc
Otto Moerbeek [Tue, 30 May 2023 13:03:35 +0000 (15:03 +0200)]
Merge pull request #12837 from omoerbeek/nolint-validate
Delint validate.cc and related files
Otto Moerbeek [Tue, 30 May 2023 13:03:06 +0000 (15:03 +0200)]
Merge pull request #12836 from omoerbeek/rec-main-delint-followup
rec: Full delint rec-main.cc
Otto Moerbeek [Tue, 30 May 2023 08:39:10 +0000 (10:39 +0200)]
Fix root-priming test, which now depends on a arg being set.
Otto Moerbeek [Tue, 30 May 2023 08:31:32 +0000 (10:31 +0200)]
rec: fix typo in trace message
Otto Moerbeek [Tue, 30 May 2023 08:16:52 +0000 (10:16 +0200)]
rec: bound maximum recursion depth to 16.
Before #12779, the fixed limit on CNAME chain length (16) effectively
worked as recursion depth limit.
Otto Moerbeek [Tue, 30 May 2023 07:57:13 +0000 (09:57 +0200)]
rec: Introduce a way to completely disable root-refresh
Peter van Dijk [Sun, 28 May 2023 20:39:33 +0000 (22:39 +0200)]
pdnsutil: if user pushes unknown key in response to "problem with zone" prompt, do not throw away their changes
Alexis Romero [Fri, 26 May 2023 13:51:46 +0000 (15:51 +0200)]
gh actions: enable ipv6 in docker containers
phonedph1 [Thu, 18 May 2023 15:23:43 +0000 (09:23 -0600)]
Update dnsdist-console.cc
phonedph1 [Thu, 18 May 2023 15:19:59 +0000 (09:19 -0600)]
Update rules-actions.rst
Remi Gacogne [Thu, 18 May 2023 11:30:26 +0000 (13:30 +0200)]
Merge pull request #12726 from rgacogne/ddist-wait-reconnect
dnsdist: Properly handle reconnection failure for backend UDP sockets
Remi Gacogne [Thu, 18 May 2023 11:29:47 +0000 (13:29 +0200)]
Merge pull request #12819 from rgacogne/ddist-reuseaddr-udp
dnsdist: Stop setting SO_REUSEADDR on outgoing UDP client sockets
Otto Moerbeek [Wed, 17 May 2023 12:16:05 +0000 (14:16 +0200)]
Tweaks
Otto Moerbeek [Wed, 17 May 2023 12:06:17 +0000 (14:06 +0200)]
Reformat
Otto Moerbeek [Wed, 17 May 2023 10:54:01 +0000 (12:54 +0200)]
Delint rec-tcp.cc
Otto Moerbeek [Wed, 17 May 2023 10:22:18 +0000 (12:22 +0200)]
Delint validate.cc and related files
romeroalx [Wed, 17 May 2023 09:41:46 +0000 (11:41 +0200)]
Merge pull request #12835 from romeroalx/fix-clang-misc
GH actions - misc-dailies.yaml: set clang version for Ubuntu-20
Otto Moerbeek [Wed, 17 May 2023 08:44:44 +0000 (10:44 +0200)]
Full delint rec-main.cc
Peter van Dijk [Wed, 17 May 2023 08:50:15 +0000 (10:50 +0200)]
Merge pull request #12834 from jpmens/patch-14
Be more specific in describing config-dir
Alexis Romero [Wed, 17 May 2023 08:28:29 +0000 (10:28 +0200)]
GH actions - misc-dailies: Set clang version for Ubuntu-20
Peter van Dijk [Tue, 16 May 2023 18:10:44 +0000 (20:10 +0200)]
Merge pull request #12833 from romeroalx/fix-cifuzz-apt-repo
Changing apt mirror for cifuzz base-builder image
Peter van Dijk [Tue, 16 May 2023 18:10:33 +0000 (20:10 +0200)]
Merge pull request #12810 from romeroalx/actions-debian-container
Run build-and-test-all.yml on a custom Debian 11 container instead of an Ubuntu Runner VM
Jan-Piet Mens [Tue, 16 May 2023 18:07:10 +0000 (20:07 +0200)]
Be more specific in describing config-dir
I think this more clearly describes the option
Alexis Romero [Tue, 16 May 2023 16:59:06 +0000 (18:59 +0200)]
set apt mirror for cifuzz base builder image
Alexis Romero [Fri, 12 May 2023 09:30:50 +0000 (11:30 +0200)]
Run build-and-test-all.yml on a custom debian container
Otto Moerbeek [Tue, 16 May 2023 11:14:37 +0000 (13:14 +0200)]
delint updateCacheFromRecords
Otto Moerbeek [Mon, 15 May 2023 13:48:46 +0000 (15:48 +0200)]
Record time the ttd was computed instead of compensating
Otto Moerbeek [Wed, 22 Mar 2023 13:05:40 +0000 (14:05 +0100)]
Alternate approach: remmeber the actual orig_ttl. A bit harded than you think, as
in somce cases TTDs are modified later.
Otto Moerbeek [Thu, 16 Mar 2023 15:08:56 +0000 (16:08 +0100)]
Sanitize d_orig_ttl
The computed orig_ttl can be wrong if d_now.tv_sec is more recent
than the d_now.tv_sec the ttd was computed from. This can happen
if we went out to get e.g. keys and that took time. d_orig_ttl wraps
around in that case if the TTL value was smaller than that delay.
Work around that and make sure d_orig_ttl is within the legal range.
Otto Moerbeek [Tue, 16 May 2023 10:28:47 +0000 (12:28 +0200)]
Merge pull request #12829 from omoerbeek/fix-log-fail
rec: fix clang-tidy botch wrt spelling of "log-fail"
Otto Moerbeek [Tue, 16 May 2023 10:22:12 +0000 (12:22 +0200)]
Merge pull request #12830 from omoerbeek/secpoll-ubuntu-mirror
secpoll check: use preferred ubuntu mirror
Otto Moerbeek [Tue, 16 May 2023 07:33:28 +0000 (09:33 +0200)]
secpoll check: use preferred ubuntu mirror
romeroalx [Tue, 16 May 2023 09:18:13 +0000 (11:18 +0200)]
Merge pull request #12831 from Habbie/apt-no-qq
Fix error retrieving firefox package from ubuntu repo by removing it.
Peter van Dijk [Tue, 16 May 2023 07:38:36 +0000 (09:38 +0200)]
get rid of firefox
Peter van Dijk [Tue, 16 May 2023 07:30:54 +0000 (09:30 +0200)]
more apt no -qq
Peter van Dijk [Tue, 16 May 2023 07:18:00 +0000 (09:18 +0200)]
apt no qq