]>
git.ipfire.org Git - thirdparty/dovecot/core.git/log
Timo Sirainen [Tue, 25 Jan 2022 14:53:14 +0000 (15:53 +0100)]
indexer, global: Change protocol names in VERSION line
Dovecot IPC protocols generally use the -server and -client suffix.
Timo Sirainen [Tue, 25 Jan 2022 22:11:13 +0000 (23:11 +0100)]
indexer: Fix handling indexing requests while the request is being worked on
The request was always prepended to the head of the queue, even if it wasn't
asked for.
Timo Sirainen [Tue, 25 Jan 2022 17:12:56 +0000 (18:12 +0100)]
fts: fts_indexer_cmd() - Fix wrong handshake
This was used only by fts-lucene to send OPTIMIZE command.
Broken by
b4827bc2f2c99029e8524e0c57228124dd22de52
Timo Sirainen [Wed, 15 Dec 2021 02:02:57 +0000 (03:02 +0100)]
lib-storage: If mailbox list index refresh fails due to I/O error, don't try to handle corruption
The list index may not have the latest state, so corruption handling could
be breaking it further.
Timo Sirainen [Wed, 15 Dec 2021 01:58:37 +0000 (02:58 +0100)]
lib-storage: Fix caching mailbox list index refresh failure
If refresh fails (e.g. lock timeout), the following refresh within the same
ioloop_timeval succeeded. This could have resulted wrongly thinking a
mailbox didn't exist when it actually did.
Timo Sirainen [Tue, 14 Dec 2021 21:47:50 +0000 (22:47 +0100)]
lib-storage: Fix error handling if metadata lookup fails from mailbox list index
The error was handled as success. Fixes at least:
Panic: file mail-storage.c: line 2207 (mailbox_get_metadata): assertion failed: ((items & MAILBOX_METADATA_GUID) == 0 || !guid_128_is_empty(metadata_r->guid))
Karl Fleischmann [Wed, 9 Feb 2022 09:10:11 +0000 (10:10 +0100)]
imap: Remove X-CANCEL command
This was a Dovecot-specific extension that was never used by any
clients. Having it available might expose bugs, so it's better to just
remove it.
Karl Fleischmann [Wed, 9 Feb 2022 09:04:36 +0000 (10:04 +0100)]
imap: Remove X-STATE command
This was a Dovecot-specific extension that never even worked. It simply
answered "NO Command is disabled for now."
Marco Bettini [Fri, 11 Feb 2022 08:17:58 +0000 (09:17 +0100)]
indexer: indexer_client_status_callback() - Fix accessing freed memory
Broken by
a9683d7b3
Marco Bettini [Thu, 10 Feb 2022 16:37:59 +0000 (17:37 +0100)]
lib-storage: imapc_mailbox_close() - Remove unprocessed untagged_fetch_contexts
Marco Bettini [Thu, 10 Feb 2022 15:26:10 +0000 (16:26 +0100)]
lib-storage: Remove trainling spaces
Timo Sirainen [Thu, 29 Apr 2021 18:09:01 +0000 (21:09 +0300)]
doveadm deduplicate: Simplify code by using doveadm_mail_iter_deinit_sync()
Timo Sirainen [Thu, 29 Apr 2021 18:05:40 +0000 (21:05 +0300)]
doveadm deduplicate: Optimize by deduplicating in a single transaction
Markus Valentin [Wed, 2 Feb 2022 15:58:24 +0000 (16:58 +0100)]
imapc: imapc_sync_handle_untagged_fetches() - Commit after adding the untagged fetch messages
The absence of the commit could have caused issues when
imapc_sync_finish() was not called as it left mbox->delayed_sync_trans
initialized but mbox->delayed_sync_view was NULL.
Broken by
55a8c2d294bb2f764209c7ce455d258b2b7506f5
Timo Sirainen [Wed, 9 Feb 2022 08:04:01 +0000 (10:04 +0200)]
doveadm kick: Run anvil commands in a sub-ioloop
Running in main ioloop can cause unexpected IO to happen, which can lead to
crashes.
Marco Bettini [Mon, 7 Feb 2022 15:04:41 +0000 (16:04 +0100)]
indexer: Fix memory leak on indexer timeout
Marco Bettini [Wed, 9 Feb 2022 13:20:47 +0000 (14:20 +0100)]
doveadm: doveadm_who_iter_init() - Fix for handle leak on the fail path
Timo Sirainen [Wed, 2 Feb 2022 13:31:39 +0000 (15:31 +0200)]
man: Update kick/who/proxy man pages
Timo Sirainen [Tue, 1 Feb 2022 15:42:02 +0000 (16:42 +0100)]
config: Log a warning if service ipc is used in config
Timo Sirainen [Tue, 1 Feb 2022 15:39:57 +0000 (16:39 +0100)]
lib-master, global: anvil_client_query() - Add type safety to callback's context
Timo Sirainen [Fri, 21 Jan 2022 09:27:47 +0000 (10:27 +0100)]
global: Write pid_t as unsigned number where it might end up used with kill()
pid_t is signed, so usually it's been written to strings as signed long.
The actual pid values should never be negative, so practically it shouldn't
matter if it's written as signed or unsigned. However, due to bugs it's
theoretically possible that some garbage value gets written out.
kill() handles negative PIDs by killing entire process groups. By writing
pid_t as unsigned number we can prevent any (theoretical) issues where
kill() ends up killing entire process groups.
Change only some of the places to unsigned where the value might end up
used for kill(). Usually the signed writing is used only for log messages
where it might be more useful to see the negative numbers clearly
(especially -1 as unknown/unset might be used somewhere).
Timo Sirainen [Tue, 18 Jan 2022 14:34:25 +0000 (15:34 +0100)]
anvil: Add command, user-kick and user-list counts to ps title
This may be useful in debugging any potential performance issues with the
anvil process.
Timo Sirainen [Mon, 17 Jan 2022 14:29:41 +0000 (15:29 +0100)]
lib-master, global: anvil_client_query() - Add timeout parameter
The default kick command timeout should be larger than the lookup timeout.
Timo Sirainen [Mon, 17 Jan 2022 14:23:47 +0000 (15:23 +0100)]
lib-master: anvil-client - Change timeout to be query-specific
Timo Sirainen [Thu, 13 Jan 2022 14:54:18 +0000 (16:54 +0200)]
imap: Add client.unhibernated boolean
Timo Sirainen [Sun, 10 Oct 2021 00:23:13 +0000 (03:23 +0300)]
lib-master, ipc: Remove all code related to ipc process
Timo Sirainen [Tue, 11 Jan 2022 09:40:27 +0000 (11:40 +0200)]
login-common: Optimize kicking proxy connections by username
Track proxy connections by username in a hash table. Kicking only needs to
do a hash lookup from there to find the user's all sessions. Only detached
proxies are tracked this way. It's likely not worth the trouble to track
non-detached pending proxies in this way, since normally there shouldn't be
many of them.
Timo Sirainen [Sun, 10 Oct 2021 00:24:54 +0000 (03:24 +0300)]
login-common: Remove support for ipc process commands
These commands are now accessible via anvil / admin-client.
Timo Sirainen [Sun, 10 Oct 2021 22:44:02 +0000 (01:44 +0300)]
director: Kick users via anvil
Timo Sirainen [Tue, 4 Jan 2022 16:03:41 +0000 (18:03 +0200)]
director: Add user_director_hash field to passdb lookup replies
This can be used as alt-username to kick users by the hash.
Timo Sirainen [Sun, 10 Oct 2021 00:21:10 +0000 (03:21 +0300)]
doveadm: Change "proxy list/kick" to be aliases to "who/kick" commands
Timo Sirainen [Tue, 18 Jan 2022 12:36:45 +0000 (13:36 +0100)]
doveadm who: Rename "proto" field to "service"
That's what it now actually contains.
Timo Sirainen [Mon, 17 Jan 2022 11:18:00 +0000 (12:18 +0100)]
doveadm kick: Add -h <dest-host> parameter
Timo Sirainen [Wed, 12 Jan 2022 15:40:37 +0000 (17:40 +0200)]
doveadm who/kick: Handle number parameter as a username rather than IP address
Timo Sirainen [Wed, 12 Jan 2022 15:37:30 +0000 (17:37 +0200)]
doveadm kick: Print usage on bad parameters
Timo Sirainen [Thu, 13 Jan 2022 16:52:22 +0000 (18:52 +0200)]
doveadm kick: Change output format to only print number of connections kicked
Having the list of usernames kicked is a bit excessive and it also hides
how many connections were kicked.
The output also wasn't correct when kicking based on alt-username, because
it only printed the alt-username rather than the real usernames.
Timo Sirainen [Tue, 11 Jan 2022 12:25:18 +0000 (14:25 +0200)]
doveadm kick: Avoid listing all connections for simple kick filters
Timo Sirainen [Tue, 11 Jan 2022 12:17:46 +0000 (14:17 +0200)]
doveadm who/kick: Add support for -f <passdb-field> parameter
This is similar to what "doveadm proxy kick" has, i.e. list/kick users
based on their alternative usernames (user_* passdb fields).
Timo Sirainen [Tue, 11 Jan 2022 10:25:18 +0000 (12:25 +0200)]
doveadm kick: Rewrite to use anvil KICK-USER command
Removed the "force" parameter, because it's no longer necessary.
Timo Sirainen [Tue, 25 Jan 2022 12:49:15 +0000 (13:49 +0100)]
imap-hibernate: Change anvil service from imap to imap-hibernate
This is better now that anvil can internally separate the service from
protocol.
Timo Sirainen [Tue, 18 Jan 2022 12:42:51 +0000 (13:42 +0100)]
anvil: Track service and protocol separately
This way anvil can track e.g. "imap" and "imap-hibernate" services
separately, but still count them in the same "imap" protocol towards
mail_max_userip_connections.
Timo Sirainen [Tue, 11 Jan 2022 10:11:31 +0000 (12:11 +0200)]
anvil: Add optional conn-guid parameter to KICK-USER command
Timo Sirainen [Wed, 8 Dec 2021 00:35:37 +0000 (02:35 +0200)]
anvil: Implement KICK-USER and KICK-ALT-USER commands
Timo Sirainen [Wed, 8 Dec 2021 00:05:46 +0000 (02:05 +0200)]
anvil: Change to run the process as root and without chroot
The KICK-USER command needs to be able to connect to other processes' admin
sockets and to send signals to other processes.
Timo Sirainen [Mon, 3 Jan 2022 17:38:54 +0000 (19:38 +0200)]
anvil: Add admin_cmd_send()
This can use either incoming or outgoing connections for sending the
command.
Timo Sirainen [Mon, 27 Dec 2021 15:03:37 +0000 (17:03 +0200)]
anvil: Add admin-client API with connection pooling
Timo Sirainen [Mon, 3 Jan 2022 16:43:04 +0000 (18:43 +0200)]
anvil: Add support for sending commands to anvil client connections
Timo Sirainen [Mon, 27 Dec 2021 15:42:27 +0000 (17:42 +0200)]
anvil: Add anvil_connection_find()
Timo Sirainen [Wed, 5 Jan 2022 22:17:42 +0000 (00:17 +0200)]
login-common: Implement KICK-USER incoming anvil command
Timo Sirainen [Tue, 4 Jan 2022 16:28:22 +0000 (18:28 +0200)]
lib-master: anvil-client - Add support for handling incoming commands
Timo Sirainen [Thu, 13 Jan 2022 15:17:28 +0000 (17:17 +0200)]
lib-master, login-common: anvil_client_init() - Change callback to struct of callbacks
Timo Sirainen [Wed, 5 Jan 2022 21:36:45 +0000 (23:36 +0200)]
anvil: Change VERSION line to be bidirectional and add -client/server suffix
This makes it more similar to other internal protocols, and allows using
connection API more easily.
Timo Sirainen [Wed, 5 Jan 2022 22:00:21 +0000 (00:00 +0200)]
lib-master: anvil-client - Convert to connection API
Timo Sirainen [Wed, 5 Jan 2022 21:58:52 +0000 (23:58 +0200)]
lib-master: anvil-client - Delay ostream error handling
There's no need to handle write errors immediately. It just makes the code
more complex.
Timo Sirainen [Wed, 5 Jan 2022 21:12:56 +0000 (23:12 +0200)]
lib-master: anvil-client - Use struct connection
Timo Sirainen [Wed, 22 Dec 2021 21:20:57 +0000 (23:20 +0200)]
anvil: Add handshake with service name and PID for non-FIFO connections
This is in preparation for assuming that incoming anvil connections can also
be used to send admin commands for processes. Instead of connecting to the
process's admin UNIX socket, anvil can instead use the existing connection.
The PID is used to identify which admin connections are available.
When the handshake is used, multiplex iostream is enabled.
Timo Sirainen [Wed, 22 Dec 2021 21:09:25 +0000 (23:09 +0200)]
anvil: Convert to using connection API
Anvil connections can optionally be FIFOs. This causes some difficulties
with the connection API, so everything couldn't be fully converted.
Timo Sirainen [Wed, 22 Dec 2021 10:40:58 +0000 (12:40 +0200)]
anvil: Use struct connection for the anvil client
Timo Sirainen [Thu, 16 Dec 2021 02:50:09 +0000 (04:50 +0200)]
anvil, doveadm: Add alt usernames to CONNECT-DUMP output
Timo Sirainen [Tue, 1 Feb 2022 15:22:47 +0000 (16:22 +0100)]
doveadm who: Improve error handling
Avoid i_fatal(), but still fail with non-zero exit code.
Timo Sirainen [Thu, 16 Dec 2021 02:48:40 +0000 (04:48 +0200)]
doveadm: Replace who_lookup() with iterator API
Timo Sirainen [Mon, 17 Jan 2022 11:08:29 +0000 (12:08 +0100)]
login-common: Send proxy session destination IP to anvil
Timo Sirainen [Mon, 17 Jan 2022 11:06:50 +0000 (12:06 +0100)]
lib-master: master_service_anvil_connect() - Add support for proxy session destination IP
Timo Sirainen [Tue, 18 Jan 2022 14:10:00 +0000 (15:10 +0100)]
anvil: Don't track proxy connections in userip_hash
Otherwise proxy connections would also be counted towards tracking
mail_max_userip_connections, which could cause the same session to be
counted multiple times.
Timo Sirainen [Mon, 17 Jan 2022 10:59:30 +0000 (11:59 +0100)]
anvil, doveadm: Add support for tracking proxy session destination IP
Timo Sirainen [Wed, 12 Jan 2022 15:34:51 +0000 (17:34 +0200)]
login-common: Send alt usernames to anvil
Timo Sirainen [Wed, 12 Jan 2022 15:25:23 +0000 (17:25 +0200)]
lib-master: master_service_anvil_connect() - Add support for alt usernames
Timo Sirainen [Wed, 15 Dec 2021 23:58:35 +0000 (01:58 +0200)]
anvil: Add support for tracking alternative usernames
Timo Sirainen [Wed, 15 Dec 2021 11:41:32 +0000 (13:41 +0200)]
lib-master, global: Send kick-type for anvil CONNECT
Timo Sirainen [Wed, 15 Dec 2021 23:51:24 +0000 (01:51 +0200)]
anvil: Add test-connect-limit
Timo Sirainen [Mon, 17 Jan 2022 22:25:09 +0000 (23:25 +0100)]
anvil: Add kick-type parameter for CONNECT
This indicates how the process supports kicking users.
Timo Sirainen [Thu, 13 Jan 2022 14:42:31 +0000 (16:42 +0200)]
anvil: Split off session_[un]link_process()
Timo Sirainen [Mon, 17 Jan 2022 22:31:40 +0000 (23:31 +0100)]
lib-master, anvil: [DIS]CONNECT - Move conn-guid to being the first parameter
It uniquely identifies the connection, so it's clearer that it's the first
parameter.
Timo Sirainen [Wed, 15 Dec 2021 22:46:58 +0000 (00:46 +0200)]
anvil, doveadm: Require conn-guid to be set for CONNECT
This removes the need for refcount tracking.
Timo Sirainen [Mon, 7 Feb 2022 10:41:02 +0000 (11:41 +0100)]
anvil: connect-limit - Add API for iterating user's all connections
Timo Sirainen [Wed, 15 Dec 2021 13:39:23 +0000 (15:39 +0200)]
anvil: connect-limit - Keep track of all sessions per user
Timo Sirainen [Wed, 8 Dec 2021 00:25:39 +0000 (02:25 +0200)]
anvil: connect-limit - Keep track of all sessions per process
Timo Sirainen [Wed, 19 Jan 2022 23:09:58 +0000 (00:09 +0100)]
submission: Change kick log message to "Server shutting down"
This way it's the same as with imap and pop3.
Timo Sirainen [Thu, 13 Jan 2022 16:09:51 +0000 (18:09 +0200)]
submission: Add admin-client with KICK-USER command
Timo Sirainen [Thu, 13 Jan 2022 16:07:02 +0000 (18:07 +0200)]
pop3: Add admin-client with KICK-USER command
Timo Sirainen [Thu, 13 Jan 2022 16:03:00 +0000 (18:03 +0200)]
imap: Add admin-client with KICK-USER command
Timo Sirainen [Sat, 9 Oct 2021 21:03:20 +0000 (00:03 +0300)]
login-common: Add admin-client with KICK-USER command
Timo Sirainen [Thu, 6 Jan 2022 11:34:09 +0000 (13:34 +0200)]
login-common: Add login_proxy_kick_user_connection()
Timo Sirainen [Sat, 9 Oct 2021 21:22:03 +0000 (00:22 +0300)]
login-common: Split off more generic login_proxy_kick_user/alt/host()
Move the IPC-specific command input/output handling to the caller, so
these functions just do the main work of kicking.
Timo Sirainen [Wed, 8 Dec 2021 00:03:45 +0000 (02:03 +0200)]
login-common: Track proxied connections in anvil
Timo Sirainen [Sun, 12 Dec 2021 23:26:21 +0000 (01:26 +0200)]
global: Send connection GUIDs to anvil
Timo Sirainen [Sun, 12 Dec 2021 23:22:31 +0000 (01:22 +0200)]
anvil, doveadm: Add support for connection GUIDs
These are anvil-specific GUIDs that can be used to refer to a specific
connection.
Timo Sirainen [Sun, 12 Dec 2021 23:17:13 +0000 (01:17 +0200)]
anvil, doveadm: Simplify CONNECT-DUMP output format
Timo Sirainen [Sun, 12 Dec 2021 22:58:24 +0000 (00:58 +0200)]
anvil, global: Split CONNECT/DISCONNECT/LOOKUP ident to separate parameters
Timo Sirainen [Sun, 12 Dec 2021 23:11:56 +0000 (01:11 +0200)]
global: Increase anvil protocol major version number
The following changes break the backwards compatibility.
Timo Sirainen [Sun, 12 Dec 2021 22:56:12 +0000 (00:56 +0200)]
lib-master, global: Replace master_service_anvil_send() with explicit connect/disconnect()
Timo Sirainen [Sun, 12 Dec 2021 22:52:49 +0000 (00:52 +0200)]
global: Assume anvil command was success only if master_service_anvil_send() returns TRUE
Timo Sirainen [Sun, 12 Dec 2021 22:52:34 +0000 (00:52 +0200)]
lib-master: master_service_anvil_send() - Return TRUE if command was actually sent
Timo Sirainen [Wed, 15 Dec 2021 13:15:34 +0000 (15:15 +0200)]
anvil: Store service strings in a reference counted table
There are only a few different services, so there's no need to duplicate the
memory usage for each of the string instances.
Timo Sirainen [Wed, 15 Dec 2021 12:57:31 +0000 (14:57 +0200)]
anvil: Initialize session_lookup struct directly
Timo Sirainen [Wed, 15 Dec 2021 12:55:40 +0000 (14:55 +0200)]
anvil: Rename "i" variables to "session"
Timo Sirainen [Wed, 15 Dec 2021 12:54:18 +0000 (14:54 +0200)]
anvil: Rename struct ident_pid to struct session
Timo Sirainen [Sun, 12 Dec 2021 17:36:37 +0000 (19:36 +0200)]
anvil: Change connect-limit API to use struct rather than ident string
Timo Sirainen [Mon, 3 Jan 2022 17:27:51 +0000 (19:27 +0200)]
anvil: Split off main_init() and main_deinit()
Timo Sirainen [Thu, 13 Jan 2022 16:03:32 +0000 (18:03 +0200)]
imap: Avoid sending untagged BYE in the middle of command output
This could have caused the untagged BYE to be sent in the middle of e.g.
FETCH command output if the session was kicked out.