]>
git.ipfire.org Git - thirdparty/freeradius-server.git/log
Alan T. DeKok [Wed, 6 Aug 2025 15:43:43 +0000 (11:43 -0400)]
revisit and clean up destructor vs shutdown
shutdown can be called on fatal error, and only stops the BIO.
the underlying BIO is still there. This allows it to be called
from a BIO which is in the middle of a chain.
destructor calls shutdown first, and then frees the resources.
this allows a destructor to be called from anywhere, and then the
entire chain is shut down
Alan T. DeKok [Wed, 6 Aug 2025 14:59:08 +0000 (10:59 -0400)]
clean up shutdown and destructor
some shutdowns can fail, so the function needs to return an rcode.
the destructors should just call the shutdown, so the caller can
just talloc_free() things, and have it all work properly.
the shutdown doesn't need to reset the destructors, as the main
fr_bio_shutdown() will do that.
Alan T. DeKok [Wed, 6 Aug 2025 12:22:27 +0000 (08:22 -0400)]
update sbuff macros to catch more corner cases
FR_SBUFF_IN() is for reading from the sbuff.
FR_SBUFF_OUT() is for writing to the sbuff.
Using the same description for both is very confusing. Allowing
a writeable sbuff to take 'char const*' input is bad.
Alan T. DeKok [Wed, 6 Aug 2025 12:22:08 +0000 (08:22 -0400)]
hoist common checks to macro
Alan T. DeKok [Wed, 6 Aug 2025 11:48:23 +0000 (07:48 -0400)]
use the correct sbuff macro.
OUT is for printing, IN is for parsing pre-existing data.
Alan T. DeKok [Wed, 6 Aug 2025 11:48:23 +0000 (07:48 -0400)]
use the correct sbuff macro.
Nick Porter [Wed, 6 Aug 2025 08:53:51 +0000 (09:53 +0100)]
Ensure fr_bio_fd_open returns an error when there is one
Arran Cudbard-Bell [Tue, 5 Aug 2025 18:01:17 +0000 (12:01 -0600)]
WS
Arran Cudbard-Bell [Tue, 5 Aug 2025 18:00:55 +0000 (12:00 -0600)]
Add another Calix VSA we observed in the wild
Nick Porter [Tue, 5 Aug 2025 14:30:53 +0000 (15:30 +0100)]
Use better method for un-marshalling Perl values to pairs
Nick Porter [Tue, 5 Aug 2025 13:54:33 +0000 (14:54 +0100)]
No need to talloc a temporary box
Nick Porter [Tue, 5 Aug 2025 12:36:31 +0000 (13:36 +0100)]
Cast ruby string length to a consistent type
Nick Porter [Tue, 5 Aug 2025 11:30:19 +0000 (12:30 +0100)]
Add test using float value in mRuby
Nick Porter [Tue, 5 Aug 2025 11:29:39 +0000 (12:29 +0100)]
Better method of un-marshalling values from mRuby to FreeRADIUS
Alan T. DeKok [Mon, 4 Aug 2025 21:52:37 +0000 (17:52 -0400)]
first attempt at limiting the source port for %radius.sendto.ipaddr()
the code is commented out for now, as it is a change of behavior
Alan T. DeKok [Mon, 4 Aug 2025 20:57:10 +0000 (16:57 -0400)]
fix typo
Alan T. DeKok [Mon, 4 Aug 2025 20:57:00 +0000 (16:57 -0400)]
add documentation for states
Alan T. DeKok [Mon, 4 Aug 2025 14:44:49 +0000 (10:44 -0400)]
add function to create total order of attributes
Nick Porter [Mon, 4 Aug 2025 18:29:53 +0000 (19:29 +0100)]
UNUSED
Nick Porter [Mon, 4 Aug 2025 18:24:45 +0000 (19:24 +0100)]
FreeBSD has accept4()
Nick Porter [Mon, 4 Aug 2025 17:20:37 +0000 (18:20 +0100)]
Ensure we depend on non-broken libkqueue
Some .deb platforms package libkqueue 2.3.1
Nick Porter [Mon, 4 Aug 2025 16:38:32 +0000 (17:38 +0100)]
Simplify .deb ssl dependency logic
since we require OpenSSL >= 3.0
Alan T. DeKok [Mon, 4 Aug 2025 13:07:12 +0000 (09:07 -0400)]
add attribute type 'attr' and test VALUE
not used for anything yet, because the encoder / decoder do not
support it
Alan T. DeKok [Mon, 4 Aug 2025 12:49:34 +0000 (08:49 -0400)]
allow '@' references for value box parser
the reference can't change dictionaries
Alan T. DeKok [Mon, 4 Aug 2025 12:49:06 +0000 (08:49 -0400)]
add da root to value-box parser for VALUE
Alan T. DeKok [Mon, 4 Aug 2025 12:48:36 +0000 (08:48 -0400)]
add character set for allowed names of nested attrs
which is the allowed list for attrs, plus '.'
Alan T. DeKok [Mon, 4 Aug 2025 12:27:57 +0000 (08:27 -0400)]
fix error message
Alan T. DeKok [Sun, 3 Aug 2025 15:36:15 +0000 (11:36 -0400)]
export dict_protocol_reference, and make it take an sbuff
in preparation for other work with @foo in value-boxes
Alan T. DeKok [Sun, 3 Aug 2025 15:18:01 +0000 (11:18 -0400)]
use FR_SBUFF_IN_STR() for common cases
Alan T. DeKok [Sun, 3 Aug 2025 15:12:30 +0000 (11:12 -0400)]
define FR_SBUFF_IN_STR() as a shorthand for IN(foo, strlen(foo))
Alan T. DeKok [Sun, 3 Aug 2025 14:56:33 +0000 (10:56 -0400)]
disallow ::43 as enum names
Alan T. DeKok [Sat, 2 Aug 2025 10:56:41 +0000 (06:56 -0400)]
don't allow copying of cursors
Alan T. DeKok [Sat, 2 Aug 2025 10:53:19 +0000 (06:53 -0400)]
print the input expansion before running the function
not afterwards. this makes it much easier to read the debug output
Alan T. DeKok [Sat, 2 Aug 2025 10:48:31 +0000 (06:48 -0400)]
remove ACCEPTED state.
and more cleanups for accept. We can't re-open an accepted socket
Alan T. DeKok [Fri, 1 Aug 2025 18:45:24 +0000 (14:45 -0400)]
re-add "char const *end" as allowed
Alan T. DeKok [Fri, 1 Aug 2025 18:36:40 +0000 (14:36 -0400)]
add notes about attribute comparisons
Alan T. DeKok [Fri, 1 Aug 2025 12:04:05 +0000 (08:04 -0400)]
hoist initialize output to macro
so we don't have 'ifdef STATIC_ANALYZER' everywhere. And hopefully
then since the initialization is unconditional, the analyzer will
actually figure out that the output is initialized.
Alan T. DeKok [Thu, 31 Jul 2025 17:24:29 +0000 (13:24 -0400)]
remove more "default:", and add more "case FR_TYPE_ATTR:"
Alan T. DeKok [Thu, 31 Jul 2025 17:22:02 +0000 (13:22 -0400)]
use dictionary function to compare two attributes
comparing by only the leaf attr was arguably wrong, as it ignored
any depth or parenting.
we use an fr_dict function to do the comparison. But that just
compares the pointers, and isn't stable. Arguably that should
be fixed, too.
The fix depends on whether we want to just sort different attributes,
or whether we want to order them. If we're just sorting them, then
the current code is OK.
Alan T. DeKok [Thu, 31 Jul 2025 17:21:39 +0000 (13:21 -0400)]
add more size, and assert that max is initialized
Alan T. DeKok [Thu, 31 Jul 2025 16:28:43 +0000 (12:28 -0400)]
unify unsupported cast code
Alan T. DeKok [Wed, 30 Jul 2025 21:21:52 +0000 (17:21 -0400)]
move generic to 1, so that returning -1 is better
Alan T. DeKok [Wed, 30 Jul 2025 11:55:43 +0000 (07:55 -0400)]
don't allow fr_bio_fd_open() to be passed accepted sockets
we will fix fr_bio_fd_accept() in another commit.
Arran Cudbard-Bell [Thu, 31 Jul 2025 22:18:55 +0000 (15:18 -0700)]
remove errant debug call
James Jones [Fri, 31 Jan 2025 19:56:05 +0000 (13:56 -0600)]
Adopt a standard naming convention and signture for debug functions
To get the "dd" debugger command to work without having to create an
wxplicit mapping from type to function either by hand or by runtime
inspection (the latter preventing setting up the command at debugger
startup), the debug functions that dd calls should have a type of
the form
foo_debug(FILE *fp, foo_t const *)
We add the qualifier becausen
* some support functions with extra parameters are meant to be
called by these functions, which pass the additional parameters;
the functions we do call can pass fp along, or in the case of
src/lib/util/dict_print.c, add fp to the context
* fe_dict_attr_t * has three debug functions
* fr_pair_validate_debug() takes a pointer to an array, and
thus can't follow the convention
* virtual_server_{listen, process}_debug() and module_rlm_list_debug()
have *no* parameters
Arran Cudbard-Bell [Thu, 31 Jul 2025 06:48:52 +0000 (23:48 -0700)]
Revert "might as well save the result somewhere"
This reverts commit
67362500acb9860f0175900236c182b4ae78d420 .
Arran Cudbard-Bell [Thu, 31 Jul 2025 06:48:15 +0000 (23:48 -0700)]
Fix shallow copy for FR_TYPE_ATTR
Arran Cudbard-Bell [Thu, 31 Jul 2025 06:48:04 +0000 (23:48 -0700)]
Fix includes
Arran Cudbard-Bell [Thu, 31 Jul 2025 06:47:40 +0000 (23:47 -0700)]
Always check the return value from fr_value_box_copy
Nick Porter [Thu, 31 Jul 2025 17:25:37 +0000 (18:25 +0100)]
Add RADIUS Id and Authenticator to request pair list
Arran Cudbard-Bell [Thu, 31 Jul 2025 04:45:04 +0000 (21:45 -0700)]
Add json.encode regression test for DHCPv4 in RADIUS
Arran Cudbard-Bell [Thu, 31 Jul 2025 04:44:47 +0000 (21:44 -0700)]
The enumv isn't an ancestor of the attribute being printed
Arran Cudbard-Bell [Thu, 31 Jul 2025 04:23:12 +0000 (21:23 -0700)]
When storing an enum for later parsing, we need to store the '::' prefix too
Arran Cudbard-Bell [Thu, 31 Jul 2025 04:22:36 +0000 (21:22 -0700)]
Fix copying FR_TYPE_ATTR
Arran Cudbard-Bell [Thu, 31 Jul 2025 04:22:23 +0000 (21:22 -0700)]
Encoded attributes can be infinitely long, and definitely more than 4 bytes
Arran Cudbard-Bell [Thu, 31 Jul 2025 04:21:47 +0000 (21:21 -0700)]
No reason to add 'da' as part of the cursor struct
Arran Cudbard-Bell [Thu, 31 Jul 2025 04:21:17 +0000 (21:21 -0700)]
Check for vp_attr in PAIR_VERIFY
Arran Cudbard-Bell [Thu, 31 Jul 2025 04:21:03 +0000 (21:21 -0700)]
Can't use verify here, as we're appending half constructed pairs
Arran Cudbard-Bell [Thu, 31 Jul 2025 01:55:05 +0000 (18:55 -0700)]
attr: These conversions are all fine
Arran Cudbard-Bell [Wed, 30 Jul 2025 19:51:56 +0000 (12:51 -0700)]
Add simplified redundant test
Arran Cudbard-Bell [Wed, 30 Jul 2025 19:51:43 +0000 (12:51 -0700)]
Don't spit out errors for blastradius
Nick Porter [Wed, 30 Jul 2025 13:15:16 +0000 (14:15 +0100)]
Add test of %rest() receiving a failure HTTP status code
Nick Porter [Wed, 30 Jul 2025 13:03:28 +0000 (14:03 +0100)]
When %rest() get a failure HTTP status code capture the body in REST-HTTP-Body
Recent correction to rcode handling have resulted in xlats which return
XLAT_ACTION_FAIL having their output disgarded, so the previous
behaviour of %rest() was lost.
This approach gives more consistent behaviour with other xlats, but
still allows access to any errors reported by the server in the reply
body.
Alan T. DeKok [Tue, 29 Jul 2025 17:11:00 +0000 (13:11 -0400)]
move DHCPv6 to use FR_TYPE_ATTR
Alan T. DeKok [Tue, 29 Jul 2025 17:10:32 +0000 (13:10 -0400)]
parse OIDs numerically if we don't know the name
nolade [Tue, 15 Jul 2025 19:21:52 +0000 (15:21 -0400)]
docs-v4: update top-level and sub-section landing pages HIVE 4114/8. Added xrefs, rewrote some intros.
nolade [Thu, 10 Jul 2025 16:35:44 +0000 (12:35 -0400)]
docs-v4: Update Introduction landing page and nav panel HIVE 4114/5
Alan T. DeKok [Tue, 29 Jul 2025 13:42:03 +0000 (09:42 -0400)]
added some more guidance
nolade [Wed, 16 Jul 2025 20:36:31 +0000 (16:36 -0400)]
docs-v4: Fix make docsite errors
Alan T. DeKok [Tue, 29 Jul 2025 13:04:30 +0000 (09:04 -0400)]
switch dhcpv4 to use FR_TYPE_ATTR for Parameter-Request-List
the underlying data type / length of the encoding is defined by
the size of the attribute number, and not by the dictionaries
Alan T. DeKok [Tue, 29 Jul 2025 13:04:10 +0000 (09:04 -0400)]
allow FR_TYPE_ATTR to be passed in as enumv for decoding
Alan T. DeKok [Tue, 29 Jul 2025 11:53:40 +0000 (07:53 -0400)]
decode FR_TYPE_ATTR
Alan T. DeKok [Tue, 29 Jul 2025 11:53:19 +0000 (07:53 -0400)]
print full received data on -xx
Alan T. DeKok [Tue, 29 Jul 2025 10:42:57 +0000 (06:42 -0400)]
verify FR_TYPE_ATTR
Alan T. DeKok [Tue, 29 Jul 2025 10:36:27 +0000 (06:36 -0400)]
don't assert if we fail to instantiate the dictionaries
Alan T. DeKok [Tue, 29 Jul 2025 09:38:54 +0000 (05:38 -0400)]
cleanups and tests
we might as well use "::" for FR_TYPE_ATTR, too. This makes them
look and feel like enums, rather than adding extra-special syntax
Alan T. DeKok [Tue, 29 Jul 2025 09:54:42 +0000 (05:54 -0400)]
be safe when passed a dict root
Nick Porter [Tue, 29 Jul 2025 09:56:51 +0000 (10:56 +0100)]
Add map tests with nested LHS
Nick Porter [Tue, 29 Jul 2025 09:43:05 +0000 (10:43 +0100)]
map_to_request expects the value callback to only create the leaf pair
It does the job of creating any interim structural pairs required
Alan T. DeKok [Tue, 29 Jul 2025 09:00:23 +0000 (05:00 -0400)]
don't call shutdown recursively
Nick Porter [Tue, 29 Jul 2025 08:14:18 +0000 (09:14 +0100)]
Pacify coverity (CID #
1660567 )
Nick Porter [Mon, 28 Jul 2025 16:17:28 +0000 (17:17 +0100)]
Remove libpcre references from docs
Nick Porter [Mon, 28 Jul 2025 16:14:39 +0000 (17:14 +0100)]
Remove feature.regex-pcre from tests
Nick Porter [Thu, 24 Jul 2025 17:35:31 +0000 (18:35 +0100)]
All supported platforms have libpcre2 available
So remove libpcre code
Nick Porter [Thu, 24 Jul 2025 16:40:01 +0000 (17:40 +0100)]
All supported .deb platforms have libpcre2
Arran Cudbard-Bell [Mon, 28 Jul 2025 23:31:17 +0000 (16:31 -0700)]
Don't call fr_bio_shutdown recursively
Alan T. DeKok [Mon, 28 Jul 2025 19:47:51 +0000 (15:47 -0400)]
close and free on shutdown
Alan T. DeKok [Mon, 28 Jul 2025 19:44:37 +0000 (15:44 -0400)]
add FR_TYPE_ATTR
no tests. will do soon.
Alan T. DeKok [Mon, 28 Jul 2025 12:30:58 +0000 (08:30 -0400)]
no need to check for NULL
Alan T. DeKok [Mon, 28 Jul 2025 12:29:26 +0000 (08:29 -0400)]
no need to check for NULL
Alan T. DeKok [Mon, 28 Jul 2025 12:27:59 +0000 (08:27 -0400)]
no need to check for NULL as a special case
Alan T. DeKok [Sat, 26 Jul 2025 18:52:08 +0000 (14:52 -0400)]
might as well allow actions{...} in catch {...}
tho I guess this check should really be a flag in the unlang op
structure.
Alan T. DeKok [Wed, 23 Jul 2025 07:11:05 +0000 (09:11 +0200)]
might as well save the result somewhere
Alan T. DeKok [Mon, 28 Jul 2025 00:27:42 +0000 (20:27 -0400)]
catch many many more corner cases with 'try'
if the input compile_ctx has REJECT or RETURN for an action, AND
there's a "try / catch" for it, we do NOT have the try actions
stay "REJECT" or "RETURN"
also change the behavior so catch { ... } means "catch ALL" of the
rcodes.
the error rcodes are special, too :(
Alan T. DeKok [Sun, 27 Jul 2025 15:38:38 +0000 (11:38 -0400)]
have "try" cache the "catch" instructions
and rearrange the code so that we don't have to skip to the next
catch, it just happens automatically in the interpreter
Alan T. DeKok [Sun, 27 Jul 2025 16:39:14 +0000 (12:39 -0400)]
remove unused macro
Alan T. DeKok [Sun, 27 Jul 2025 16:07:52 +0000 (12:07 -0400)]
more initialization, and catch corner cases
Alan T. DeKok [Sun, 27 Jul 2025 15:06:38 +0000 (11:06 -0400)]
move unlang_t to use dlists
Alan T. DeKok [Sun, 27 Jul 2025 11:36:26 +0000 (07:36 -0400)]
remove unused function ulang_timeout_section_push()
Alan T. DeKok [Mon, 21 Jul 2025 12:09:31 +0000 (14:09 +0200)]
use section_result to refer to results from push_section()