]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
8 months agoAdd test case from https://github.com/FreeRADIUS/freeradius-server/issues/5462
Arran Cudbard-Bell [Wed, 27 Nov 2024 23:33:35 +0000 (17:33 -0600)] 
Add test case from https://github.com/FreeRADIUS/freeradius-server/issues/5462

8 months agoUse memory safe functions when searching for needles
Arran Cudbard-Bell [Wed, 27 Nov 2024 23:08:37 +0000 (17:08 -0600)] 
Use memory safe functions when searching for needles

Probably slightly higher performance

8 months agopass the current sbuff, not the parent one
Alan T. DeKok [Wed, 27 Nov 2024 16:36:28 +0000 (11:36 -0500)] 
pass the current sbuff, not the parent one

8 months agoreset the input pointer if it changes. Fixex #5462
Alan T. DeKok [Wed, 27 Nov 2024 16:30:29 +0000 (11:30 -0500)] 
reset the input pointer if it changes.  Fixex #5462

There are larger underlying problems, though.  The API to
fr_sbuff_terminal_search() is wrong.  It accepts an input pointer
"p", which points to somewhere in the middle of the sbuff.

As a result, if the sbuff is shifted due to reads, the sbuff->p
pointer changes, and the "cached" p passed to fr_sbuff_terminal_search()
points to somewhere wild.

As a result, most _callers_ of fr_sbuff_terminal_search() are
likely wrong, too, as they cache p = sbuff->p, and don't expect
that pointer to change under them.

8 months agohelper macro for laziness
Alan T. DeKok [Wed, 27 Nov 2024 16:30:13 +0000 (11:30 -0500)] 
helper macro for laziness

8 months agoBuild eap round data if needed
Nick Porter [Wed, 27 Nov 2024 15:34:36 +0000 (15:34 +0000)] 
Build eap round data if needed

If eap is called in `send Access-Reject` and the reject is caused by
something before the eap module is called, then the eap round data has
not been built.

Without this data, the fake eap Failure message can't be correctly
constructed.

8 months agoCorrect freeing of Cassandra results
Nick Porter [Wed, 27 Nov 2024 12:30:06 +0000 (12:30 +0000)] 
Correct freeing of Cassandra results

8 months agoIn-progress eap returns ok or updated
Nick Porter [Wed, 27 Nov 2024 12:03:21 +0000 (12:03 +0000)] 
In-progress eap returns ok or updated

Adjust default policy to reflect that - usually it makes no sense to
call data stores etc part way through eap.

8 months agoFree Cassandra statement after executing
Nick Porter [Wed, 27 Nov 2024 12:01:33 +0000 (12:01 +0000)] 
Free Cassandra statement after executing

8 months agoEnsure arg is initialised
Nick Porter [Wed, 27 Nov 2024 08:47:18 +0000 (08:47 +0000)] 
Ensure arg is initialised

8 months agoDoxygen fix ups
Nick Porter [Wed, 27 Nov 2024 08:47:01 +0000 (08:47 +0000)] 
Doxygen fix ups

8 months agoUpdate sample SQL module config now all drivers use trunks
Nick Porter [Tue, 26 Nov 2024 21:03:03 +0000 (21:03 +0000)] 
Update sample SQL module config now all drivers use trunks

8 months agoRemove pool from SQL instance data
Nick Porter [Tue, 26 Nov 2024 17:44:26 +0000 (17:44 +0000)] 
Remove pool from SQL instance data

8 months agoRemove un-used code
Nick Porter [Tue, 26 Nov 2024 17:42:23 +0000 (17:42 +0000)] 
Remove un-used code

8 months agoRemove rlm_sql_handle_t
Nick Porter [Tue, 26 Nov 2024 17:41:13 +0000 (17:41 +0000)] 
Remove rlm_sql_handle_t

8 months agoRemove legacy query functions
Nick Porter [Tue, 26 Nov 2024 17:35:27 +0000 (17:35 +0000)] 
Remove legacy query functions

8 months agoRemove legacy functions from sql driver data
Nick Porter [Tue, 26 Nov 2024 13:50:07 +0000 (13:50 +0000)] 
Remove legacy functions from sql driver data

8 months agoRemove SQL pool connection function
Nick Porter [Tue, 26 Nov 2024 17:27:56 +0000 (17:27 +0000)] 
Remove SQL pool connection function

8 months agoConvert rlm_sql_null to trunk connections
Nick Porter [Tue, 26 Nov 2024 13:47:15 +0000 (13:47 +0000)] 
Convert rlm_sql_null to trunk connections

8 months agoRemove handle from sql_escape_uctx_t
Nick Porter [Tue, 26 Nov 2024 17:19:00 +0000 (17:19 +0000)] 
Remove handle from sql_escape_uctx_t

8 months agoRemove handle from sqlippool ctxs
Nick Porter [Tue, 26 Nov 2024 13:36:39 +0000 (13:36 +0000)] 
Remove handle from sqlippool ctxs

8 months agoRemove handle from sql_group_xlat_ctx_t
Nick Porter [Tue, 26 Nov 2024 13:32:25 +0000 (13:32 +0000)] 
Remove handle from sql_group_xlat_ctx_t

8 months agoRemove handle from sql_redundant_ctx_t
Nick Porter [Tue, 26 Nov 2024 13:30:59 +0000 (13:30 +0000)] 
Remove handle from sql_redundant_ctx_t

8 months agoRemove handle from sql_autz_ctx_t
Nick Porter [Tue, 26 Nov 2024 17:17:47 +0000 (17:17 +0000)] 
Remove handle from sql_autz_ctx_t

8 months agoRemove handle from fr_sql_query_t
Nick Porter [Tue, 26 Nov 2024 13:25:32 +0000 (13:25 +0000)] 
Remove handle from fr_sql_query_t

8 months agoRemove transitional uses_trunks flag and associated code paths
Nick Porter [Tue, 26 Nov 2024 12:48:47 +0000 (12:48 +0000)] 
Remove transitional uses_trunks flag and associated code paths

All drivers now use trunks

9 months agoRemove defunct EAP policies
Arran Cudbard-Bell [Tue, 26 Nov 2024 15:43:43 +0000 (09:43 -0600)] 
Remove defunct EAP policies

9 months agoUse sqlcli1.h to access connection attribute setting API
Nick Porter [Tue, 26 Nov 2024 12:33:03 +0000 (12:33 +0000)] 
Use sqlcli1.h to access connection attribute setting API

9 months agoRe-work rlm_sql_db2 to use trunks
Nick Porter [Tue, 26 Nov 2024 12:12:59 +0000 (12:12 +0000)] 
Re-work rlm_sql_db2 to use trunks

The client library doesn't support async

9 months agoFix db2 build errors
Nick Porter [Tue, 26 Nov 2024 11:07:49 +0000 (11:07 +0000)] 
Fix db2 build errors

9 months agoencode and decode interface definitions with prefix and scope ID
Alan T. DeKok [Mon, 25 Nov 2024 20:31:32 +0000 (15:31 -0500)] 
encode and decode interface definitions with prefix and scope ID

9 months agoadd test for known vendor and unknown attribute
Alan T. DeKok [Mon, 25 Nov 2024 20:10:09 +0000 (15:10 -0500)] 
add test for known vendor and unknown attribute

9 months agoset prefix for IPs
Alan T. DeKok [Mon, 25 Nov 2024 19:33:18 +0000 (14:33 -0500)] 
set prefix for IPs

9 months agoSimplify sql_error_t
Nick Porter [Mon, 25 Nov 2024 17:05:53 +0000 (17:05 +0000)] 
Simplify sql_error_t

No driver uses the SQL module config when fetching error messages.

9 months agoRe-work rlm_sql_cassandra to work async and use trunks
Nick Porter [Mon, 25 Nov 2024 15:39:00 +0000 (15:39 +0000)] 
Re-work rlm_sql_cassandra to work async and use trunks

9 months agoOnly re-parent query_ctx if there is a cancel mux function
Nick Porter [Mon, 25 Nov 2024 15:33:30 +0000 (15:33 +0000)] 
Only re-parent query_ctx if there is a cancel mux function

9 months agoRemove reference to ancient deprecated function call
Nick Porter [Mon, 25 Nov 2024 14:56:13 +0000 (14:56 +0000)] 
Remove reference to ancient deprecated function call

9 months agoAdd a uctx to fr_sql_query_t
Nick Porter [Mon, 25 Nov 2024 14:33:58 +0000 (14:33 +0000)] 
Add a uctx to fr_sql_query_t

Allowing additional driver specific data needs to be held against a
query ctx.

9 months agoAdd SQL driver flag to allow mulitple queries per connection
Nick Porter [Mon, 25 Nov 2024 14:32:49 +0000 (14:32 +0000)] 
Add SQL driver flag to allow mulitple queries per connection

Whilst most SQL drivers don't allow this, Cassandra does

9 months agoWS
Nick Porter [Mon, 25 Nov 2024 11:36:32 +0000 (11:36 +0000)] 
WS

9 months agoFree old result before looking for the next
Nick Porter [Sat, 23 Nov 2024 15:01:09 +0000 (15:01 +0000)] 
Free old result before looking for the next

Otherwise, the NO_MORE_ROWS response still has the previous result in
query_ctx->row

9 months agoCreate mutable data for Cassandra module instance
Nick Porter [Sat, 23 Nov 2024 14:46:07 +0000 (14:46 +0000)] 
Create mutable data for Cassandra module instance

Module instance data cannot be modified after instantiation - so the
indicator and mutex for initial connection need to be moved to a mutable
structure.

9 months agomod_instantiate doesn't return RLM_SQL_*
Nick Porter [Sat, 23 Nov 2024 13:45:43 +0000 (13:45 +0000)] 
mod_instantiate doesn't return RLM_SQL_*

9 months agoDon't create tls conf section if it's not in the config
Nick Porter [Sat, 23 Nov 2024 13:08:37 +0000 (13:08 +0000)] 
Don't create tls conf section if it's not in the config

9 months agoRemove libcassandra driver options deprecated over 5 years ago
Nick Porter [Sat, 23 Nov 2024 12:06:22 +0000 (12:06 +0000)] 
Remove libcassandra driver options deprecated over 5 years ago

9 months agopop any log we pushed for a virtual server
Alan T. DeKok [Mon, 25 Nov 2024 14:19:15 +0000 (09:19 -0500)] 
pop any log we pushed for a virtual server

9 months agoquiet clang scan
Alan T. DeKok [Mon, 25 Nov 2024 12:57:54 +0000 (07:57 -0500)] 
quiet clang scan

9 months agonote triple-quoted strings, and word smithing
Alan T. DeKok [Sat, 23 Nov 2024 20:19:10 +0000 (15:19 -0500)] 
note triple-quoted strings, and word smithing

9 months agoadd and document "log = ..." in a virtual server.
Alan T. DeKok [Sat, 23 Nov 2024 17:31:51 +0000 (12:31 -0500)] 
add and document "log = ..." in a virtual server.

so each virtual server can add a diffeent logging destination
for all requests which get processed through it

9 months agodon't mash log->file. Or, set it from the input file
Alan T. DeKok [Sat, 23 Nov 2024 17:25:48 +0000 (12:25 -0500)] 
don't mash log->file.  Or, set it from the input file

9 months agotypo
Alan T. DeKok [Sat, 23 Nov 2024 14:37:27 +0000 (09:37 -0500)] 
typo

9 months agotypo
Alan T. DeKok [Sat, 23 Nov 2024 14:36:09 +0000 (09:36 -0500)] 
typo

9 months agowe don't need these tests any more
Alan T. DeKok [Sat, 23 Nov 2024 14:26:36 +0000 (09:26 -0500)] 
we don't need these tests any more

9 months agoremove back-ticks
Alan T. DeKok [Sat, 23 Nov 2024 14:24:26 +0000 (09:24 -0500)] 
remove back-ticks

9 months agomacro to return better errors
Alan T. DeKok [Sat, 23 Nov 2024 14:06:40 +0000 (09:06 -0500)] 
macro to return better errors

9 months agouse num_elements() to get more deterministic encoding
Alan T. DeKok [Sat, 23 Nov 2024 13:51:08 +0000 (08:51 -0500)] 
use num_elements() to get more deterministic encoding

9 months agoit helps to set "triple"
Alan T. DeKok [Fri, 22 Nov 2024 20:55:11 +0000 (15:55 -0500)] 
it helps to set "triple"

9 months agoUpdate sample Oracle driver config
Nick Porter [Fri, 22 Nov 2024 15:18:25 +0000 (15:18 +0000)] 
Update sample Oracle driver config

9 months agoRe-work rlm_sql_oracle to work async with trunks
Nick Porter [Fri, 22 Nov 2024 15:17:35 +0000 (15:17 +0000)] 
Re-work rlm_sql_oracle to work async with trunks

9 months agoParse SQL trunk config before instantiating the driver
Nick Porter [Tue, 19 Nov 2024 17:25:21 +0000 (17:25 +0000)] 
Parse SQL trunk config before instantiating the driver

So the driver can use the parsed options

9 months agoparse triple-quoted strings in expressions
Alan T. DeKok [Fri, 22 Nov 2024 19:17:42 +0000 (14:17 -0500)] 
parse triple-quoted strings in expressions

9 months agoadd terminals and parse rules for triple-quoted strings
Alan T. DeKok [Fri, 22 Nov 2024 19:13:43 +0000 (14:13 -0500)] 
add terminals and parse rules for triple-quoted strings

9 months agoadd missing file
Alan T. DeKok [Fri, 22 Nov 2024 15:44:03 +0000 (10:44 -0500)] 
add missing file

9 months agoadd and document support for tripled-quoted strings
Alan T. DeKok [Fri, 22 Nov 2024 15:38:33 +0000 (10:38 -0500)] 
add and document support for tripled-quoted strings

secret = """foo " bar " baz ! """

9 months agoMove sample certificate checking policy
Nick Porter [Fri, 22 Nov 2024 08:47:27 +0000 (08:47 +0000)] 
Move sample certificate checking policy

The virtual server referenced in mods-available/eap is now "tls-cache",
with certificate verification done in the "verify certificate" section
rather than through the "check-eap-tls" virtual server.

The old sample code gives useful hints as to what could be done in this
section and why.

9 months agoUse v4 section names
Nick Porter [Fri, 22 Nov 2024 08:19:54 +0000 (08:19 +0000)] 
Use v4 section names

9 months agobetter error messages
Alan T. DeKok [Thu, 21 Nov 2024 18:54:55 +0000 (13:54 -0500)] 
better error messages

If I run into a problem because of a typo, and the error message
isn't clear enough to me, then it should be clarified for others, too

9 months agoadd and document aliases which make MS-CHAP easier to configure
Alan T. DeKok [Thu, 21 Nov 2024 18:49:59 +0000 (13:49 -0500)] 
add and document aliases which make MS-CHAP easier to configure

9 months agorefresh after changes
Alan T. DeKok [Thu, 21 Nov 2024 18:47:13 +0000 (13:47 -0500)] 
refresh after changes

9 months agoupdate comments and documentation
Alan T. DeKok [Thu, 21 Nov 2024 18:46:08 +0000 (13:46 -0500)] 
update comments and documentation

9 months agocorrect encoding / decode of prefixes
Alan T. DeKok [Thu, 21 Nov 2024 16:16:23 +0000 (11:16 -0500)] 
correct encoding / decode of prefixes

and add tests

9 months agouse correct values for string / octets
Alan T. DeKok [Thu, 21 Nov 2024 16:15:04 +0000 (11:15 -0500)] 
use correct values for string / octets

they were swapped :(

9 months agoensure that shutdowns are called appropriately, and work
Alan T. DeKok [Wed, 20 Nov 2024 20:25:23 +0000 (15:25 -0500)] 
ensure that shutdowns are called appropriately, and work

the BIO which has produced the fatal error calls the shutdown
routine

9 months agoadd and use OOM error
Alan T. DeKok [Wed, 20 Nov 2024 19:59:54 +0000 (14:59 -0500)] 
add and use OOM error

9 months agofirst try at fr_bio_fd_accept()
Alan T. DeKok [Tue, 19 Nov 2024 20:16:47 +0000 (15:16 -0500)] 
first try at fr_bio_fd_accept()

which creates a new BIO from a parent of type LISTEN

9 months agorework the write_blocked() handlers
Alan T. DeKok [Tue, 19 Nov 2024 19:30:26 +0000 (14:30 -0500)] 
rework the write_blocked() handlers

to match the EOF handlers, so I'm more convinced taht they're
correct.

9 months agoupdate write_blocked() API
Alan T. DeKok [Tue, 19 Nov 2024 19:10:54 +0000 (14:10 -0500)] 
update write_blocked() API

to notify previous BIOs that subsequent ones are blocked.

9 months agothese functions don't need to be public
Alan T. DeKok [Tue, 19 Nov 2024 18:50:25 +0000 (13:50 -0500)] 
these functions don't need to be public

9 months agominor comments
Alan T. DeKok [Tue, 19 Nov 2024 17:50:55 +0000 (12:50 -0500)] 
minor comments

9 months agodon't break out of the loop in all paths
Alan T. DeKok [Tue, 19 Nov 2024 13:22:14 +0000 (08:22 -0500)] 
don't break out of the loop in all paths

we need to continue if the callback says that we can continue

9 months agoAlign Oracle group membership with other DB schemas
Nick Porter [Tue, 19 Nov 2024 09:15:52 +0000 (09:15 +0000)] 
Align Oracle group membership with other DB schemas

9 months agoRemove non-standard tables from Oracle schema
Nick Porter [Tue, 19 Nov 2024 08:17:42 +0000 (08:17 +0000)] 
Remove non-standard tables from Oracle schema

9 months agoAdd missing triggers to Oracle schema
Nick Porter [Tue, 19 Nov 2024 08:15:00 +0000 (08:15 +0000)] 
Add missing triggers to Oracle schema

9 months agoupdate the handling of EOF
Alan T. DeKok [Mon, 18 Nov 2024 18:48:40 +0000 (13:48 -0500)] 
update the handling of EOF

one BIO can tell fr_bio_eof() that it's at EOF.  That function
will take care of calling the various BIO internal EOF functions
until such time as it's at the first BIO.  At which point it will
call the application EOF function.

9 months agoput connect data into its own struct
Alan T. DeKok [Mon, 18 Nov 2024 16:40:25 +0000 (11:40 -0500)] 
put connect data into its own struct

9 months agoremove duplicate section
Alan T. DeKok [Fri, 15 Nov 2024 20:33:52 +0000 (15:33 -0500)] 
remove duplicate section

9 months agoStrip vendor name from attributes
Nick Porter [Fri, 15 Nov 2024 15:38:52 +0000 (15:38 +0000)] 
Strip vendor name from attributes

9 months agoEnsure CONF_SECTION used to create dynamic clients is visible
Nick Porter [Fri, 15 Nov 2024 15:32:00 +0000 (15:32 +0000)] 
Ensure CONF_SECTION used to create dynamic clients is visible

So that %client(<attribute>) works the same for dynamic clients as
static ones

9 months agoport from v3.2.x
Alan T. DeKok [Fri, 15 Nov 2024 14:26:10 +0000 (09:26 -0500)] 
port from v3.2.x

9 months agouse correct value. Fixes #5461
Alan T. DeKok [Fri, 15 Nov 2024 14:21:34 +0000 (09:21 -0500)] 
use correct value.  Fixes #5461

9 months agoupdate fr_bio_fd_connect()
Alan T. DeKok [Thu, 14 Nov 2024 18:46:07 +0000 (13:46 -0500)] 
update fr_bio_fd_connect()

so that it takes and uses callbacks for connections and timeouts.

9 months agoadd descriptions of structural types
Alan T. DeKok [Thu, 14 Nov 2024 21:02:38 +0000 (16:02 -0500)] 
add descriptions of structural types

9 months agoAdd notes on %ldap.group() xlat
Nick Porter [Thu, 14 Nov 2024 11:53:02 +0000 (11:53 +0000)] 
Add notes on %ldap.group() xlat

9 months agoTypos
Nick Porter [Thu, 14 Nov 2024 11:50:27 +0000 (11:50 +0000)] 
Typos

9 months agoOpenSSL 3.4 deprecates SSL_SESSION_get_time
Nick Porter [Wed, 13 Nov 2024 21:33:07 +0000 (21:33 +0000)] 
OpenSSL 3.4 deprecates SSL_SESSION_get_time

9 months agoWe only build against OpenSSL v3.x now
Nick Porter [Wed, 13 Nov 2024 20:56:10 +0000 (20:56 +0000)] 
We only build against OpenSSL v3.x now

9 months agocheck return code
Alan T. DeKok [Wed, 13 Nov 2024 21:17:32 +0000 (16:17 -0500)] 
check return code

9 months agocheck return code
Alan T. DeKok [Wed, 13 Nov 2024 21:03:48 +0000 (16:03 -0500)] 
check return code

9 months agoall for all data types
Alan T. DeKok [Wed, 13 Nov 2024 21:03:26 +0000 (16:03 -0500)] 
all for all data types

9 months agodelete attributes which are no longer necessary
Alan T. DeKok [Wed, 13 Nov 2024 17:59:01 +0000 (12:59 -0500)] 
delete attributes which are no longer necessary