]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
11 months agoCorrect conditions for reparenting query when cancelling trunk request
Nick Porter [Tue, 10 Sep 2024 09:05:43 +0000 (10:05 +0100)] 
Correct conditions for reparenting query when cancelling trunk request

11 months agoEnsure packages are up to date in CI runners
Nick Porter [Mon, 9 Sep 2024 16:31:58 +0000 (17:31 +0100)] 
Ensure packages are up to date in CI runners

11 months agocasr to string
Alan T. DeKok [Mon, 9 Sep 2024 16:38:29 +0000 (12:38 -0400)] 
casr to string

arguably this shouldn't be necessary.  We should update the
parser to handle this case.

11 months agotypos and fixes
Alan T. DeKok [Sun, 8 Sep 2024 14:32:29 +0000 (10:32 -0400)] 
typos and fixes

11 months agoadded missing page
Alan T. DeKok [Sun, 8 Sep 2024 14:13:46 +0000 (10:13 -0400)] 
added missing page

11 months agoupdates and clarifications
Alan T. DeKok [Sun, 8 Sep 2024 14:11:51 +0000 (10:11 -0400)] 
updates and clarifications

11 months agomove function to only place which uses it
Alan T. DeKok [Sun, 8 Sep 2024 13:20:52 +0000 (09:20 -0400)] 
move function to only place which uses it

11 months agotypos
Alan T. DeKok [Sun, 8 Sep 2024 13:16:48 +0000 (09:16 -0400)] 
typos

11 months agoeval should call xlat_tokenize_expression()
Alan T. DeKok [Sat, 7 Sep 2024 16:27:44 +0000 (12:27 -0400)] 
eval should call xlat_tokenize_expression()

instead of xlat_tokenize(), as expressions can have many things
in them, including math.  whereas xlat_tokenize() generally just
tokenizes one string

11 months agomore examples and updates
Alan T. DeKok [Sat, 7 Sep 2024 13:16:42 +0000 (09:16 -0400)] 
more examples and updates

11 months agoMove tls private key password to common code
ethan-thompson [Mon, 9 Sep 2024 15:16:28 +0000 (11:16 -0400)] 
Move tls private key password to common code

Signed-off-by: ethan-thompson <ethan.thompson@networkradius.com>
11 months agoAdd tls error message drain function
ethan-thompson [Mon, 9 Sep 2024 15:15:42 +0000 (11:15 -0400)] 
Add tls error message drain function

Signed-off-by: ethan-thompson <ethan.thompson@networkradius.com>
11 months agoSet a proper error message for private key password callback
ethan-thompson [Mon, 9 Sep 2024 15:15:07 +0000 (11:15 -0400)] 
Set a proper error message for private key password callback

Signed-off-by: ethan-thompson <ethan.thompson@networkradius.com>
11 months agoChange hidden flag value to non-zero
ethan-thompson [Mon, 9 Sep 2024 15:13:28 +0000 (11:13 -0400)] 
Change hidden flag value to non-zero

Signed-off-by: ethan-thompson <ethan.thompson@networkradius.com>
11 months agoAdd CTS DHCPv4 dictionary
Nick Porter [Mon, 9 Sep 2024 10:44:41 +0000 (11:44 +0100)] 
Add CTS DHCPv4 dictionary

11 months agoAnother UBSAN false positive
Nick Porter [Fri, 6 Sep 2024 13:35:55 +0000 (14:35 +0100)] 
Another UBSAN false positive

11 months agoinitialize variable
Alan T. DeKok [Sat, 7 Sep 2024 11:51:54 +0000 (07:51 -0400)] 
initialize variable

11 months agoadd support for foreach ... (%sql("SELECT ...))
Alan T. DeKok [Fri, 6 Sep 2024 21:43:38 +0000 (17:43 -0400)] 
add support for foreach ... (%sql("SELECT ...))

11 months agodon't use unlang keyword as variable name
Alan T. DeKok [Fri, 6 Sep 2024 18:45:04 +0000 (14:45 -0400)] 
don't use unlang keyword as variable name

11 months agolocal variables can't be keywords
Alan T. DeKok [Fri, 6 Sep 2024 15:29:50 +0000 (11:29 -0400)] 
local variables can't be keywords

and move function to later in the file.

11 months agoadd migration flag to test runs, and remove "&" from tests
Alan T. DeKok [Fri, 6 Sep 2024 15:24:03 +0000 (11:24 -0400)] 
add migration flag to test runs, and remove "&" from tests

that's the result of a lot of work.

11 months agoexpose and use tmpl_require_enum_prefix flag
Alan T. DeKok [Fri, 6 Sep 2024 14:45:45 +0000 (10:45 -0400)] 
expose and use tmpl_require_enum_prefix flag

11 months agoprovisions for tmpl_require_enum_prefix=yes
Alan T. DeKok [Fri, 6 Sep 2024 14:28:56 +0000 (10:28 -0400)] 
provisions for tmpl_require_enum_prefix=yes

11 months agouse ::enum here, too
Alan T. DeKok [Fri, 6 Sep 2024 14:27:51 +0000 (10:27 -0400)] 
use ::enum here, too

11 months agoreturn code is signed
Alan T. DeKok [Fri, 6 Sep 2024 14:17:12 +0000 (10:17 -0400)] 
return code is signed

11 months agodocument new syntax and add more examples
Alan T. DeKok [Fri, 6 Sep 2024 13:45:13 +0000 (09:45 -0400)] 
document new syntax and add more examples

11 months agoadd explanation of why we don't want to do certain things
Alan T. DeKok [Fri, 6 Sep 2024 13:44:53 +0000 (09:44 -0400)] 
add explanation of why we don't want to do certain things

11 months agomove to protocol::enum for subrequest
Alan T. DeKok [Thu, 5 Sep 2024 23:56:18 +0000 (19:56 -0400)] 
move to protocol::enum for subrequest

because 'foo.bar' is an attribute reference when there's no "&",
so we can't use "dhcpv4.Discover"

11 months agouse ::enum-name for subrequest enums
Alan T. DeKok [Thu, 5 Sep 2024 17:19:06 +0000 (13:19 -0400)] 
use ::enum-name for subrequest enums

11 months agoAdd match_attr to rlm_files tests
Nick Porter [Thu, 5 Sep 2024 17:16:17 +0000 (18:16 +0100)] 
Add match_attr to rlm_files tests

11 months agoAdd match_attr option to rlm_files
Nick Porter [Thu, 5 Sep 2024 17:15:24 +0000 (18:15 +0100)] 
Add match_attr option to rlm_files

Defines an attribute to populate with the value of the matched entry.

11 months agoTypo
Nick Porter [Thu, 5 Sep 2024 15:58:56 +0000 (16:58 +0100)] 
Typo

11 months agoAdd %ip.v4.netmask() and %ip.v4.broadcast() xlats
Nick Porter [Thu, 5 Sep 2024 15:44:38 +0000 (16:44 +0100)] 
Add %ip.v4.netmask() and %ip.v4.broadcast() xlats

11 months ago"out" is ptr to ptr _only_ for octets / string types
Alan T. DeKok [Thu, 5 Sep 2024 15:53:08 +0000 (11:53 -0400)] 
"out" is ptr to ptr _only_ for octets / string types

11 months agocatch more corner cases of bare words in "case" for non-&
Alan T. DeKok [Thu, 5 Sep 2024 15:45:02 +0000 (11:45 -0400)] 
catch more corner cases of bare words in "case" for non-&

11 months agoupdates to handle tmpl_require_enum_prefix
Alan T. DeKok [Thu, 5 Sep 2024 15:08:43 +0000 (11:08 -0400)] 
updates to handle tmpl_require_enum_prefix

11 months agoarguments to 'case' must be static data
Alan T. DeKok [Thu, 5 Sep 2024 12:48:08 +0000 (08:48 -0400)] 
arguments to 'case' must be static data

and can't be unresolved, as we already pass a data type to the
tmpl parsing code.

11 months agoadd test missed in commit 9578a1bf8
Alan T. DeKok [Thu, 5 Sep 2024 12:46:14 +0000 (08:46 -0400)] 
add test missed in commit 9578a1bf8

11 months agoBetter name for bool
Arran Cudbard-Bell [Thu, 5 Sep 2024 03:30:41 +0000 (21:30 -0600)] 
Better name for bool

11 months agoAdd custom selinux module to our RPMs
Arran Cudbard-Bell [Thu, 5 Sep 2024 03:17:15 +0000 (21:17 -0600)] 
Add custom selinux module to our RPMs

11 months agoRevert "maybe pthread functions are in -lc?"
Arran Cudbard-Bell [Thu, 5 Sep 2024 01:05:18 +0000 (19:05 -0600)] 
Revert "maybe pthread functions are in -lc?"

This reverts commit 54c3e38527e890588a98154ae2b23804008081e4.

12 months agoadd looping over TLVs
Alan T. DeKok [Wed, 4 Sep 2024 15:11:28 +0000 (11:11 -0400)] 
add looping over TLVs

and ensure that we can access child members.

via a small amount of code which is a terrible hack.

12 months agoensure that the data types in "foreach" are compatible
Alan T. DeKok [Wed, 4 Sep 2024 14:58:05 +0000 (10:58 -0400)] 
ensure that the data types in "foreach" are compatible

12 months agoMore trunk connection UBSAN false positives
Nick Porter [Wed, 4 Sep 2024 11:33:51 +0000 (12:33 +0100)] 
More trunk connection UBSAN false positives

12 months agoMore connection_t related UBSAN false positives
Nick Porter [Wed, 4 Sep 2024 10:40:14 +0000 (11:40 +0100)] 
More connection_t related UBSAN false positives

12 months agoUBSAN false positives on trunk connection_alloc calls
Nick Porter [Wed, 4 Sep 2024 09:53:54 +0000 (10:53 +0100)] 
UBSAN false positives on trunk connection_alloc calls

12 months agoMore UBSAN function signature false positives
Nick Porter [Wed, 4 Sep 2024 09:11:56 +0000 (10:11 +0100)] 
More UBSAN function signature false positives

12 months agofr_assert does noting on NDEBUG builds
Nick Porter [Wed, 4 Sep 2024 09:07:33 +0000 (10:07 +0100)] 
fr_assert does noting on NDEBUG builds

So clang scan thinks ref can be NULL

12 months agoCorrect fr_fatal_assert macro
Nick Porter [Wed, 4 Sep 2024 09:04:24 +0000 (10:04 +0100)] 
Correct fr_fatal_assert macro

12 months agoAlterative ipv6 masking to work round alignment issues
Nick Porter [Wed, 4 Sep 2024 08:26:31 +0000 (09:26 +0100)] 
Alterative ipv6 masking to work round alignment issues

12 months agoRevert "add test looping over children of a TLV"
Alan T. DeKok [Tue, 3 Sep 2024 20:18:18 +0000 (16:18 -0400)] 
Revert "add test looping over children of a TLV"

This reverts commit c105db87995ecee180771bc55f4d43a37efed9bd.

apparently adding local tlvs breaks the wimax tests.

Error : src/tests/keywords/wimax[7]: Failed parsing attribute reference &26.24757.84.9.5.7 - Parent type of nested attribute 26 must be of type "struct", "tlv", "vendor", "vsa" or "group", got "octets"
Error : src/tests/keywords/wimax[7]: &26.24757.84.9.5.7
Error : src/tests/keywords/wimax[7]:     ^

arguably the error is correct.  but in the interest of making CI
pass, and not annoying others, we just disable the failing test
for now

12 months agodon't copy children of a group
Alan T. DeKok [Tue, 3 Sep 2024 19:32:03 +0000 (15:32 -0400)] 
don't copy children of a group

12 months agoadd TMP TLV and test
Alan T. DeKok [Tue, 3 Sep 2024 19:05:11 +0000 (15:05 -0400)] 
add TMP TLV and test

12 months agodelete old attributes every time through the loop
Alan T. DeKok [Tue, 3 Sep 2024 18:59:38 +0000 (14:59 -0400)] 
delete old attributes every time through the loop

and minor cleanups

12 months agocopy children of structural attributes
Alan T. DeKok [Tue, 3 Sep 2024 18:32:51 +0000 (14:32 -0400)] 
copy children of structural attributes

to the new local dictionary

12 months agoadd API to copy attributes to a different dictionary
Alan T. DeKok [Tue, 3 Sep 2024 18:31:55 +0000 (14:31 -0400)] 
add API to copy attributes to a different dictionary

12 months agomove assertion to run-time error
Alan T. DeKok [Tue, 3 Sep 2024 16:53:37 +0000 (12:53 -0400)] 
move assertion to run-time error

so that we don't crash when the admin mis-types something

12 months agoadd test looping over children of a TLV
Alan T. DeKok [Tue, 3 Sep 2024 15:49:35 +0000 (11:49 -0400)] 
add test looping over children of a TLV

12 months agocheck if the dictionaries are compatible.
Alan T. DeKok [Tue, 3 Sep 2024 15:37:06 +0000 (11:37 -0400)] 
check if the dictionaries are compatible.

don't check if the ptrs are equal

12 months agodocument attr_prefix and key off of enum value, not '&'
Alan T. DeKok [Tue, 3 Sep 2024 15:25:48 +0000 (11:25 -0400)] 
document attr_prefix and key off of enum value, not '&'

which helps with the migration away from '&'

12 months agoadd assertions to make intent clear
Alan T. DeKok [Tue, 3 Sep 2024 15:24:59 +0000 (11:24 -0400)] 
add assertions to make intent clear

which doesn't change anything, but does help us track the
migration away from '&'

12 months agouse correct names
Alan T. DeKok [Tue, 3 Sep 2024 15:23:11 +0000 (11:23 -0400)] 
use correct names

if we use "bool" for TMPL_ATTR_REF_PREFIX things, then code searches
won't find the right values.

So we explicitly initialize vpt->rules.attr.prefix = YES

12 months agotweak docs to more clearly describe what's happening
Alan T. DeKok [Tue, 3 Sep 2024 15:21:41 +0000 (11:21 -0400)] 
tweak docs to more clearly describe what's happening

12 months agoadd migration flag for tmpl_require_enum_prefix
Alan T. DeKok [Tue, 3 Sep 2024 14:42:25 +0000 (10:42 -0400)] 
add migration flag for tmpl_require_enum_prefix

12 months agoAdd test for DHCPv4 options after Pad Option
Nick Porter [Tue, 3 Sep 2024 17:10:34 +0000 (18:10 +0100)] 
Add test for DHCPv4 options after Pad Option

12 months agoWalk over padding bytes when decoding DHCPv4
Nick Porter [Tue, 3 Sep 2024 17:09:47 +0000 (18:09 +0100)] 
Walk over padding bytes when decoding DHCPv4

Packets are allowed to contain as many bytes of Pad Option as they want.
They have been seen in the wild with 50 bytes of 0, then with more valid
options after...

12 months agoUbuntu 24.04 already uses OpenSSL 3.0
Nick Porter [Tue, 3 Sep 2024 10:16:10 +0000 (11:16 +0100)] 
Ubuntu 24.04 already uses OpenSSL 3.0

12 months agoPacify UBSAN
Nick Porter [Tue, 3 Sep 2024 09:51:05 +0000 (10:51 +0100)] 
Pacify UBSAN

12 months agoConsistent function signature for compile_*
Nick Porter [Tue, 3 Sep 2024 09:47:36 +0000 (10:47 +0100)] 
Consistent function signature for compile_*

Satisifies UBSAN function analysis

12 months agoTypo
Nick Porter [Tue, 3 Sep 2024 07:44:00 +0000 (08:44 +0100)] 
Typo

12 months agogcc doesn't have __has_feature
Nick Porter [Tue, 3 Sep 2024 07:34:29 +0000 (08:34 +0100)] 
gcc doesn't have __has_feature

And the pre-processor appears to parse the whole line before determining
that __clang__ is not defined

12 months agoStart the very long process of placating ubsan
Arran Cudbard-Bell [Tue, 3 Sep 2024 00:55:49 +0000 (18:55 -0600)] 
Start the very long process of placating ubsan

12 months agotypo
Alan T. DeKok [Mon, 2 Sep 2024 21:46:40 +0000 (17:46 -0400)] 
typo

12 months agoenable expressions in attribute array indexes
Alan T. DeKok [Mon, 2 Sep 2024 21:33:49 +0000 (17:33 -0400)] 
enable expressions in attribute array indexes

alonw with test and documentation

12 months agoadd function to evaluate xlat in place, to a type
Alan T. DeKok [Mon, 2 Sep 2024 21:33:18 +0000 (17:33 -0400)] 
add function to evaluate xlat in place, to a type

12 months agoadd function to evaluate xlat in place
Alan T. DeKok [Mon, 2 Sep 2024 20:41:21 +0000 (16:41 -0400)] 
add function to evaluate xlat in place

without returning "yield"

12 months agoremove duplicate casts
Alan T. DeKok [Mon, 2 Sep 2024 18:01:55 +0000 (14:01 -0400)] 
remove duplicate casts

12 months agoCorrect installation of libstdc++
Nick Porter [Mon, 2 Sep 2024 17:33:04 +0000 (18:33 +0100)] 
Correct installation of libstdc++

12 months agoempty strings are empty lists
Alan T. DeKok [Mon, 2 Sep 2024 15:51:21 +0000 (11:51 -0400)] 
empty strings are empty lists

so that we don't get confused when the debug output prints

cmp({},{}) --> false

because it's really instead

cmp({''},{})

which is an empty string on one side, and an empty set on the other.

12 months agojust left-pad with zeros on cast from "too small" octet values
Alan T. DeKok [Mon, 2 Sep 2024 14:22:08 +0000 (10:22 -0400)] 
just left-pad with zeros on cast from "too small" octet values

12 months agodon't mash RHS to one string return the set
Alan T. DeKok [Mon, 2 Sep 2024 14:03:15 +0000 (10:03 -0400)] 
don't mash RHS to one string return the set

12 months agokey off of state, and not just '&'
Alan T. DeKok [Mon, 2 Sep 2024 13:51:15 +0000 (09:51 -0400)] 
key off of state, and not just '&'

12 months ago2nd attempt to clean up "set leaf num" API
Nick Porter [Mon, 2 Sep 2024 15:35:39 +0000 (16:35 +0100)] 
2nd attempt to clean up "set leaf num" API

update section lhs doesn't need &attr changed to &attr[*]

12 months agoRevert "clean up "set leaf num" API"
Alan T. DeKok [Mon, 2 Sep 2024 13:06:39 +0000 (09:06 -0400)] 
Revert "clean up "set leaf num" API"

This reverts commit 3bccf7a70e7cc602a9a2646b538355c8f1cb3ef3.

this breaks the cache_redis tests

12 months agoupdate tokenizer for tmpl_require_enum_prefix
Alan T. DeKok [Mon, 2 Sep 2024 13:03:11 +0000 (09:03 -0400)] 
update tokenizer for tmpl_require_enum_prefix

it still has issues parsing

(byte)Class

because it tries to parse "Class" as data type "byte"

12 months agohoist "set flag" to before we read the config files
Alan T. DeKok [Mon, 2 Sep 2024 12:57:46 +0000 (08:57 -0400)] 
hoist "set flag" to before we read the config files

12 months agodon't let the user delete attributes we're looping over
Alan T. DeKok [Mon, 2 Sep 2024 12:22:36 +0000 (08:22 -0400)] 
don't let the user delete attributes we're looping over

this isn't perfect, but it's good enough.

It can still crash if the user has one "foreach" loop nested
inside of another one, AND both loop over the same attributes,
AND a variable is deleted after the inner "foreach" loop is run.

The general answer then is "don't do that".

We could fix this by using the old way of copying all of the VPs,
looping over the copy, and then moving the copy back in place of
the original VPs.  But that process is expensive, and almost always
not needed.

For now, it's simpler to just say "don't modify the attributes
you're looping over"

12 months agoclean up "set leaf num" API
Alan T. DeKok [Mon, 2 Sep 2024 12:02:05 +0000 (08:02 -0400)] 
clean up "set leaf num" API

we now only have one function instead of two, and it always does
the right thing, even if the tail filter isn't a static number

12 months agocleanups and fixes from previous commit
Alan T. DeKok [Mon, 2 Sep 2024 11:37:13 +0000 (07:37 -0400)] 
cleanups and fixes from previous commit

12 months agojust use function instead of "roll your own" code
Alan T. DeKok [Mon, 2 Sep 2024 11:15:20 +0000 (07:15 -0400)] 
just use function instead of "roll your own" code

which incidentally also handles unknown attributes, too

12 months agoremove unused function
Alan T. DeKok [Mon, 2 Sep 2024 11:10:15 +0000 (07:10 -0400)] 
remove unused function

12 months agoset_leaf_da() should also set leaf filter
Alan T. DeKok [Mon, 2 Sep 2024 11:08:26 +0000 (07:08 -0400)] 
set_leaf_da() should also set leaf filter

12 months agoRevert "Disable -fsanitize=function for htrie functions"
Arran Cudbard-Bell [Mon, 2 Sep 2024 03:16:15 +0000 (21:16 -0600)] 
Revert "Disable -fsanitize=function for htrie functions"

This reverts commit e382c989f2573399ea90eaca5232d11f8fd476d0.

12 months agoDisable -fsanitize=function for htrie functions
Arran Cudbard-Bell [Mon, 2 Sep 2024 02:55:34 +0000 (20:55 -0600)] 
Disable -fsanitize=function for htrie functions

12 months agohtrie callbacks should take a void * as the tree arg type
Arran Cudbard-Bell [Mon, 2 Sep 2024 02:05:45 +0000 (20:05 -0600)] 
htrie callbacks should take a void * as the tree arg type

12 months agoFix compile function signatures
Arran Cudbard-Bell [Mon, 2 Sep 2024 01:31:17 +0000 (19:31 -0600)] 
Fix compile function signatures

12 months agoJust use the latest version of postgresql
Arran Cudbard-Bell [Mon, 2 Sep 2024 00:21:38 +0000 (18:21 -0600)] 
Just use the latest version of postgresql

12 months agoFire insufficient
Arran Cudbard-Bell [Sun, 1 Sep 2024 21:08:19 +0000 (15:08 -0600)] 
Fire insufficient

12 months agoThis is an AND, so won't work
Arran Cudbard-Bell [Sun, 1 Sep 2024 20:57:20 +0000 (14:57 -0600)] 
This is an AND, so won't work

12 months agoBump coverity OS
Arran Cudbard-Bell [Sun, 1 Sep 2024 20:49:00 +0000 (14:49 -0600)] 
Bump coverity OS