Paul Smith [Sat, 3 Mar 2012 18:45:08 +0000 (18:45 +0000)]
Modify backslash/newline handling for POSIX.
We fixed Savannah 16670 but that broke previously-working makefiles
that relied on the GNU make behavior. The POSIX behavior doesn't
seem to me to be better, and can be obtained using GNU make as well,
so put it back as the default behavior and require .POSIX to
get the POSIX behavior.
Add a new section to the manual discussing backslash/newline handling.
Update the test suite.
Eli Zaretskii [Fri, 3 Feb 2012 12:15:56 +0000 (12:15 +0000)]
Fix Savannah bug #34832 with unused TLS attributes.
w32/subproc/w32err.c (map_windows32_error_to_string) [_MSC_VER]:
Don't use TLS storage for szMessageBuffer. Ifdef away special
code for handling Winsock error codes. Make the function return a
`const char *'. Suggested by Ozkan Sezer. Fixes Savannah bug #34832.
Paul Smith [Mon, 30 Jan 2012 01:40:56 +0000 (01:40 +0000)]
Map Guile variable objects to the empty string.
In Guile 2.0, (define ...) results in a variable object. Ensure make
converts that to an empty string to avoid spurious errors.
Paul Smith [Mon, 30 Jan 2012 00:21:57 +0000 (00:21 +0000)]
Add support for "::=" simple assignment operator.
The next POSIX standard will define "::=" to have the same behavior
as GNU make's ":=", so add support for this new operator.
Eli Zaretskii [Sat, 28 Jan 2012 20:28:31 +0000 (20:28 +0000)]
Support a Windows build with Guile.
README.W32.template: Update with instructions for building with Guile.
build_w32.bat: Support building with Guile.
make.h [HAVE_STDINT_H]: Include stdint.h.
Eli Zaretskii [Sat, 28 Jan 2012 16:50:21 +0000 (16:50 +0000)]
Fix failures on MS-Windows when Make's standard handles are invalid.
This can happen when Make is invoked from a GUI application.
* w32/subproc/sub_proc.c (process_init_fd): Don't dereference
pproc if it is a NULL pointer.
(process_begin, process_cleanup): Don't try to close pipe handles
whose value is INVALID_HANDLE_VALUE.
(process_easy): Initialize hIn, hOut, and hErr to
INVALID_HANDLE_VALUE. If DuplicateHandle fails with
ERROR_INVALID_HANDLE, duplicate a handle for the null device
instead of STD_INPUT_HANDLE, STD_OUTPUT_HANDLE or
STD_ERROR_HANDLE. Don't try to close pipe handles whose value is
INVALID_HANDLE_VALUE.
* function.c (windows32_openpipe): Initialize hIn and hErr to
INVALID_HANDLE_VALUE. If DuplicateHandle fails with
ERROR_INVALID_HANDLE, duplicate a handle for the null device
instead of STD_INPUT_HANDLE or STD_ERROR_HANDLE. Fix indentation.
Don't try to close handles whose value is INVALID_HANDLE_VALUE.
Paul Smith [Mon, 16 Jan 2012 03:32:49 +0000 (03:32 +0000)]
Create a new internal interface for defining new make functions.
This allows us to create new functions without changing function.c.
You still have to modify the GNU make code (for now) though: this is
simply a preliminary step to possibly allowing make to load modules.
Modify the Guile integration to use this method rather than ifdefs
in function.c.
Paul Smith [Tue, 15 Nov 2011 21:12:53 +0000 (21:12 +0000)]
Enable jobserver on W32 when using configure.
Some W32 cleanups: see Savannah bug #34830
Forgot to modify the config.h.W32.template file for jobserver support.
Paul Smith [Sun, 18 Sep 2011 23:39:26 +0000 (23:39 +0000)]
When we re-exec the master makefile in a jobserver environment, ensure
that MAKEFLAGS is set properly so the re-exec'd make runs in parallel.
See Savannah bug #33873.
Paul Smith [Sun, 18 Sep 2011 20:52:13 +0000 (20:52 +0000)]
We compute various values for vpath lookup the first time through
and store them in static variables; however one value (std_dirs)
was not being stored statically so the second time through it was
not set.
Fixes Savannah bug #32511
Paul Smith [Mon, 12 Sep 2011 05:29:58 +0000 (05:29 +0000)]
Ensure variables defined in $(call ...) have global scope
Add a note about using #!/usr/bin/make -f to the manual.
Clean up the w32 subdirectory in the dist tarball.
Paul Smith [Mon, 29 Aug 2011 16:20:19 +0000 (16:20 +0000)]
Save strings we're expanding in case an embedded eval causes them
to be freed (if they're the value of a variable that's reset for example).
See Savannah patch #7534
Eli Zaretskii [Sat, 7 May 2011 08:29:13 +0000 (08:29 +0000)]
job.c (construct_command_argv_internal): Don't assume shellflags
is always non-NULL. Escape-protect characters special to the
shell when copying the value of SHELL into new_line. Fixes
Savannah bug #23922.
Paul Smith [Mon, 2 May 2011 12:35:01 +0000 (12:35 +0000)]
Use the same algorithm for counting the number of words to sort as we
use to break up the list of words, so we're sure to get the same number.
Fixes Savannah bug #33125
Boris Kolpackov [Fri, 29 Apr 2011 15:27:39 +0000 (15:27 +0000)]
Delay caching of the file name in eval_makefile() until after all the
expansions and searches are complete. This fixes an assertion in a
situation where the MAKEFILES variable contains a file path that
contains tilde.
Paul Smith [Mon, 21 Feb 2011 07:30:11 +0000 (07:30 +0000)]
* Fixups to the make man page
* Minor syntax cleanups in the manual
* In non-maintainer mode set NDEBUG to disable assert()
* Performance improvements in strcache:
Build Info 1000 2000 4000
3.82 -g 2.61s 8.85s 33.52s
3.82 -O2 1.90s 7.62s 27.82s
New -g (with asserts) 1.03s 2.31s 5.79s
New -O2 (no asserts) 0.65s 1.50s 3.52s
Paul Smith [Sat, 14 Aug 2010 02:50:14 +0000 (02:50 +0000)]
- Fix the NEWS file to be accurate
- Add oneshell to $(.FEATURES) (forgot that!)
- Fix Savannah bug #30612: handling of archive references with >1 object
Eli Zaretskii [Sat, 7 Aug 2010 08:46:06 +0000 (08:46 +0000)]
function.c (func_shell) [WINDOWS32]: Reset just_print_flag
around the call to construct_command_argv, so that a temporary
batch file _is_ created when needed for $(shell). Fixes Savannah
bug #16362.
Eli Zaretskii [Fri, 9 Jul 2010 12:05:10 +0000 (12:05 +0000)]
w32/subproc/sub_proc.c: Include stdint.h.
(sub_process_t): Use intptr_t for file handles and pid_t for
process ID.
(process_pipes, process_init_fd, process_begin): Use intptr_t for
file handles and pid_t for process ID.
Savannah bug #27809. Patch by Ozkan Sezer <sezeroz@gmail.com>
Eli Zaretskii [Fri, 9 Jul 2010 11:10:04 +0000 (11:10 +0000)]
job.c (pid2str) [WINDOWS32]: Don't use %Id with GCC < 4.x.
(exec_command) [WINDOWS32]: Use pid2str instead of non-portable
%Id.
main.c (handle_runtime_exceptions): Use %p to print addresses,
to DTRT on both 32-bit and 64-bit hosts. Savannah bug #27809.
job.c (w32_kill, start_job_command, create_batch_file): Use
pid_t for process IDs and intptr_t for the 1st arg of
_open_osfhandle.
function.c (windows32_openpipe): Use pid_t for process IDs and
intptr_t for the 1st arg of _open_osfhandle.
(func_shell): Use pid_t for process IDs.
main.c (main) [WINDOWS32]: Pacify the compiler.
config.h.W32.template (pid_t): Add a definition for 64-bit
Windows builds that don't use GCC.
Savannah bug #27809. Patch by Ozkan Sezer <sezeroz@gmail.com>
Paul Smith [Tue, 6 Jul 2010 06:37:42 +0000 (06:37 +0000)]
- Enhance .POSIX to set -e when invoking shells, as demanded by a
backward-incompatible change in the 2008 POSIX specification.
- Add the .SHELLFLAGS variable so people can choose their own shell flags.
- Add tests for this.
- Add documentation for this.
Paul Smith [Thu, 1 Jul 2010 07:16:00 +0000 (07:16 +0000)]
- Add whitespace to command line invocation in features/recursion
- Set up .FEATURES with separate calls for optional features, as some
compilers don't like conditionals inside macro invocations.
Eli Zaretskii [Fri, 11 Dec 2009 15:54:19 +0000 (15:54 +0000)]
(construct_command_argv_internal) <sh_cmds_dos> [WINDOWS32]: Add "echo." and
a few more commands that are built into cmd.exe. Fixes Savannah bug #28126.