Boris Kolpackov [Wed, 14 Dec 2005 13:11:18 +0000 (13:11 +0000)]
Fixed record_target_var to initialize variable's export field with v_default
instead of leaving it "initialized" by whatever garbage happened to be on
the heap.
Paul Smith [Mon, 24 Oct 2005 13:01:39 +0000 (13:01 +0000)]
Make second expansion optional (partial implementation).
I decided this feature was too impacting to make the permanent default
behavior. This set of changes makes the default behavior of make the
old behavior (no second expansion). If you want second expansion, you
must define the .SECONDEXPANSION: special target before the first target
that needs it.
This set of changes ONLY fixes explicit and static pattern rules to work
like this. Implicit rules still have second expansion enabled all the
time: I'll work on that next.
Note that there is still a backward-incompatibility: now to get the old
SysV behavior using $$@ etc. in the prerequisites list you need to set
.SECONDEXPANSION: as well.
Paul Smith [Mon, 8 Aug 2005 05:08:00 +0000 (05:08 +0000)]
- Fixed a bug reported by Michael Matz regarding handling of parallel
jobs after a failed job.
- Enhancements to WINDOWS32 code from Eli Zaretskii.
- Add Microsoft Project files from J. Grant.
Paul Smith [Mon, 27 Jun 2005 22:18:47 +0000 (22:18 +0000)]
Cleaned up some problems found with the tests running on a powerful
Solaris system with an EMC NFS storage solution. Still get some odd
errors here unfortunately related to sub-second timestamps that I just
can't figure out. It all works if we run the tests in /tmp instead
though :-/.
Paul Smith [Mon, 27 Jun 2005 01:01:07 +0000 (01:01 +0000)]
Fix strerror() handling for systems which set ANSI_STRING.
Don't print errors if "include" is specified with no arguments.
New test suite for the $(shell ...) function.
Paul Smith [Sun, 12 Jun 2005 22:22:07 +0000 (22:22 +0000)]
Fix Savannah bug # 1328: if stdout is redirected to a full filesystem, we
check for this and exit with an error.
The closeout.c version from gnulib pulls in too much other stuff, and
gnulib requires an ANSI C 89 compliant compiler, while GNU make (so far)
still wants to work on K&R.
Paul Smith [Thu, 9 Jun 2005 19:19:20 +0000 (19:19 +0000)]
Fix Savannah bug #11913: ensure that scopes such as foreach, etc. take
precedence over the global scope when they're used in a global context
(such as an eval).
Paul Smith [Sun, 8 May 2005 16:50:58 +0000 (16:50 +0000)]
Document the secondary expansion method. Also, some other documentation
cleanups.
If we find a make error (invalid makefile syntax or something like that)
write back any tokens we have before we exit.
If we have waiting jobs (using -j + -l) set an alarm before we sleep on
the read() system call, so we can wake up to check the load and start
waiting jobs, if there are long-running jobs we would otherwise be
waiting for. Suggested by Grant Taylor.
Paul Smith [Tue, 3 May 2005 13:57:20 +0000 (13:57 +0000)]
Fix problems with losing tokens in the jobserver, reported by Grant
Taylor. There are two forms of this: first, it was possible to lose
tokens when using -j and -l at the same time, because waiting jobs were
not checked when determining whether any jobs were outstanding. Second,
if you had an exported recursive variable that contained a $(shell ...)
function there is a possibility to lose tokens, since a token was taken
but the child list was not updated until after the shell function was
complete.
To resolve this I introduced a new variable that counted the number of
tokens we have obtained, rather than checking whether there were any
children on the list. I also added some sanity checks to make sure we
weren't writing back too many or not enough tokens. And, the master
make will drain the token pipe before exiting and compare the count of
tokens at the end to what was written there at the beginning.
Also:
* Ensure a bug in the environment (missing "=") doesn't cause make to core.
* Rename the .DEFAULT_TARGET variable to .DEFAULT_GOAL, to match the
terminology in the documentation and other variables like MAKECMDGOALS.
* Add documentation of the .DEFAULT_GOAL special variable.
Still need to document the secondary expansion stuff...
Paul Smith [Wed, 13 Apr 2005 03:16:33 +0000 (03:16 +0000)]
Fix performance degradation introduced by the second expansion feature.
I did this by adding intelligence into the algorithm such that the
second expansion was only actually performed when the prerequisite list
contained at least one "$", so we knew it is actually needed.
Without this we were using up a LOT more memory, since every single
target (even ones never used by make) had their file variables
initialized. This also used a lot more CPU, since we needed to create
and populate a new variable hash table for every target.
There is one issue remaining with this feature: it leaks memory. In
pattern_search() we now initialize the file variables for every pattern
target, which allocates a hash table, etc. However, sometimes we
recursively invoke pattern_search() (for intermediate files) with an
automatic variable (alloca() I believe) as the file. When that function
returns, obviously, the file variable hash memory is lost.
Paul Smith [Mon, 28 Feb 2005 07:48:22 +0000 (07:48 +0000)]
* New feature: -L option
* New function: $(info ...)
* Disallow $(eval ...) to create prereq relationships inside command scripts
(caused core dumps)
* Try to allow more tests to succeed in Windows/DOS by sanitizing CRLF and \
* Various bug fixes and code cleanups (see the ChangeLog entry)
Paul Smith [Thu, 10 Feb 2005 00:10:57 +0000 (00:10 +0000)]
Flush stdout after printing directory info.
Fix references to MINGW #define constants.
Remove WINDOWS32 ifdef from sub_proc.h.
Only add variables to the command line for recursion once.
New features in run_make_test: #PWD# and #MAKEPATH# replacements.
Test the multi-variable fix in the recursion regression test.
Paul Smith [Sun, 28 Nov 2004 23:11:23 +0000 (23:11 +0000)]
Fix for bug #1276: Handle SHELL according to POSIX requirements.
POSIX requires that the value of SHELL in the makefile NOT be exported
to sub-commands. Instead, the value in the environment when make was
invoked should be passed to the environment of sub-commands. Note that
make still uses SHELL to _run_ sub-commands; it just doesn't change the
value of the SHELL variable in the environment of sub-commands.
As an extension to POSIX, if the makefile explicitly exports SHELL then
GNU make _will_ use it in the environment of sub-commands.
Paul Smith [Wed, 22 Sep 2004 04:36:17 +0000 (04:36 +0000)]
Update the test template. A few fixes in run_make_test().
Rename implicit_prereq_eval to patternrules, to be the start of a suite
of tests of pattern rules.
Paul Smith [Tue, 21 Sep 2004 13:51:58 +0000 (13:51 +0000)]
Some code cleanups and efficiency enhancements. As far as I can tell
none of these have impacts that are visible to the user (although in
some cases that appears to be nothing more than dumb luck :-/).
Paul Smith [Tue, 21 Sep 2004 05:39:04 +0000 (05:39 +0000)]
Add some more unit tests for variable flavors.
Allow run_make_tests() to be invoked with an undef makefile string, in
which case it re-uses the previous string.
Paul Smith [Tue, 21 Sep 2004 04:00:31 +0000 (04:00 +0000)]
Fix some bugs in variable pattern substitution (e.g. $(VAR:A=B)),
reported by Markus Mauhart <qwe123@chello.at>. One was a simple typo; to
fix the other we call patsubst_expand() for all instances of variable
substitution, even when there is no '%'. We used to call subst_expand()
with a special flag set in the latter case, but it didn't work properly
in all situations. Easier to just use patsubst_expand() since that's
what it is.
Paul Smith [Sun, 16 May 2004 19:16:52 +0000 (19:16 +0000)]
Various enhancements
- OS/2 Patches
- OpenVMS updates
- Sanitize the handling of -include/sinclude with and without -k
- Fix the setting of $< for order-only rules.
Paul Smith [Thu, 4 Mar 2004 13:42:51 +0000 (13:42 +0000)]
Updates to automate generation of GNU upload artifacts.
Fix a problem compiling on old, pre-ANSI systems. getloadavg test is still
broken, but make builds.
Document a breakage on SunOS 4.x systems.
Paul Smith [Wed, 21 Jan 2004 06:32:59 +0000 (06:32 +0000)]
Many bug fixes etc.
- Apply a fix for the "thundering herd" problem when using "-j -l".
This also fixes bug #4693.
- Fix bug #7257: allow functions as ifdef arguments
- Fix bug #4518: make sure we print all double-colon rules with -p.
- Upgrade to autconf 2.58/automake 1.8/gettext 0.13.1
- Various doc cleanups, etc.
Paul Smith [Thu, 8 Jan 2004 03:17:08 +0000 (03:17 +0000)]
Enhancements to the documentation (fixes bugs #1772 and 4898).
Add "!" to the list of shell escape characters: POSIX sh allows it to be
used to negate the return value of the command.
Paul Smith [Mon, 3 Nov 2003 22:04:09 +0000 (22:04 +0000)]
Added MINGW32 changes.
This commits a number of changes from Earnie Boyd that allows GNU make
to build for MINGW32 systems. Only missing from this commit are the
changes to configure.in etc.; I'm waiting for Earnie to sign papers for
those new files.
Also not here is any README.mingw32 etc. which would explain how to use
this port.
Paul Smith [Thu, 31 Jul 2003 13:04:32 +0000 (13:04 +0000)]
Updated for autoconf 2.57, automake 1.7.6, and gettext 0.12.1.
Fixed problems with the dist target (adding missing files).
Workaround for a bug in gettext 0.12.1 po/Makefile.in.in where distclean
wasn't cleaning everything, which caused distcheck to fail.
Paul Smith [Fri, 2 May 2003 01:44:59 +0000 (01:44 +0000)]
- Fix bug #1405: allow multiple pattern-specific variables to match a target.
- Fix some uncleanliness about the implementation of patterns-specific vars.
- Some enhancements to the OS/2 port.
projects / thirdparty / make.git / log
