]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Test that vacuum removes tuples older than OldestXmin
authorMelanie Plageman <melanieplageman@gmail.com>
Fri, 19 Jul 2024 14:44:42 +0000 (10:44 -0400)
committerMelanie Plageman <melanieplageman@gmail.com>
Fri, 19 Jul 2024 16:11:41 +0000 (12:11 -0400)
commit01e2b7f0fd02a44e1d13357b20fecd79919d9031
treeac877a4a24c1155cd85195dc4457dc3de9559dfb
parent06bf404cd07bd82f08a3000d5977080f945e70ca
Test that vacuum removes tuples older than OldestXmin

If vacuum fails to prune a tuple killed before OldestXmin, it will later
find that tuple dead in lazy_scan_prune() and loop infinitely.

Add a test reproducing this scenario to the recovery suite which creates
a table on a primary, updates the table to generate dead tuples for
vacuum, and then, during the vacuum, uses a replica to force
GlobalVisState->maybe_needed on the primary to move backwards and
precede the value of OldestXmin set at the beginning of vacuuming the
table.

This commit is separate from the fix in case there are test stability
issues.

Discussion of the bug: https://postgr.es/m/CAAKRu_Y_NJzF4-8gzTTeaOuUL3CcGoXPjXcAHbTTygT8AyVqag%40mail.gmail.com
Discussion of the test: https://postgr.es/m/CAAKRu_apNU2MPBK96V%2BbXjTq0RiZ-%3DA4ZTaysakpx9jxbq1dbQ%40mail.gmail.com

Author: Melanie Plageman
Reviewed-by: Peter Geoghegan
src/test/recovery/t/043_vacuum_horizon_floor.pl [new file with mode: 0644]