]> git.ipfire.org Git - thirdparty/asterisk.git/commit
chan_websocket: Fix buffer overrun when processing TEXT websocket frames.
authorGeorge Joseph <gjoseph@sangoma.com>
Tue, 19 Aug 2025 15:46:39 +0000 (09:46 -0600)
committerGeorge Joseph <gjoseph@sangoma.com>
Wed, 20 Aug 2025 14:42:14 +0000 (14:42 +0000)
commit076423aa18808e2a4fff1259cd927b1f562081c0
tree8bf9eefcee785d014bc2e4d924f4f4fb896a2c30
parent45ee5cda1c39efd4650eb88f4377f799f7890987
chan_websocket: Fix buffer overrun when processing TEXT websocket frames.

ast_websocket_read() receives data into a fixed 64K buffer then continually
reallocates a final buffer that, after all continuation frames have been
received, is the exact length of the data received and returns that to the
caller.  process_text_message() in chan_websocket was attempting to set a
NULL terminator on the received payload assuming the payload buffer it
received was the large 64K buffer.  The assumption was incorrect so when it
tried to set a NULL terminator on the payload, it could, depending on the
state of the heap at the time, cause heap corruption.

process_text_message() now allocates its own payload_len + 1 sized buffer,
copies the payload received from ast_websocket_read() into it then NULL
terminates it prevent the possibility of the overrun and corruption.

Resolves: #1384
channels/chan_websocket.c