]> git.ipfire.org Git - people/arne_f/kernel.git/commit
scsi: fnic: do not queue commands during fwreset
authorHannes Reinecke <hare@suse.de>
Thu, 16 Jan 2020 10:20:53 +0000 (11:20 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 21 Jan 2020 04:58:14 +0000 (23:58 -0500)
commit0e2209629fec427ba75a6351486153a9feddd36b
tree2d6e8431b0261408bbc70342aa4e74f8b69e0099
parent28d76df18f0ad5bcf5fa48510b225f0ed262a99b
scsi: fnic: do not queue commands during fwreset

When a link is going down the driver will be calling fnic_cleanup_io(),
which will traverse all commands and calling 'done' for each found command.
While the traversal is handled under the host_lock, calling 'done' happens
after the host_lock is being dropped.

As fnic_queuecommand_lck() is being called with the host_lock held, it
might well be that it will pick the command being selected for abortion
from the above routine and enqueue it for sending, but then 'done' is being
called on that very command from the above routine.

Which of course confuses the hell out of the scsi midlayer.

So fix this by not queueing commands when fnic_cleanup_io is active.

Link: https://lore.kernel.org/r/20200116102053.62755-1-hare@suse.de
Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/fnic/fnic_scsi.c