]> git.ipfire.org Git - thirdparty/git.git/commit
t7001: add failure test which triggers assertion
authorKristoffer Haugsbakk <code@khaugsbakk.name>
Tue, 22 Oct 2024 21:14:33 +0000 (23:14 +0200)
committerTaylor Blau <me@ttaylorr.com>
Wed, 23 Oct 2024 20:36:15 +0000 (16:36 -0400)
commit0fcd473fdd3f8d2c418a4fafcbee2a523bd610cb
tree1656a5a375f41726e27f83ceb89819bbf7760edc
parent34b6ce9b30747131b6e781ff718a45328aa887d0
t7001: add failure test which triggers assertion

`git mv a/a.txt a b/` is a nonsense instruction.  Instead of failing
gracefully the command trips over itself,[1] leaving behind unfinished
work:

1. first it moves `a/a.txt` to `b/a.txt`; then
2. tries to move `a/`, including `a/a.txt`; then
3. figures out that it’s in a bad state (assertion); and finally
4. aborts.

Now you’re left with a partially-updated index.

The command should instead fail gracefully and make no changes to the
index until it knows that it can complete a sensible action.

For now just add a failing test since this has been known about for
a while.[2]

† 1: Caused by a `pos >= 0` assertion
[2]: https://lore.kernel.org/git/d1f739fe-b28e-451f-9e01-3d2e24a0fe0d@app.fastmail.com/

Helped-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
t/t7001-mv.sh