]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
gh-108172: do not override OS preferred browser if it is a super-string of a known...
authorOded Arbel <oded@geek.co.il>
Sat, 31 Aug 2024 06:11:57 +0000 (09:11 +0300)
committerGitHub <noreply@github.com>
Sat, 31 Aug 2024 06:11:57 +0000 (23:11 -0700)
commit10bf615bab9f832971a098f0a42b0d617aea6993
tree22b7d1a60ff04720b364db255ac028bd91216c5e
parent74bfb53e3afb6f5dd90dff3ef0e2dc3b2fba823e
gh-108172: do not override OS preferred browser if it is a super-string of a known browser (GH-113011)

When checking if the registering browser is the "OS preferred browser", do not use a substring search - that makes no sense: one can have a preferred browser that looks like a super-string of a known browser, e.g. "firefox-nightly" vs "firefox".

https://github.com/python/cpython/issues/108172 explains in more detail, and lays out a potential better future enhancement for this case of just using xdg-open.  We'll go with this for now.

---------

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Lib/webbrowser.py
Misc/NEWS.d/next/Library/2023-12-12-15-19-58.gh-issue-108172.KyDPuG.rst [new file with mode: 0644]