]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: make advice from numad available when building commandline
authorMartin Kletzander <mkletzan@redhat.com>
Thu, 30 Oct 2014 06:34:30 +0000 (07:34 +0100)
committerMartin Kletzander <mkletzan@redhat.com>
Mon, 3 Nov 2014 15:43:22 +0000 (16:43 +0100)
commit11a48758a7d6c946062c130b6186ae3eadd58e39
treec6d310e1780bb32763daf7ede7ec1bfd4ce8eb7d
parente43854a498e860669e44414d4e780184a13ad0ab
qemu: make advice from numad available when building commandline

Particularly in qemuBuildNumaArgStr(), there was a need for the advice
due to memory backing, which needs to know the nodeset it will be pinned
to.  With newer qemu this caused the following error when starting
domain:

  error: internal error: Advice from numad is needed in case of
  automatic numa placement

even when starting perfectly valid domain, e.g.:

  ...
  <vcpu placement='auto'>4</vcpu>
  <numatune>
    <memory mode='strict' placement='auto'/>
  </numatune>
  <cpu>
    <numa>
      <cell id='0' cpus='0' memory='524288'/>
      <cell id='1' cpus='1' memory='524288'/>
    </numa>
  </cpu>
  ...

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1138545

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
src/qemu/qemu_command.c
src/qemu/qemu_command.h
src/qemu/qemu_driver.c
src/qemu/qemu_process.c
tests/qemuxml2argvtest.c
tests/qemuxmlnstest.c