]> git.ipfire.org Git - thirdparty/linux.git/commit
drm/xe: Eliminate usage of TIMESTAMP_OVERRIDE
authorMatt Roper <matthew.d.roper@intel.com>
Tue, 25 Feb 2025 22:49:09 +0000 (14:49 -0800)
committerMatt Roper <matthew.d.roper@intel.com>
Wed, 26 Feb 2025 21:29:42 +0000 (13:29 -0800)
commit18778b5fdd018baa6eb492166d04605b39030e1d
tree3e2eedce7e1887247701dca216e3e0565a04daf6
parenta33c9699e73456d08182ad7b87a4af52ac24f779
drm/xe: Eliminate usage of TIMESTAMP_OVERRIDE

Recent discussions with the hardware architects have revealed that
the TIMESTAMP_OVERRIDE register is never expected to hold a valid/useful
value on production hardware.  That register would only get used by
hardware workarounds (although there are none that use it today) or
during early internal hardware testing.

Due to lack of documentation it's not clear exactly what the driver
should be doing if CTC_MODE[0] is set (or even whether that's a setting
that would ever be encountered on real hardware), but it's definitely
not what Xe and i915 have been doing.  So drop the incorrect code trying
to use TIMESTAMP_REGISTER.  If the driver does encounter CTC_MODE[0] in
the wild, we'll print a warning and just continue trying to use the
crystal clock frequency since that's probably less incorrect than what
we're doing today.

Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250225224908.1671554-2-matthew.d.roper@intel.com
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
drivers/gpu/drm/xe/regs/xe_regs.h
drivers/gpu/drm/xe/xe_gt_clock.c
drivers/gpu/drm/xe/xe_gt_sriov_pf_service.c