]> git.ipfire.org Git - thirdparty/linux.git/commit
x86/fpu: Fix guest FPU state buffer allocation size
authorStanislav Spassov <stanspas@amazon.de>
Tue, 18 Feb 2025 14:10:45 +0000 (14:10 +0000)
committerIngo Molnar <mingo@kernel.org>
Fri, 21 Feb 2025 13:47:26 +0000 (14:47 +0100)
commit1937e18cc3cf27e2b3ef70e8c161437051ab7608
tree3e91975f4a0553e72386dcdc60bd2b270e8b7fcd
parentccb7735a1ea22621f21c3133e4f5f3da5fe5f5b7
x86/fpu: Fix guest FPU state buffer allocation size

Ongoing work on an optimization to batch-preallocate vCPU state buffers
for KVM revealed a mismatch between the allocation sizes used in
fpu_alloc_guest_fpstate() and fpstate_realloc(). While the former
allocates a buffer sized to fit the default set of XSAVE features
in UABI form (as per fpu_user_cfg), the latter uses its ksize argument
derived (for the requested set of features) in the same way as the sizes
found in fpu_kernel_cfg, i.e. using the compacted in-kernel
representation.

The correct size to use for guest FPU state should indeed be the
kernel one as seen in fpstate_realloc(). The original issue likely
went unnoticed through a combination of UABI size typically being
larger than or equal to kernel size, and/or both amounting to the
same number of allocated 4K pages.

Fixes: 69f6ed1d14c6 ("x86/fpu: Provide infrastructure for KVM FPU cleanup")
Signed-off-by: Stanislav Spassov <stanspas@amazon.de>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20250218141045.85201-1-stanspas@amazon.de
arch/x86/kernel/fpu/core.c