]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Fix client crash on double PUSH_REPLY.
authorGert Doering <gert@greenie.muc.de>
Tue, 25 Dec 2012 12:41:50 +0000 (13:41 +0100)
committerDavid Sommerseth <davids@redhat.com>
Wed, 2 Jan 2013 11:54:37 +0000 (12:54 +0100)
commit1978db4b9657f0db134f1deaeb1e8400bf6a033e
tree60a4fe4f2ca7508eb50f67df5f489dba85c786db
parentd39f31d96378aa5eeade74670ffd9e08bf4c7234
Fix client crash on double PUSH_REPLY.

Introduce an extra bool variable c2.pulled_options_md5_init_done to
keep track of md5_init state of pulled_options_state - avoid accessing
uninitialized state when a second PUSH_REPLY comes in (which only happens
under very particular circumstances).

Bug tracked down by Arne Schwabe <arne@rfc2549.rrg>.

Signed-off-by: Gert Doering <gert@greenie.muc.de>
Acked-by: Arne Schwabe <arne@rfc2549.org>
Message-Id: 20121225124856.GT22465@greenie.muc.de
URL: http://article.gmane.org/gmane.network.openvpn.devel/7216
Signed-off-by: David Sommerseth <davids@redhat.com>
src/openvpn/openvpn.h
src/openvpn/push.c