]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Handle heap rewrites better in logical replication
authorPeter Eisentraut <peter_e@gmx.net>
Tue, 26 Sep 2017 14:03:56 +0000 (10:03 -0400)
committerPeter Eisentraut <peter_e@gmx.net>
Tue, 26 Sep 2017 14:13:55 +0000 (10:13 -0400)
commit1a499c252049dad9016a04bcbab27b8c616d4d03
tree109b4cc99e6a5ebe772fdd587772995667801ff4
parent4621c7f7a432fbb24b69c5cf0c877c17832c26ac
Handle heap rewrites better in logical replication

A FOR ALL TABLES publication naturally considers all base tables to be a
candidate for replication.  This includes transient heaps that are
created during a table rewrite during DDL.  This causes failures on the
subscriber side because it will not have a table like pg_temp_16386 to
receive data (and if it did, it would be the wrong table).

The prevent this problem, we filter out any tables that match this
naming pattern and match an actual table from FOR ALL TABLES
publications.  This is only a heuristic, meaning that user tables that
match that naming could accidentally be omitted.  A more robust solution
might require an explicit marking of such tables in pg_class somehow.

Reported-by: yxq <yxq@o2.pl>
Bug: #14785
Reviewed-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Petr Jelinek <petr.jelinek@2ndquadrant.com>
src/backend/replication/pgoutput/pgoutput.c
src/test/subscription/t/006_rewrite.pl [new file with mode: 0644]