]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
staging: vchiq_arm: Fix missing refcount decrement in error path for fw_node
authorJavier Carrasco <javier.carrasco.cruz@gmail.com>
Mon, 14 Oct 2024 08:56:37 +0000 (10:56 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Oct 2024 07:58:15 +0000 (09:58 +0200)
commit22a3703af127e897dc7df89372b85bb9dc331c5f
tree7de1fc7be3d1f4f28aa7d2a17d2e9f22343335a4
parent76c29a2e0e6266641340d5f129fe8a022698c631
staging: vchiq_arm: Fix missing refcount decrement in error path for fw_node

An error path was introduced without including the required call to
of_node_put() to decrement the node's refcount and avoid leaking memory.
If the call to kzalloc() for 'mgmt' fails, the probe returns without
decrementing the refcount.

Use the automatic cleanup facility to fix the bug and protect the code
against new error paths where the call to of_node_put() might be missing
again.

Cc: stable@vger.kernel.org
Fixes: 1c9e16b73166 ("staging: vc04_services: vchiq_arm: Split driver static and runtime data")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Link: https://lore.kernel.org/r/20241014-vchiq_arm-of_node_put-v2-2-cafe0a4c2666@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c