]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
thermal: core: Drop redundant checks from thermal_bind_cdev_to_trip()
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 22 Aug 2024 19:26:09 +0000 (21:26 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 23 Aug 2024 13:56:29 +0000 (15:56 +0200)
commit24aad192c671720744a558d38c4033b4b36ba5f1
tree43e9deb6a7682b1a3b8909c7fe0d2628fab39540
parent91d7ed957eb2e0a13e7d44195b529f49701c5745
thermal: core: Drop redundant checks from thermal_bind_cdev_to_trip()

Since thermal_bind_cdev_to_trip() is only called by
thermal_zone_cdev_binding() under the thermal zone lock and the latter
is only called by thermal_zone_device_register_with_trips() and
__thermal_cooling_device_register(), under thermal_list_lock in both
cases, both lockdep_assert_held() assertions can be dropped from it.

Moreover, in both cases thermal_zone_cdev_binding() is called after
both tz and cdev have been added to the global lists of thermal zones
and cooling device, respectively, so the check against their list nodes
in thermal_bind_cdev_to_trip() is redundant and can be dropped either.

Link: https://lore.kernel.org/linux-pm/CAJZ5v0jwkc2PB+osSkkYF9vJ1Vpp3MFE=cGQmQ2Xzjb3yjVfJg@mail.gmail.com/
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://patch.msgid.link/4607540.LvFx2qVVIh@rjwysocki.net
drivers/thermal/thermal_core.c