]> git.ipfire.org Git - thirdparty/curl.git/commit
metalink: remove
authorDaniel Stenberg <daniel@haxx.se>
Tue, 1 Jun 2021 14:24:00 +0000 (16:24 +0200)
committerDaniel Stenberg <daniel@haxx.se>
Mon, 7 Jun 2021 06:14:25 +0000 (08:14 +0200)
commit265b14d6b37c4298bd5556fabcbc37d36f911693
tree3c7ca96bc1ce2e859bfaa71a0d6afcad56c9f9f7
parent9cf516adc67b67388e22bb8c33cb3fabd68f2ac6
metalink: remove

Warning: this will make existing curl command lines that use metalink to
stop working.

Reasons for removal:

1. We've found several security problems and issues involving the
   metalink support in curl. The issues are not detailed here. When
   working on those, it become apparent to the team that several of the
   problems are due to the system design, metalink library API and what
   the metalink RFC says. They are very hard to fix on the curl side
   only.

2. The metalink usage with curl was only very briefly documented and was
   not following the "normal" curl usage pattern in several ways, making
   it surprising and non-intuitive which could lead to further security
   issues.

3. The metalink library was last updated 6 years ago and wasn't so
   active the years before that either. An unmaintained library means
   there's a security problem waiting to happen. This is probably reason
   enough.

4. Metalink requires an XML parsing library, which is complex code (even
   the smaller alternatives) and to this day often gets security
   updates.

5. Metalink is not a widely used curl feature. In the 2020 curl user
   survey, only 1.4% of the responders said that they'd are using it. In
   2021 that number was 1.2%. Searching the web also show very few
   traces of it being used, even with other tools.

6. The torrent format and associated technology clearly won for
   downloading large files from multiple sources in parallel.

Cloes #7176
48 files changed:
.cirrus.yml
.github/workflows/macos.yml
.lgtm.yml
configure.ac
docs/FEATURES.md
docs/MANUAL.md
docs/cmdline-opts/metalink.d
docs/cmdline-opts/page-header
docs/cmdline-opts/version.d
docs/examples/Makefile.m32
packages/vms/gnv_link_curl.com
src/Makefile.am
src/Makefile.inc
src/Makefile.m32
src/Makefile.netware
src/tool_cfgable.h
src/tool_getparam.c
src/tool_help.c
src/tool_main.c
src/tool_metalink.c [deleted file]
src/tool_metalink.h [deleted file]
src/tool_operate.c
src/tool_operate.h
src/tool_operhlp.c
src/tool_sdecls.h
tests/FILEFORMAT.md
tests/data/Makefile.inc
tests/data/test2005 [deleted file]
tests/data/test2006 [deleted file]
tests/data/test2007 [deleted file]
tests/data/test2008 [deleted file]
tests/data/test2009 [deleted file]
tests/data/test2010 [deleted file]
tests/data/test2011 [deleted file]
tests/data/test2012 [deleted file]
tests/data/test2013 [deleted file]
tests/data/test2014 [deleted file]
tests/data/test2015 [deleted file]
tests/data/test2016 [deleted file]
tests/data/test2017 [deleted file]
tests/data/test2018 [deleted file]
tests/data/test2019 [deleted file]
tests/data/test2020 [deleted file]
tests/data/test2021 [deleted file]
tests/data/test2022 [deleted file]
tests/libtest/test1013.pl
tests/runtests.pl
tests/unit/Makefile.inc