]> git.ipfire.org Git - people/arne_f/kernel.git/commit
namei: only return -ECHILD from follow_dotdot_rcu()
authorAleksa Sarai <cyphar@cyphar.com>
Fri, 6 Dec 2019 14:13:26 +0000 (01:13 +1100)
committerAl Viro <viro@zeniv.linux.org.uk>
Mon, 9 Dec 2019 00:09:36 +0000 (19:09 -0500)
commit2b98149c2377bff12be5dd3ce02ae0506e2dd613
tree95fb705a14f99ab1b6ca600a529a66c8793f7dcc
parente42617b825f8073569da76dc4510bfa019b1c35a
namei: only return -ECHILD from follow_dotdot_rcu()

It's over-zealous to return hard errors under RCU-walk here, given that
a REF-walk will be triggered for all other cases handling ".." under
RCU.

The original purpose of this check was to ensure that if a rename occurs
such that a directory is moved outside of the bind-mount which the
resolution started in, it would be detected and blocked to avoid being
able to mess with paths outside of the bind-mount. However, triggering a
new REF-walk is just as effective a solution.

Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Fixes: 397d425dc26d ("vfs: Test for and handle paths that are unreachable from their mnt_root")
Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/namei.c