]> git.ipfire.org Git - thirdparty/git.git/commit
t: port helper/test-hashmap.c to unit-tests/t-hashmap.c
authorGhanshyam Thakkar <shyamthakkar001@gmail.com>
Sat, 3 Aug 2024 13:34:49 +0000 (19:04 +0530)
committerJunio C Hamano <gitster@pobox.com>
Tue, 6 Aug 2024 16:25:54 +0000 (09:25 -0700)
commit3469a23659d8197190d2765cf9f31dec5ab602fa
tree3316aac5f19b96ea8ffe14af655faa91c49be260
parent5c9be4c9d6cfe32a77782116f6b66940fa19c86b
t: port helper/test-hashmap.c to unit-tests/t-hashmap.c

helper/test-hashmap.c along with t0011-hashmap.sh test the hashmap.h
library. Migrate them to the unit testing framework for better
debugging, runtime performance and concise code.

Along with the migration, make 'add' tests from the shell script order
agnostic in unit tests, since they iterate over entries with the same
keys and we do not guarantee the order. This was already done for the
'iterate' tests[1].

The helper/test-hashmap.c is still not removed because it contains a
performance test meant to be run by the user directly (not used in
t/perf). And it makes sense for such a utility to be a helper.

[1]: e1e7a77141 (t: sort output of hashmap iteration, 2019-07-30)

Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Mentored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Helped-by: Josh Steadmon <steadmon@google.com>
Helped-by: Junio C Hamano <gitster@pobox.com>
Helped-by: Phillip Wood <phillip.wood123@gmail.com>
Signed-off-by: Ghanshyam Thakkar <shyamthakkar001@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Makefile
t/helper/test-hashmap.c
t/t0011-hashmap.sh [deleted file]
t/unit-tests/t-hashmap.c [new file with mode: 0644]