]> git.ipfire.org Git - people/arne_f/kernel.git/commit
thermal: bcm2835: Fix crash in bcm2835_thermal_debugfs
authorPhil Elwell <phil@raspberrypi.org>
Tue, 29 Jan 2019 09:55:57 +0000 (09:55 +0000)
committerZhang Rui <rui.zhang@intel.com>
Mon, 18 Mar 2019 14:11:06 +0000 (22:11 +0800)
commit35122495a8c6683e863acf7b05a7036b2be64c7a
treed79ccc78a70c559f387c42b1472f6fc42e23b012
parent3b5236cc5d086dd3ddd01113ee9255421aab9fab
thermal: bcm2835: Fix crash in bcm2835_thermal_debugfs

"cat /sys/kernel/debug/bcm2835_thermal/regset" causes a NULL pointer
dereference in bcm2835_thermal_debugfs. The driver makes use of the
implementation details of the thermal framework to retrieve a pointer
to its private data from a struct thermal_zone_device, and gets it
wrong - leading to the crash. Instead, store its private data as the
drvdata and retrieve the thermal_zone_device pointer from it.

Fixes: bcb7dd9ef206 ("thermal: bcm2835: add thermal driver for bcm2835 SoC")
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
drivers/thermal/broadcom/bcm2835_thermal.c