]> git.ipfire.org Git - thirdparty/samba.git/commit
dsdb: Correctly handle memory in objectclass_attrs
authorAndrew Bartlett <abartlet@samba.org>
Thu, 30 Jan 2020 03:41:39 +0000 (16:41 +1300)
committerStefan Metzmacher <metze@samba.org>
Thu, 6 Feb 2020 14:57:42 +0000 (14:57 +0000)
commit3657bbc21182d764ddfcd603025f24ec240fd263
tree672c2f35ee762982404758097e1d8749b229d924
parentd3b385d59634927a4ddbfa7885ac5f2e004f4e03
dsdb: Correctly handle memory in objectclass_attrs

el->values is caller-provided memory that should be thought of as constant,
it should not be assumed to be a talloc context.

Otherwise, if the caller gives constant memory or a stack
pointer we will get an abort() in talloc when it expects
a talloc magic in the memory preceeding the el->values.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14258

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
source4/dsdb/samdb/ldb_modules/objectclass_attrs.c