]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
rv: Merge struct rv_reactor_def into struct rv_reactor
authorNam Cao <namcao@linutronix.de>
Thu, 24 Jul 2025 17:33:28 +0000 (19:33 +0200)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Fri, 25 Jul 2025 13:04:14 +0000 (09:04 -0400)
commit3d3c376118b5f7ed7723c2b4fd7a0a1c1893d63e
tree56debfedf1ec7b0ccec5eff43b67416dd8324291
parent24cbfe18d55a6866bc2e27fda74306f4a1b5cb01
rv: Merge struct rv_reactor_def into struct rv_reactor

Each struct rv_reactor has a unique struct rv_reactor_def associated with
it. struct rv_reactor is statically allocated, while struct rv_reactor_def
is dynamically allocated.

This makes the code more complicated than it should be:

  - Lookup is required to get the associated rv_reactor_def from rv_reactor

  - Dynamic memory allocation is required for rv_reactor_def. This is
    harder to get right compared to static memory. For instance, there is
    an existing mistake: rv_unregister_reactor() does not free the memory
    allocated by rv_register_reactor(). This is fortunately not a real
    memory leak problem as rv_unregister_reactor() is never called.

Simplify and merge rv_reactor_def into rv_reactor.

Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Link: https://lore.kernel.org/71cb91c86cd40df5b8c492b788787f2a73c3eaa3.1753378331.git.namcao@linutronix.de
Reviewed-by: Gabriele Monaco <gmonaco@redhat.com>
Signed-off-by: Nam Cao <namcao@linutronix.de>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
include/linux/rv.h
kernel/trace/rv/rv.h
kernel/trace/rv/rv_reactors.c