]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Remove erroneous limitation on max number of args for --plugin
authorGert Doering <gert@greenie.muc.de>
Thu, 18 May 2017 19:13:11 +0000 (21:13 +0200)
committerGert Doering <gert@greenie.muc.de>
Sat, 20 May 2017 17:57:18 +0000 (19:57 +0200)
commit3f181eaa324892845e0857d80c154512d9e8c59c
treec08fa117c858837732d6da21aac4903fd4411534
parent3dd30bfe5fdf9f34afe7f847b4e30156982d9ff0
Remove erroneous limitation on max number of args for --plugin

Commit 3d6a4cded2 introduced a maximum limit of possible arguments
for most options, to error out on config lines with too-many args.

Commit 82acf21634 extended the limit for "--plugin" to accept "one
mandatory, one optional" argument.

Both are wrong - "--plugin" can accept an arbitrary number of arguments,
but this is not directly obvious from options.c, one needs to check
plugins.c / plugin_option_list_add() and misc.c / make_extended_arg_array()
to see that.

Thus, remove the max limit for "--plugin" completely.

(Reported by SviMik on IRC)

Signed-off-by: Gert Doering <gert@greenie.muc.de>
Acked-by: Steffan Karger <steffan.karger@fox-it.com>
Message-Id: <20170518191311.4769-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg14678.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/options.c