]> git.ipfire.org Git - thirdparty/samba.git/commit
pytests: sid_strings: do not fail if epoch ending has zeros
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Wed, 15 Nov 2023 00:03:27 +0000 (13:03 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Wed, 15 Nov 2023 04:05:34 +0000 (04:05 +0000)
commit426ca4cf4b667aae03f0344cee449e972de90ac7
tree0021b2490b7b1063a61b87f94710fac25f4cefab
parentb649007a532812ffb14a8fd7cbf204acb388e6d0
pytests: sid_strings: do not fail if epoch ending has zeros

To avoid collisions in random OID strings, we started using the epoch
date modulus 100 million. The trouble is we did not strip out the
leading zeros, so the field might be '00000123' when it should be
'123', if the date happened not to correspond to an epoch with a zero
in the eighth to last place. This has been the case for most of the
last 1041 days, but fortunately the bug was only introduced earlier
this year.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15520

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Martin Schwenke <mschwenke@ddn.com>
python/samba/tests/sid_strings.py