]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: dsa: b53: do not allow to configure VLAN 0
authorJonas Gorski <jonas.gorski@gmail.com>
Tue, 29 Apr 2025 20:17:06 +0000 (22:17 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 8 May 2025 02:30:35 +0000 (19:30 -0700)
commit45e9d59d39503bb3e6ab4d258caea4ba6496e2dc
treede519246321f2878a1a491ee13d7c7a75a9cde2c
parent13b152ae40495966501697693f048f47430c50fd
net: dsa: b53: do not allow to configure VLAN 0

Since we cannot set forwarding destinations per VLAN, we should not have
a VLAN 0 configured, as it would allow untagged traffic to work across
ports on VLAN aware bridges regardless if a PVID untagged VLAN exists.

So remove the VLAN 0 on join, an re-add it on leave. But only do so if
we have a VLAN aware bridge, as without it, untagged traffic would
become tagged with VID 0 on a VLAN unaware bridge.

Fixes: a2482d2ce349 ("net: dsa: b53: Plug in VLAN support")
Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
Tested-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://patch.msgid.link/20250429201710.330937-8-jonas.gorski@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/b53/b53_common.c