]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
iio: adc: ad7124: Disable all channels at probe time
authorUwe Kleine-König <u.kleine-koenig@baylibre.com>
Mon, 4 Nov 2024 10:19:04 +0000 (11:19 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 7 Dec 2024 17:13:25 +0000 (17:13 +0000)
commit4be339af334c283a1a1af3cb28e7e448a0aa8a7c
treee6a9ca3927b78abf033c2c206a4575d98bd0c1a9
parent4636e859ebe0011f41e35fa79bab585b8004e9a3
iio: adc: ad7124: Disable all channels at probe time

When during a measurement two channels are enabled, two measurements are
done that are reported sequencially in the DATA register. As the code
triggered by reading one of the sysfs properties expects that only one
channel is enabled it only reads the first data set which might or might
not belong to the intended channel.

To prevent this situation disable all channels during probe. This fixes
a problem in practise because the reset default for channel 0 is
enabled. So all measurements before the first measurement on channel 0
(which disables channel 0 at the end) might report wrong values.

Fixes: 7b8d045e497a ("iio: adc: ad7124: allow more than 8 channels")
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://patch.msgid.link/20241104101905.845737-2-u.kleine-koenig@baylibre.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/ad7124.c