]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
selftests/net: deflake GRO tests
authorKevin Krakauer <krakauer@google.com>
Wed, 26 Feb 2025 19:27:25 +0000 (11:27 -0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 28 Feb 2025 02:38:23 +0000 (18:38 -0800)
commit51bef03e1a71a27f2bc25c9739992d472830c83c
tree5380a6d09b5dab73f5733a26e71507102b80800e
parent41cda5728470618f1768cf71a2f3ae9fb550844d
selftests/net: deflake GRO tests

GRO tests are timing dependent and can easily flake. This is partially
mitigated in gro.sh by giving each subtest 3 chances to pass. However,
this still flakes on some machines. Reduce the flakiness by:

- Bumping retries to 6.
- Setting napi_defer_hard_irqs to 1 to reduce the chance that GRO is
  flushed prematurely. This also lets us reduce the gro_flush_timeout
  from 1ms to 100us.

Tested: Ran `gro.sh -t large` 1000 times. There were no failures with
this change. Ran inside strace to increase flakiness.

Signed-off-by: Kevin Krakauer <krakauer@google.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Link: https://patch.msgid.link/20250226192725.621969-4-krakauer@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/gro.sh
tools/testing/selftests/net/setup_veth.sh