]> git.ipfire.org Git - people/arne_f/kernel.git/commit
i2c: altera: Fix potential integer overflow
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 11 Feb 2020 14:47:04 +0000 (08:47 -0600)
committerWolfram Sang <wsa@the-dreams.de>
Thu, 13 Feb 2020 08:29:30 +0000 (09:29 +0100)
commit54498e8070e19e74498a72c7331348143e7e1f8c
treeb5e98b1662093294b2a64a93b641ed909e36dda5
parent9e661cedcc0a072d91a32cb88e0515ea26e35711
i2c: altera: Fix potential integer overflow

Factor out 100 from the equation and do 32-bit arithmetic (3 * clk_mhz / 10)
instead of 64-bit.

Notice that clk_mhz is MHz, so the multiplication will never wrap 32 bits
and there is no need for div_u64().

Addresses-Coverity: 1458369 ("Unintentional integer overflow")
Fixes: 0560ad576268 ("i2c: altera: Add Altera I2C Controller driver")
Suggested-by: David Laight <David.Laight@ACULAB.COM>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Thor Thayer <thor.thayer@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-altera.c