]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/char/bcm2835_aux: Fix assert when receive FIFO fills up
authorFrederik van Hövell <frederik@fvhovell.nl>
Mon, 29 Jul 2024 12:34:18 +0000 (13:34 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Mon, 29 Jul 2024 12:34:18 +0000 (13:34 +0100)
commit546d574b11e02bfd5b15cdf1564842c14516dfab
tree9d91f841898ab18e0f091e3a93814a990dbd9b39
parent93b799fafd9170da3a79a533ea6f73a18de82e22
hw/char/bcm2835_aux: Fix assert when receive FIFO fills up

When a bare-metal application on the raspi3 board reads the
AUX_MU_STAT_REG MMIO register while the device's buffer is
at full receive FIFO capacity
(i.e. `s->read_count == BCM2835_AUX_RX_FIFO_LEN`) the
assertion `assert(s->read_count < BCM2835_AUX_RX_FIFO_LEN)`
fails.

Reported-by: Cryptjar <cryptjar@junk.studio>
Suggested-by: Cryptjar <cryptjar@junk.studio>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/459
Signed-off-by: Frederik van Hövell <frederik@fvhovell.nl>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
[PMM: commit message tweaks]
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
hw/char/bcm2835_aux.c