]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/i2c/imx: Always set interrupt status bit if interrupt condition occurs
authorBernhard Beschow <shentey@gmail.com>
Wed, 7 May 2025 12:40:40 +0000 (14:40 +0200)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Thu, 8 May 2025 12:26:37 +0000 (14:26 +0200)
commit54e54e594bc8273d210f7ff4448c165a989cbbe8
tree1eb8919cbb1b0a0cac1239937355518727b24f35
parent35cb01fce6ea8aade77cbc3d7d77c83321bbaf9b
hw/i2c/imx: Always set interrupt status bit if interrupt condition occurs

According to the i.MX 8M Plus reference manual, the status flag
I2C_I2SR[IIF] continues to be set when an interrupt condition
occurs even when I2C interrupts are disabled (I2C_I2CR[IIEN] is
clear). However, the device model only sets the flag when I2C
interrupts are enabled which causes U-Boot to loop forever. Fix
the device model by always setting the flag and let I2C_I2CR[IIEN]
guard I2C interrupts only.

Also remove the comment in the code since it merely stated the
obvious and would be outdated now.

Cc: qemu-stable@nongnu.org
Fixes: 20d0f9cf6a41 ("i.MX: Add I2C controller emulator")
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Acked-by: Corey Minyard <cminyard@mvista.com>
Message-ID: <20250507124040.425773-1-shentey@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
hw/i2c/imx_i2c.c