]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
gh-133982: Run unclosed file test on all io implementations (gh-134165)
authorCody Maloney <cmaloney@users.noreply.github.com>
Wed, 21 May 2025 14:51:56 +0000 (10:51 -0400)
committerGitHub <noreply@github.com>
Wed, 21 May 2025 14:51:56 +0000 (16:51 +0200)
commit5b0e82752120a5dc66ce6ee778751d71ba2c33b2
tree82da1f1599316caffbd8e9178eebbe17cae41e4d
parent06eaf4055c1d7359e129efb65b94f34d2ec51a57
gh-133982: Run unclosed file test on all io implementations (gh-134165)

Update `test_io` `_check_warn_on_dealloc` to use `self.` to dispatch to
different I/O implementations.

Update the `_pyio` implementation to match expected behavior, using the
same `_dealloc_warn` design as the C implementation uses to report the
topmost `__del__` object.

The FileIO one now matches all the others, so can use IOBase. There was
a missing check on closing (self._fd must be valid), add that check
Lib/_pyio.py
Lib/test/test_io.py
Misc/NEWS.d/next/Library/2025-05-17-20-23-57.gh-issue-133982.smS7au.rst [new file with mode: 0644]