]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Replace pgwin32_is_junction() with lstat().
authorThomas Munro <tmunro@postgresql.org>
Sat, 6 Aug 2022 00:02:43 +0000 (12:02 +1200)
committerThomas Munro <tmunro@postgresql.org>
Sat, 6 Aug 2022 00:50:59 +0000 (12:50 +1200)
commit5fc88c5d53e43fa7dcea93499d230a0bf70f4f77
treeaf3b996847cc5e5844689aae67aaa100ea5516ae
parentf357233c9db8be2a015163da8e1ab0630f444340
Replace pgwin32_is_junction() with lstat().

Now that lstat() reports junction points with S_IFLNK/S_ISLINK(), and
unlink() can unlink them, there is no need for conditional code for
Windows in a few places.  That was expressed by testing for WIN32 or
S_ISLNK, which we can now constant-fold.

The coding around pgwin32_is_junction() was a bit suspect anyway, as we
never checked for errors, and we also know that errors can be spuriously
reported because of transient sharing violations on this OS.  The
lstat()-based code has handling for that.

This also reverts 4fc6b6ee on master only.  That was done because
lstat() didn't previously work for symlinks (junction points), but now
it does.

Tested-by: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://postgr.es/m/CA%2BhUKGLfOOeyZpm5ByVcAt7x5Pn-%3DxGRNCvgiUPVVzjFLtnY0w%40mail.gmail.com
src/backend/commands/tablespace.c
src/backend/replication/basebackup.c
src/backend/storage/file/fd.c
src/backend/utils/adt/misc.c
src/bin/pg_checksums/pg_checksums.c
src/bin/pg_rewind/file_ops.c
src/common/file_utils.c
src/include/port.h
src/include/port/win32_port.h
src/port/dirmod.c