]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Fix combination of --dev tap and --topology subnet across multiple platforms.
authorGert Doering <gert@greenie.muc.de>
Sun, 19 Aug 2018 20:07:03 +0000 (22:07 +0200)
committerGert Doering <gert@greenie.muc.de>
Sat, 6 Oct 2018 12:55:15 +0000 (14:55 +0200)
commit6c13e24e5709f404231632f14758ea8f6bd9ec83
treef6bab46a974d4708a3b1d4a0431882c952c5fd50
parent6f8fb6fe796015051f30d1327d89e1a63cf592e8
Fix combination of --dev tap and --topology subnet across multiple platforms.

--topology should have no effect in tap mode (tap is always "subnet"),
but due to the way options are checked, setting "topology subnet" caught
an improper branch on all non-linux and non-win32 platforms.

Easily tested by adding "--topology subnet" to a "--dev tap" t_client
test.

Tested, verified, and fixed on FreeBSD 10.4, NetBSD 7.0.1, OpenBSD 6.0,
and OpenSolaris 10.  Compile-tested on MacOS X.

Trac: #1085

Signed-off-by: Gert Doering <gert@greenie.muc.de>
Acked-by: Antonio Quartulli <antonio@openvpn.net>
Message-Id: <20180819200703.20362-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17414.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/tun.c