]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
sched: Fix out-of-bound access in uclamp
authorQuentin Perret <qperret@google.com>
Fri, 30 Apr 2021 15:14:12 +0000 (15:14 +0000)
committerPeter Zijlstra <peterz@infradead.org>
Thu, 6 May 2021 13:33:26 +0000 (15:33 +0200)
commit6d2f8909a5fabb73fe2a63918117943986c39b6c
tree7046c225d90183e5bd49a00a15a95cf703c37716
parentd583d360a620e6229422b3455d0be082b8255f5e
sched: Fix out-of-bound access in uclamp

Util-clamp places tasks in different buckets based on their clamp values
for performance reasons. However, the size of buckets is currently
computed using a rounding division, which can lead to an off-by-one
error in some configurations.

For instance, with 20 buckets, the bucket size will be 1024/20=51. A
task with a clamp of 1024 will be mapped to bucket id 1024/51=20. Sadly,
correct indexes are in range [0,19], hence leading to an out of bound
memory access.

Clamp the bucket id to fix the issue.

Fixes: 69842cba9ace ("sched/uclamp: Add CPU's clamp buckets refcounting")
Suggested-by: Qais Yousef <qais.yousef@arm.com>
Signed-off-by: Quentin Perret <qperret@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Link: https://lkml.kernel.org/r/20210430151412.160913-1-qperret@google.com
kernel/sched/core.c