]> git.ipfire.org Git - thirdparty/git.git/commit
object: fix leaking packfiles when closing object store
authorPatrick Steinhardt <ps@pks.im>
Thu, 8 Aug 2024 07:36:00 +0000 (09:36 +0200)
committerJunio C Hamano <gitster@pobox.com>
Thu, 8 Aug 2024 16:22:21 +0000 (09:22 -0700)
commit6f1e9394e2e02d16dfbef02c1585a1acfd2a5118
tree5d2d01e416eb67e41ffe56193260ae7ba803c619
parentfa0f27a19d4e2606ec24d9d4aed4f6c8df986370
object: fix leaking packfiles when closing object store

When calling `raw_object_store_clear()`, we close and free several
resources associated with the object store. Part of that is to close and
free all the packfiles, which is handled by `close_object_store()`.

That function really only ends up closing the packfiles though, but it
doesn't free them. And in fact it can't, as that function is being
called via `run_command()` when `close_object_store = 1`, which is done
e.g. when we execute git-maintenance(1). At that point, other structures
may still have references on those packfiles, and thus we cannot free
them here. So while it is in fact intentional that we really only close
them, the result is a memory leak because `raw_object_store_clear()`
does not free them, either.

Fix the leak by freeing the packfiles in `raw_object_store_clear()`.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
object.c
t/t7424-submodule-mixed-ref-formats.sh