]> git.ipfire.org Git - thirdparty/linux.git/commit
drm/xe/guc: Fix missing init value and add register order check
authorZhanjun Dong <zhanjun.dong@intel.com>
Tue, 26 Nov 2024 20:10:52 +0000 (12:10 -0800)
committerDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Mon, 2 Dec 2024 17:13:33 +0000 (09:13 -0800)
commit6f59fbcfa041e7d69e5e5f39d4c8cffa06fdc50b
tree48c89378b9534fa580ebfd09b995c623fdf4b854
parent4a69c4fbb8d53e8ace3586f395b1dc98244e4a8c
drm/xe/guc: Fix missing init value and add register order check

Fix missing initial value for last_value.
For GuC capture register definition, it is required to define 64bit
register in a pair of 2 consecutive 32bit register entries, low first,
then hi. Add code to check this order.

Changes from prior revs:
 v5:- Correct cross-line comment format
 v4:- Fix warn on condition and remove skipping
 v3:- Move break inside brace
 v2:- Correct the fix tag pointed commit
      Add examples in comments for warning
      Add 1 missing hi condition check

Fixes: ecb633646391 ("drm/xe/guc: Plumb GuC-capture into dev coredump")
Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241126201052.1937079-1-zhanjun.dong@intel.com
drivers/gpu/drm/xe/xe_guc_capture.c