]> git.ipfire.org Git - thirdparty/curl.git/commit
lib: connect/h2/h3 refactor
authorStefan Eissing <stefan@eissing.org>
Fri, 30 Dec 2022 08:14:55 +0000 (09:14 +0100)
committerDaniel Stenberg <daniel@haxx.se>
Fri, 30 Dec 2022 15:43:19 +0000 (16:43 +0100)
commit71b7e0161032927cdfb4e75ea40f65b8898b3956
treedf5d03d631e6d67703d54a011a25fff03ed5867c
parent1c18f8da51f9f37b68fb9422975d32c436e905a0
lib: connect/h2/h3 refactor

Refactoring of connection setup and happy eyeballing. Move
nghttp2. ngtcp2, quiche and msh3 into connection filters.

 - eyeballing cfilter that uses sub-filters for performing parallel connects
 - socket cfilter for all transport types, including QUIC
 - QUIC implementations in cfilter, can now participate in eyeballing
 - connection setup is more dynamic in order to adapt to what filter did
   really connect.  Relevant to see if a SSL filter needs to be added or
   if SSL has already been provided
 - HTTP/3 test cases similar to HTTP/2
 - multiuse of parallel transfers for HTTP/3, tested for ngtcp2 and quiche

 - Fix for data attach/detach in VTLS filters that could lead to crashes
   during parallel transfers.
 - Eliminating setup() methods in cfilters, no longer needed.
 - Improving Curl_conn_is_alive() to replace Curl_connalive() and
   integrated ssl alive checks into cfilter.
 - Adding CF_CNTRL_CONN_INFO_UPDATE to tell filters to update
   connection into and persist it at the easy handle.

 - Several more cfilter related cleanups and moves:
   - stream_weigth and dependency info is now wrapped in struct
     Curl_data_priority
   - Curl_data_priority members depend is available in HTTP2|HTTP3
   - Curl_data_priority members depend on NGHTTP2 support
   - handling init/reset/cleanup of priority part of url.c
   - data->state.priority same struct, but shallow copy for compares only

 - PROTOPT_STREAM has been removed
   - Curl_conn_is_mulitplex() now available to check on capability

 - Adding query method to connection filters.
   - ngtcp2+quiche: implementing query for max concurrent transfers.

 - Adding is_alive and keep_alive cfilter methods. Adding DATA_SETUP event.
   - setting keepalive timestamp on connect
   - DATA_SETUP is called after the connection has been completely
     setup (but may not connected yet) to allow filters to initialize
     data members they use.

 - there is no socket to be had with msh3, it is unclear how select
   shall work

 - manual test via "curl --http3 https://curl.se" fail with "empty
   reply from server".

 - Various socket/conn related cleanups:
   - Curl_socket is now Curl_socket_open and in cf-socket.c
   - Curl_closesocket is now Curl_socket_close and in cf-socket.c
   - Curl_ssl_use has been replaced with Cur_conn_is_ssl
   - Curl_conn_tcp_accepted_set has been split into
     Curl_conn_tcp_listen_set and Curl_conn_tcp_accepted_set
     with a clearer purpose

Closes #10141
48 files changed:
lib/Makefile.inc
lib/cf-socket.c [new file with mode: 0644]
lib/cf-socket.h [new file with mode: 0644]
lib/cfilters.c
lib/cfilters.h
lib/connect.c
lib/connect.h
lib/easy.c
lib/ftp.c
lib/http.c
lib/http.h
lib/http2.c
lib/http2.h
lib/http_proxy.c
lib/http_proxy.h
lib/imap.c
lib/multi.c
lib/pop3.c
lib/quic.h [deleted file]
lib/rtsp.c
lib/sendf.c
lib/setopt.c
lib/smtp.c
lib/socks.c
lib/socks.h
lib/transfer.c
lib/url.c
lib/url.h
lib/urldata.h
lib/version.c
lib/vquic/msh3.c
lib/vquic/msh3.h
lib/vquic/ngtcp2.c
lib/vquic/ngtcp2.h
lib/vquic/quiche.c
lib/vquic/quiche.h
lib/vquic/vquic.c
lib/vquic/vquic.h
lib/vquic/vquic_int.h [new file with mode: 0644]
lib/vssh/libssh2.c
lib/vtls/openssl.c
lib/vtls/vtls.c
lib/vtls/vtls.h
tests/data/Makefile.inc
tests/data/test2501 [new file with mode: 0644]
tests/data/test2502 [new file with mode: 0644]
tests/libtest/Makefile.inc
tests/libtest/lib2502.c [new file with mode: 0644]